OK, I got it, thank you for carefully reviewing my patch set, thank you very mach!

Thanks,
Chao

On 2024/1/31 00:45, Laszlo Ersek wrote:

On 1/30/24 02:24, Chao Li wrote:

On 2024/1/30 03:49, Laszlo Ersek wrote:

I suggest adding the following to your edk2 git config:

[core]
        attributesFile = BaseTools/Conf/gitattributes

[diff "ini"]
        xfuncname = ^\\[[A-Za-z0-9_., ]+]

Next time I will add these two configures in my git config file, it will
be reflected in V9 if it needed to commit.

Thanks -- yes, that was what I meant. Certainly no need to repost the
series just because of that; it's just that getting these settings in
place "eventually" is good.

Ha, yes, patch 18 is added a new type, and I just add them under this
new type and it worked. Do you recommend these two PCDs keep the type
with PcdsFixedAtBuild only? If yes, in V9 I would move them under
PcdsFixedAtBuild.

No, I think you did the right thing. The original permitted storage type
list was [PcdsFixedAtBuild, PcdsPatchableInModule], and IIRC at least
the ArmVirtQemuKernel platform relies on patchable PCDs. So restricting
the storage type list to just [PcdsFixedAtBuild] across the move could
cause a regression, at least in theory -- so it's best not to disturb
that. Indeed, thus far we've not needed PcdsPatchableInModule in OVMF,
but now that OvmfPkg accommodates more widely used artifacts, we do!

Thanks!
Laszlo

_._,_._,_

Groups.io Links:

You receive all messages sent to this group.

_._,_._,_