From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9161B78003C for ; Wed, 31 Jan 2024 01:31:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Jk7pj1XHgkSiLr/APOjhYTtjm5Lhc6xWOlN4/f6RExU=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1706664663; v=1; b=USsMoEn929/d/ScAD/ceQxGBhUGY6yjtaEg2/xq7dYoffqepM8z4v+uiLLGXaDCV2uP1jhC2 /IXXuZjL4oagONm3qIkY9+OwS/H8qS+G/tLmFdm5jo7CKdPBEKPRIdfe5UX+gw6tP1EINBT4iIw IjriEk/RLNE4lc0keFozvKM8= X-Received: by 127.0.0.2 with SMTP id bpTKYY7687511x3PZjiyhdaC; Tue, 30 Jan 2024 17:31:03 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.4528.1706664661244135816 for ; Tue, 30 Jan 2024 17:31:01 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8AxqvDSorllFbsIAA--.26640S3; Wed, 31 Jan 2024 09:30:58 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxnhPSorllkVApAA--.39852S3; Wed, 31 Jan 2024 09:30:58 +0800 (CST) Message-ID: <2d4ac6b9-e8d5-423c-bca1-9458f9593baf@loongson.cn> Date: Wed, 31 Jan 2024 09:30:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v8 24/37] ArmVirtPkg: Move two PCD variables into OvmfPkg To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Gerd Hoffmann , Jiewen Yao References: <20240126062715.3099433-1-lichao@loongson.cn> <20240126063017.3102349-1-lichao@loongson.cn> <9bb8c832-7791-40af-89a4-ca5794c026de@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8BxnhPSorllkVApAA--.39852S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQANCGW4s2EHGgAEsS X-Coremail-Antispam: 1Uk129KBj93XoW7tr43uF1rWrWUAFy8XryrAFc_yoW8GFy5pw sxK3s0kr4kGry7ta1kAr48u3y29397AryUtr1rtryru3s8Ga4xGFnagw42qa4rWrs3Kr1Y vrs0gryqyFy3CFXCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUymb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67 AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UM2AIxVAIcxkEcVAq07x2 0xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx 0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCjr7xv wVCIw2I0I7xG6c02F41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2 IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v2 6r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2 IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf 9x07UEFAJUUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EvJBYnN4YfX8hEzdy24dzH91x7686176AA= Content-Type: multipart/alternative; boundary="------------ZZlL0nBHpVOLBDC0X5Xq6Axy" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=USsMoEn9; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------ZZlL0nBHpVOLBDC0X5Xq6Axy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable OK, I got it, thank you for carefully reviewing my patch set, thank you=20 very mach! Thanks, Chao On 2024/1/31 00:45, Laszlo Ersek wrote: > On 1/30/24 02:24, Chao Li wrote: >> On 2024/1/30 03:49, Laszlo Ersek wrote: >>> I suggest adding the following to your edk2 git config: >>> >>> [core] >>> attributesFile =3D BaseTools/Conf/gitattributes >>> >>> [diff "ini"] >>> xfuncname =3D ^\\[[A-Za-z0-9_., ]+] >> Next time I will add these two configures in my git config file, it will >> be reflected in V9 if it needed to commit. > Thanks -- yes, that was what I meant. Certainly no need to repost the > series just because of that; it's just that getting these settings in > place "eventually" is good. > >> Ha, yes, patch 18 is added a new type, and I just add them under this >> new type and it worked. Do you recommend these two PCDs keep the type >> with PcdsFixedAtBuild only? If yes, in V9 I would move them under >> PcdsFixedAtBuild. > No, I think you did the right thing. The original permitted storage type > list was [PcdsFixedAtBuild, PcdsPatchableInModule], and IIRC at least > the ArmVirtQemuKernel platform relies on patchable PCDs. So restricting > the storage type list to just [PcdsFixedAtBuild] across the move could > cause a regression, at least in theory -- so it's best not to disturb > that. Indeed, thus far we've not needed PcdsPatchableInModule in OVMF, > but now that OvmfPkg accommodates more widely used artifacts, we do! > > Thanks! > Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114841): https://edk2.groups.io/g/devel/message/114841 Mute This Topic: https://groups.io/mt/103971670/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------ZZlL0nBHpVOLBDC0X5Xq6Axy Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

OK, I got it, thank you for carefully reviewing my patch set, thank you very mach!


=
Thanks,
Chao
On 2024/1/31 00:45, Laszlo Ersek wrote:<= br> 
On 1/30/24 02:24, Chao Li wrot=
e:

On 2024/1/30 03:49, Laszlo E=
rsek wrote:


      

        

          
I suggest adding the follo=
wing to your edk2 git config:

[core]
        attributesFile =3D BaseTools/Conf/gitattributes

[diff "ini"]
        xfuncname =3D ^\\[[A-Za-z0-9_., ]+]


        

      

      

      

        
Next time I will add these t=
wo configures in my git config file, it will
be reflected in V9 if it needed to commit.


      

      
Thanks -- yes, that was what I meant. Certainly no need to repost the
series just because of that; it's just that getting these settings in
place "eventually" is good.



      

        
Ha, yes, patch 18 is added a=
 new type, and I just add them under this
new type and it worked. Do you recommend these two PCDs keep the type
with PcdsFixedAtBuild only? If yes, in V9 I would move them under
PcdsFixedAtBuild.


      

      
No, I think you did the right thing. The original permitted storage type
list was [PcdsFixedAtBuild, PcdsPatchableInModule], and IIRC at least
the ArmVirtQemuKernel platform relies on patchable PCDs. So restricting
the storage type list to just [PcdsFixedAtBuild] across the move could
cause a regression, at least in theory -- so it's best not to disturb
that. Indeed, thus far we've not needed PcdsPatchableInModule in OVMF,
but now that OvmfPkg accommodates more widely used artifacts, we do!

Thanks!
Laszlo


    

  




_._,_._,_





Groups.io Links:



 =20
    You receive all messages sent to this group.
 =20
 =20




View/Reply Online (#114841) |


 =20

|

  Mute=
 This Topic


| New Topic







Your Subscriptio=
n |
Contact Group Owner |

Unsubscribe

 [rebecca@openfw.io]


_._,_._,_



--------------ZZlL0nBHpVOLBDC0X5Xq6Axy--