From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F0A7A740039 for ; Tue, 9 Jan 2024 15:05:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=821I8wy7zAJQ17ffwUVyrfLnG5UGqzUya8Sv6ujq5xs=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704812702; v=1; b=Kg4uEisWb7gZM/ukxl7FQgy4TMz0oQyauxwsZPgmuleJOCrnEKXMbccreLDQW5BcY0dk/ElB bPQvjlrmu+Higg/aA7/7muIWwGfqC6I5YpKLuCOkrDaoc0zMmNqbBSeXcXeWD9XREn5zJXcwLE1 d4SZQOjsUvty9ntU/pfPzVaU= X-Received: by 127.0.0.2 with SMTP id NDRYYY7687511xPu2sIzqwgu; Tue, 09 Jan 2024 07:05:02 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.1534.1704696172441964401 for ; Sun, 07 Jan 2024 22:42:52 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="377290531" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="377290531" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 22:42:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="924768188" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="924768188" X-Received: from basatg01.gar.corp.intel.com ([10.66.253.28]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 22:42:50 -0800 From: Pethaiyan Madhan To: devel@edk2.groups.io Cc: "Pethaiyan, Madhan" , Liming Gao , Michael D Kinney , Wei6 Xu Subject: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition Date: Mon, 8 Jan 2024 12:12:39 +0530 Message-Id: <2d53b710572890495a268f208027c8de1e9b7fea.1704696138.git.madhan.pethaiyan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,madhan.pethaiyan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: TzrhzjYHmVabQa6EKws4HCyWx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Kg4uEisW; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: "Pethaiyan, Madhan" UEFI Spec 2.10 , 23.1 Firmware Management Protocol , Added missing condition check under GetImageInfo function, if the PackageVersionName is NULL return EFI_INVALID_PARAMETER Signed-off-by: Pethaiyan Madhan Cc: Liming Gao Cc: Michael D Kinney Cc: Wei6 Xu --- FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index 1e7ec4a09e..e87094f84c 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -495,7 +495,7 @@ GetTheImageInfo ( // Confirm that buffer isn't null // if ( (ImageInfo == NULL) || (DescriptorVersion == NULL) || (DescriptorCount == NULL) || (DescriptorSize == NULL) - || (PackageVersion == NULL)) + || (PackageVersion == NULL) || (PackageVersionName == NULL)) { DEBUG ((DEBUG_ERROR, "FmpDxe(%s): GetImageInfo() - Pointer Parameter is NULL.\n", mImageIdName)); Status = EFI_INVALID_PARAMETER; -- 2.38.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113453): https://edk2.groups.io/g/devel/message/113453 Mute This Topic: https://groups.io/mt/103620853/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-