public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: <devel@edk2.groups.io>, <ardb@kernel.org>
Cc: <quic_llindhol@quicinc.com>, <mikuback@linux.microsoft.com>
Subject: Re: [edk2-devel] [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode
Date: Wed, 7 Sep 2022 10:11:12 -0600	[thread overview]
Message-ID: <2d5d2c23-549a-84b0-0ab8-cfe22f110cd1@quicinc.com> (raw)
In-Reply-To: <20220907152712.1236460-1-ardb@kernel.org>

Reviewed-by: Rebecca Cran <rebecca@quicinc.com>

On 9/7/22 09:27, Ard Biesheuvel wrote:
> Don't allow spelling errors to break the CI build and inadvertently
> reject pull requests - spelling is important but not that important.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>   ArmPkg/ArmPkg.ci.yaml         | 2 +-
>   ArmVirtPkg/ArmVirtPkg.ci.yaml | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> index b7e07aaef675..24db74250513 100644
> --- a/ArmPkg/ArmPkg.ci.yaml
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -87,7 +87,7 @@
>   
>       ## options defined .pytool/Plugin/SpellCheck
>       "SpellCheck": {
> -        "AuditOnly": False,
> +        "AuditOnly": True,
>           "IgnoreFiles": [
>               "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
>           ],                           # use gitignore syntax to ignore errors
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index d5d63ddd4fd7..1e799dc4e194 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -96,7 +96,7 @@
>   
>       ## options defined .pytool/Plugin/SpellCheck
>       "SpellCheck": {
> -        "AuditOnly": False,           # Fails right now with over 270 errors
> +        "AuditOnly": True,
>           "IgnoreFiles": [],           # use gitignore syntax to ignore errors in matching files
>           "ExtendWords": [
>               "acpiview",


  parent reply	other threads:[~2022-09-07 16:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 15:27 [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode Ard Biesheuvel
2022-09-07 15:33 ` Michael Kubacki
2022-09-07 16:11 ` Rebecca Cran [this message]
2022-09-08  7:30 ` [edk2-devel] " Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d5d2c23-549a-84b0-0ab8-cfe22f110cd1@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox