From: "Corvin Köhne" <corvink@FreeBSD.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, Michael Roth <michael.roth@amd.com>,
Oliver Steffen <osteffen@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Laszlo Ersek <lersek@redhat.com>, Min Xu <min.m.xu@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Erdem Aktas <erdemaktas@google.com>
Subject: Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process.
Date: Mon, 03 Jun 2024 09:13:09 +0200 [thread overview]
Message-ID: <2d5dbf531c606d5f2148f2779f2ca9b2a71e8934.camel@FreeBSD.org> (raw)
In-Reply-To: <hahwztyl7skh7bfrofufblmg2xko3ccqiynumzdhj55rzx42gd@ggoawunkfjkx>
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
On Thu, 2024-05-30 at 11:03 +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > - SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.Fixed,
> > > 0x06);
> > > + SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.Fixed,
> > > MTRR_CACHE_WRITE_BACK);
> > > ZeroMem (&MtrrSettings.Variables, sizeof
> > > MtrrSettings.Variables);
> > > - MtrrSettings.MtrrDefType |= BIT11 | BIT10 | 6;
> > > + MtrrSettings.MtrrDefType |= BIT10;
> > > MtrrSetAllMtrrs (&MtrrSettings);
> > >
> > > //
> >
> > This has to be changed for OvmfPkg/Bhyve/PlatformPei/MemDetect.c
> > too.
>
> I have a draft PR open with this fixed:
> https://github.com/tianocore/edk2/pull/5696
>
> Can you check this works for bhyve?
>
> thanks,
> Gerd
>
Works. Thanks!
--
Kind regards,
Corvin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119423): https://edk2.groups.io/g/devel/message/119423
Mute This Topic: https://groups.io/mt/104052591/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-06-03 7:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 13:04 [edk2-devel] [PATCH v3 0/4] OvmfPkg/Sec: Setup MTRR early in the boot process Gerd Hoffmann
2024-01-30 13:04 ` [edk2-devel] [PATCH v3 1/4] " Gerd Hoffmann
2024-01-30 19:22 ` Laszlo Ersek
2024-01-31 12:06 ` Laszlo Ersek
2024-02-01 5:20 ` Min Xu
2024-02-01 6:10 ` Sun, Yi Y
2024-02-01 9:43 ` Gerd Hoffmann
2024-02-01 9:49 ` Sun, Yi Y
2024-02-01 9:38 ` Gerd Hoffmann
2024-02-12 15:22 ` Gerd Hoffmann
2024-02-20 6:27 ` Min Xu
2024-02-20 8:15 ` Gerd Hoffmann
2024-04-11 6:56 ` Corvin Köhne
2024-04-11 8:12 ` Gerd Hoffmann
2024-04-15 1:04 ` Min Xu
2024-05-22 8:59 ` Corvin Köhne
2024-05-30 9:03 ` Gerd Hoffmann
2024-06-03 7:13 ` Corvin Köhne [this message]
2024-06-03 10:38 ` Gerd Hoffmann
2024-01-30 13:04 ` [edk2-devel] [PATCH v3 2/4] MdePkg/ArchitecturalMsr.h: add #defines for MTRR cache types Gerd Hoffmann
2024-01-30 17:49 ` Michael D Kinney
2024-01-30 19:23 ` Laszlo Ersek
2024-01-30 19:28 ` Laszlo Ersek
2024-01-30 13:04 ` [edk2-devel] [PATCH v3 3/4] UefiCpuPkg/MtrrLib.h: use cache type #defines from ArchitecturalMsr.h Gerd Hoffmann
2024-01-30 17:49 ` Michael D Kinney
2024-01-30 19:24 ` Laszlo Ersek
2024-01-30 19:26 ` Laszlo Ersek
2024-01-30 19:29 ` Laszlo Ersek
2024-01-30 13:04 ` [edk2-devel] [PATCH v3 4/4] OvmfPkg/Sec: " Gerd Hoffmann
2024-01-30 19:25 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d5dbf531c606d5f2148f2779f2ca9b2a71e8934.camel@FreeBSD.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox