From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 049D6740045 for ; Mon, 3 Jun 2024 07:13:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Z0gtYxIhVXuwjimi5n3ZR5PyIHbyUTDMXrkTP22M7fs=; c=relaxed/simple; d=groups.io; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:Autocrypt:User-Agent:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1717398795; v=1; b=rvzd8eNVaAA3FIB/5jaD9SfkpBSBx5cSKuDIllwTP6UXKMHhlxhtgfObIkSP8KXF2Fd8OZjq 1vLPqORYYwe49VaCvaSXrDCc2ODb23nZkBwcZ6iwEqUg1xQ10vcLnUY++8S5Ql+g05vPbMaxzUG 8Vrz8f2Yatw/FUJy9fKc2KLJ0GcnF88SVP0FzQjajyeCgeEcRcEIFsLAVAlNBHb3vYs5TU3r3O+ JmbJP6JA2jqSE0GCJoT8U+HS1s/2AWCY+kEiL9tvynEdGf5K/orMUDF7Dc0dfRBamgyNTBTUxG1 hex2aVX6rHSAHnA33NIvzbwvItgr0su8HcEBZbn0pgRRA== X-Received: by 127.0.0.2 with SMTP id Im32YY7687511xsIT7g5ImqV; Mon, 03 Jun 2024 00:13:14 -0700 X-Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mx.groups.io with SMTP id smtpd.web11.77563.1717398793604977044 for ; Mon, 03 Jun 2024 00:13:13 -0700 X-Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4Vt4gr5WqHz4150; Mon, 3 Jun 2024 07:13:12 +0000 (UTC) (envelope-from corvink@FreeBSD.org) X-Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vt4gr3RD0z44PT; Mon, 3 Jun 2024 07:13:12 +0000 (UTC) (envelope-from corvink@FreeBSD.org) X-Received: from [172.21.179.142] (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vt4gq1WNgzYbb; Mon, 3 Jun 2024 07:13:11 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: <2d5dbf531c606d5f2148f2779f2ca9b2a71e8934.camel@FreeBSD.org> Subject: Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process. From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: Gerd Hoffmann Cc: devel@edk2.groups.io, Michael Roth , Oliver Steffen , Jiewen Yao , Tom Lendacky , Laszlo Ersek , Min Xu , Ard Biesheuvel , Erdem Aktas Date: Mon, 03 Jun 2024 09:13:09 +0200 In-Reply-To: References: <20240130130441.772484-1-kraxel@redhat.com> <20240130130441.772484-2-kraxel@redhat.com> <78c0f23dbca552daefd01ca10751a10392a8af04.camel@FreeBSD.org> Autocrypt: addr=corvink@FreeBSD.org; prefer-encrypt=mutual; keydata=mQINBGNjZaIBEADDTrDNf+0pwiuRPBdClcnZW83dH1UhuOi0u+A1J2SatEBbNaFVtXXAa vewCTuyV/ZbNidjlhq3R/pWyiKjFKvs5dj7PMCw+3z2D5OWpMdHg7TrB+fbdFPOEsu0zQVKNaO+pS KCfN0Re0m7bL3wuvl7PXvBufRwA3Guo1P4j3TXWaEkuso7VupTvE25zVGg9ONHrGOjA9RUy+Yg4Se 3NLgtUdjBgA21SBQTDvRQV4fDmVenlwvWeE0Xm8FcDcpQb6sJTihaDku78mi3Ux1HCk7rTcepVEB0 xIB6qmFxv0sLlDmVv6Z6qg1y/Q5m23Pgz60o3TulMPV4F+3Itm8ifU+wgVSzBZbD29GYkd7LKqMkF bhvfSBk+5db3vbYY5OD//+LTM5AV7e2AhXuXMvG1UNBqXqSJTTSy6KZz+qmPQO0zos0dq46p8o82l KiBEGD2Hu0p+u0OyV+MmRYo1NIBFVbOPXp2MvUVl5II0UIJ3+N9gLBmfGA+HEpVO8PnvdoT/5NQ7m 8JK1rQHzjiDub/iDPAYMqKH4C0eZ/7zO0fuY5FeRNtuNtpH1Bw/+7/5RJH7bcKkfGHHEp15FJUrGH gWNydoDLB9QBprwQc8FEldDXBjzOMXIgh6FGKLNu6DswvIPGy6M3u7DXwDakCXz+c9Ym0oFihLzZx WntrsxdswD/CwARAQABtCdDb3J2aW4gS8O2aG5lIDxjb3J2aW4ua29laG5lQGdtYWlsLmNvbT6JAl QEEwEIAD4WIQSC9FKVreba38fZT0bYVNpWMV4CagUCZArUIwIbAwUJCWYBgAULCQgHAgYVCgkICwI EFgIDAQIeAQIXgAAKCRDYVNpWMV4CalcID/44k2i/mqSSi4W6FAobSF1nFLtP/pfcRNJriWKx2UF7 cfFMKyg7Nilg7FhLb5FDB1umUW2nFfchFPTUp4FfKzgRvPzIMg4RIRcVtTpYbl3z7zs9ZXD8qS//i ibbiUG3quncm6tO2x1jLZD3ORC+8MuLGXhYQIa4O5vVF2SBHdb/U6P+wsrF+U+OpRdEdQ/4Xu9S02 kltzBGgArjcexdhUqEqW01KCCSH0+qgfN1NE+9L934ZOB+cai2b9apPbCOGuV6KcUKMj4z0RWInhl XIyMqtmhdix/P/GjrQ1REVNdp74JeweSSedM15wwc6YLMXPrtOnnExyZ1gyNFYaub+Mdo3ZQ+8386 3B0C9IlpzEW0K8bYlZrl4WBNdcMOyByETAxgQmBgP6ZFErTtaeUOH1nX2FyR6o2GLSahRgngQmnRE zScTpPbBEkMwJMDAO+rbjjGxjeKSUwD1WOfbI6QZj+MS/uBk2p08kgN7fQaCEwj6jqML/IIE+FZ9I In6TNG0hChD384VHO+YioLBno1Atgi4Q7JUWSRIHQXZW+StQajFrWPPyKQwCe1MwqpKoMpX/q8IZB lzwJgZS8ShLeFZjtzOt1jgM99TD91Neonf9OzjTSbfo7sJviSWoICMhB/MvDZjj+naMVF86uGFxnI EsjVKyBxlJd4TRHnLYPTIHFKBLQjQ29ydmluIEvDtmhuZSA8Y29ydmlua0BGcmVlQlNELm9yZz6JA lQEEwEKAD4WIQSC9FKVreba38fZT0bYVNpWMV4CagUCY2NlogIbAwUJCWYBgAULCQgHAwUVCgkICw UWAwIBAAIeAQIXgAAKCRDYVNpWMV4CavfDEACCFnXpR7H9eOgP+GJMNPtK6i9/xnqdyXi8uCZIN0h YwjN4Xzo9SMLOf4UUlQEveOB+bGqbRfHd/fGKnrlXiPd0SGpKWJC21gqL/DsIH0J8I3Whth+O8tfP WeFy0oCsvBaaGFLIrDfoIgHF9i/gqEe48xhN42weB02Z3mdR1L0d7ME/BLwS0mCXe9Zh3uHw63S6x YB3Wsjptxe/ph6TpQDUKWtRJkjC6BqXPBdThpbbfIRWmjZbp2fKEJPvtRXS14+gbUqWeJ4xCvprA3 +ae7vtrp91X775yngyW3XTw5cmDiJIjykH8+zhEIoNQXNBpFrehkQDYrcM+WoE6NGSJo+3VJvSRWh UGWDVrxdTYNkbIjmTNlkI12NINC007DiuV7OF9XHWgrbbylvuZvbODmbJRdhTFy9upAUygX1/xUAQ EIMqMiJmyTdv8i0IbZ611WElQx9XHgGeZgM6+39/laN8FwspM6gE/4NzZHIZN0LEBOerZqoF+Il6e ccQpoEWx7nb/RilJp3dUUyvkBnJWg+AJByosg857kvvmDnZ3UB+bejWpcfFvnbkiKPUBPDO7tWPb5 r2yFDpDe/Vg5x+sRbkkXGUFD6Rx0p/ZiRIneVVg8emTzhDR0IL/BZkq/uVJkdaphZli1F/31cNgf6 ZJYnjxlk86uiYSySZQR0dKLDqq7QlQ29ydmluIEvDtmhuZSA8Yy5rb2VobmVAYmVja2hvZmYuY29t PokCVAQTAQgAPhYhBIL0UpWt5trfx9lPRthU2lYxXgJqBQJkCtScAhsDBQkJZgGABQsJCAcCBhUKC QgLAgQWAgMBAh4BAheAAAoJENhU2lYxXgJqI+QQAML5PTR7KpUFV3SLG60LQJGEOHUfDmJYczxBFb IAq1U4hIbivopu1AdLty7oDDrIjCVoa2/Cy34dd99O7lhLvUmZFB/zDSUtbUg2zhDkU0YSZ11Fdrl Wzky2tFaQRgxpDvWlUP0baa3Pd4dPDRiIUI6AOSR2SL6XANk6sJh56gLVM6G8yyafGsxSyDYg6Z78 EEMFejHwB+KP2DdsahupzM+F97HeC1+bOHYxtqN+2hEkPLtQWizyumPqNg5FvZhwe7yO8V95hF3Rh uDO+9aJT+WLLvcZEb/L1bI04IvZ5FWgCLI7Levd/DuOtZI8gWapHhqGZRbXB2fuJkCoKCl6V67h/7 aWhU3LjFTsC5siJyrxPjapKcIk8a7PqZDswNCKR+24LJ5D59mPgEOnsiCCVpik1WE/kgD+rOu9dQx jpjKwuKowf4EJP1KYNkYtoy1HthzyTOqPwqXC3IUl0GVPO3xw6MhUM3irCVFruC+ecVrv85Rd37vr duT6JvgW92xjWegMsamtkDZH8Ik/cmYhH0K/qEc6OZVNea/4PTEZe0uxODJ6pbMd80AJyGqDPPVeA gWJtEIG4k6IS8XyD5v1QJtlpDVpPwP/bbFnVc3h3Oatfn8Etm1KAqYvNwyO+om2PkF1p732uapDZd LwksVmgc9s79+9pSpeP5DbIeMzhrIK User-Agent: Evolution 3.52.1 MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 03 Jun 2024 00:13:13 -0700 Resent-From: corvink@FreeBSD.org Reply-To: devel@edk2.groups.io,corvink@FreeBSD.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vF0FMSki2JHWnHcyQEq7TyhKx7686176AA= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-6MJgv7gy8e0/zn736wYz" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=rvzd8eNV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=FreeBSD.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --=-6MJgv7gy8e0/zn736wYz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2024-05-30 at 11:03 +0200, Gerd Hoffmann wrote: > =C2=A0 Hi, >=20 > > > -=C2=A0=C2=A0=C2=A0 SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.= Fixed, > > > 0x06); > > > +=C2=A0=C2=A0=C2=A0 SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.= Fixed, > > > MTRR_CACHE_WRITE_BACK); > > > =C2=A0=C2=A0=C2=A0=C2=A0 ZeroMem (&MtrrSettings.Variables, sizeof > > > MtrrSettings.Variables); > > > -=C2=A0=C2=A0=C2=A0 MtrrSettings.MtrrDefType |=3D BIT11 | BIT10 | 6; > > > +=C2=A0=C2=A0=C2=A0 MtrrSettings.MtrrDefType |=3D BIT10; > > > =C2=A0=C2=A0=C2=A0=C2=A0 MtrrSetAllMtrrs (&MtrrSettings); > > > =C2=A0 > > > =C2=A0=C2=A0=C2=A0=C2=A0 // > >=20 > > This has to be changed for OvmfPkg/Bhyve/PlatformPei/MemDetect.c > > too. >=20 > I have a draft PR open with this fixed: > https://github.com/tianocore/edk2/pull/5696 >=20 > Can you check this works for bhyve? >=20 > thanks, > =C2=A0 Gerd >=20 Works. Thanks! --=20 Kind regards, Corvin -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119423): https://edk2.groups.io/g/devel/message/119423 Mute This Topic: https://groups.io/mt/104052591/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --=-6MJgv7gy8e0/zn736wYz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmZdbQYACgkQ2FTaVjFe AmqDSA//YDOAbUVjL0fp5OddglMhb0fXcwF/eaREDds1A516k6Xy0SZVOVFxDcgw Sq3L/OjOmMAxIXWem+KJXY8WXAS73WWf88TzzNXqzZ93MqIlJQ8fz/lQ4ZR5WwEj oXyKwK2ehcMXEoKCac1Ik1PZHwnd03JmFQdsEiEoaG8LRR+iHizqWqOztDEwsnfT GNwFaWI//MDXTHa9R5+My33T8r91NZuDvdCiihpocL3b14Anz5X0def7UieOC+2R zRL6Oc2UywYZjVX2GGH+bJRpmQUNMLigBbObmbycCrBPjRuczHAT7gd/zzr0URzq RZbCoKk18w4Xf23JQR7aLI3r332G5kSp7Pk2O0AZA6Bo+t/O1noNyX95a1U11EnY 6XILUemYu3umoikBYN4nszGNsRT31nK1W/EFvMpP2yItJ0+Ys4O+Ldk5tWteWwcp 9wcEl74QvH2hZ3OeE8GMHcGR8N5UfAShPVbHjak+mWHKoEvTTWszLQshLndfCdoL K2n29aRqCbp8VP6mc011kxIHwMf+yFWxDfQwDuYhJW4u3AbwXrTEXa1wLVkbVJ2i 7CX3BnBoL7LIwJ/HQ8Cr/cfTDsl9L8v+5gAMJnE/1C9FglVUNQvrCvyXUlOmW0av YsXYMegGFDX616WcdxizrIV4TMB7k1cNyNpOqGmcmQNFffBrFtQ= =ATcU -----END PGP SIGNATURE----- --=-6MJgv7gy8e0/zn736wYz--