From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 12751211963F6 for ; Fri, 7 Dec 2018 04:48:08 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8036E308424B; Fri, 7 Dec 2018 12:48:07 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-214.rdu2.redhat.com [10.10.120.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id B145E5DD64; Fri, 7 Dec 2018 12:47:56 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Michael D Kinney , Liming Gao , Jian J Wang , Hao Wu , Leif Lindholm , Eric Auger , Andrew Jones , Philippe Mathieu-Daude References: <20181207112304.19765-1-ard.biesheuvel@linaro.org> <20181207112304.19765-7-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <2d6f05de-8f9a-bec6-bf3c-0037f9f27df4@redhat.com> Date: Fri, 7 Dec 2018 13:47:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181207112304.19765-7-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 07 Dec 2018 12:48:07 +0000 (UTC) Subject: Re: [RFC PATCH 6/7] ArmVirtPkg/MemoryInitPeiLib: split memory HOB based on MAX_ALLOC_ADDRESS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2018 12:48:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/07/18 12:23, Ard Biesheuvel wrote: > The current ArmVirtMemoryInitPeiLib code splits the memory region passed > via PcdSystemMemoryBase/PcdSystemMemorySize in two if the region extends > beyond the MAX_ADDRESS limit. This was introduced for 32-bit ARM, which > may support more than 4 GB of physical address space, but cannot address > all of it via a 1:1 mapping, and a single region that is not mappable > in its entirety is unusable by the PEI core. > > AArch64 is in a similar situation now: platforms may support more than > 256 TB of physical address space, but only 256 TB is addressable by the > CPU, and so a memory region that extends from below this limit to above > it should be split. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/Library/ArmVirtMemoryInitPeiLib/ArmVirtMemoryInitPeiLib.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/ArmVirtPkg/Library/ArmVirtMemoryInitPeiLib/ArmVirtMemoryInitPeiLib.c b/ArmVirtPkg/Library/ArmVirtMemoryInitPeiLib/ArmVirtMemoryInitPeiLib.c > index 05afd1282422..66925fc05ebd 100644 > --- a/ArmVirtPkg/Library/ArmVirtMemoryInitPeiLib/ArmVirtMemoryInitPeiLib.c > +++ b/ArmVirtPkg/Library/ArmVirtMemoryInitPeiLib/ArmVirtMemoryInitPeiLib.c > @@ -75,18 +75,18 @@ MemoryPeim ( > SystemMemoryTop = PcdGet64 (PcdSystemMemoryBase) + > PcdGet64 (PcdSystemMemorySize); > > - if (SystemMemoryTop - 1 > MAX_ADDRESS) { > + if (SystemMemoryTop - 1 > MAX_ALLOC_ADDRESS) { > BuildResourceDescriptorHob ( > EFI_RESOURCE_SYSTEM_MEMORY, > ResourceAttributes, > PcdGet64 (PcdSystemMemoryBase), > - (UINT64)MAX_ADDRESS - PcdGet64 (PcdSystemMemoryBase) + 1 > + (UINT64)MAX_ALLOC_ADDRESS - PcdGet64 (PcdSystemMemoryBase) + 1 > ); > BuildResourceDescriptorHob ( > EFI_RESOURCE_SYSTEM_MEMORY, > ResourceAttributes, > - (UINT64)MAX_ADDRESS + 1, > - SystemMemoryTop - MAX_ADDRESS - 1 > + (UINT64)MAX_ALLOC_ADDRESS + 1, > + SystemMemoryTop - MAX_ALLOC_ADDRESS - 1 > ); > } else { > BuildResourceDescriptorHob ( > Looks correct to me. Reviewed-by: Laszlo Ersek