From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D6442211BD612 for ; Wed, 30 Jan 2019 07:51:05 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 07:51:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,541,1539673200"; d="scan'208";a="118693736" Received: from linux.intel.com ([10.54.29.200]) by fmsmga007.fm.intel.com with ESMTP; 30 Jan 2019 07:51:04 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 51825580550; Wed, 30 Jan 2019 07:51:03 -0800 (PST) Message-ID: <2d73405aa10512bd6bccf34288db30f1b50ab9cf.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 16:51:01 +0100 In-Reply-To: <20181115023353.20159-6-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-6-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 05/20] IntelUndiPkg/XGigUndiDxe: add missing VOID** cast X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:51:06 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > Unlike Visual Studio, GCC does not permit implicit conversion between > a pointer-to-void-pointer and pointer to a typed pointer. So add the > explicit casts where necessary. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/XGigUndiDxe/Hii.c | 8 ++++---- > IntelUndiPkg/XGigUndiDxe/Init.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/IntelUndiPkg/XGigUndiDxe/Hii.c > b/IntelUndiPkg/XGigUndiDxe/Hii.c > index 857a475622f7..3ad7d61e493d 100644 > --- a/IntelUndiPkg/XGigUndiDxe/Hii.c > +++ b/IntelUndiPkg/XGigUndiDxe/Hii.c > @@ -459,7 +459,7 @@ HiiOpenProtocol ( > Status = gBS->LocateProtocol ( > &gEfiHiiDatabaseProtocolGuid, > NULL, > - &UndiPrivateData->HiiDatabase > + (VOID **)&UndiPrivateData->HiiDatabase > ); > if (EFI_ERROR (Status)) { > DEBUGPRINT (CRITICAL, ("Error finding HII protocol: %r\n", > Status)); > @@ -472,7 +472,7 @@ HiiOpenProtocol ( > Status = gBS->LocateProtocol ( > &gEfiHiiStringProtocolGuid, > NULL, > - &UndiPrivateData->HiiString > + (VOID **)&UndiPrivateData->HiiString > ); > if (EFI_ERROR (Status)) { > DEBUGPRINT (CRITICAL, ("Error finding HII String protocol: > %r\n", Status)); > @@ -485,7 +485,7 @@ HiiOpenProtocol ( > Status = gBS->LocateProtocol ( > &gEfiFormBrowser2ProtocolGuid, > NULL, > - &UndiPrivateData->FormBrowser2 > + (VOID **)&UndiPrivateData->FormBrowser2 > ); > if (EFI_ERROR (Status)) { > DEBUGPRINT (CRITICAL, ("Error finding HII form browser protocol: > %r\n", Status)); > @@ -498,7 +498,7 @@ HiiOpenProtocol ( > Status = gBS->LocateProtocol ( > &gEfiHiiConfigRoutingProtocolGuid, > NULL, > - &UndiPrivateData->HiiConfigRouting > + (VOID **)&UndiPrivateData->HiiConfigRouting > ); > if (EFI_ERROR (Status)) { > DEBUGPRINT (CRITICAL, ("Error finding HII ConfigRouting > protocol: %r\n", Status)); > diff --git a/IntelUndiPkg/XGigUndiDxe/Init.c > b/IntelUndiPkg/XGigUndiDxe/Init.c > index bffe3c165866..84e06ea071c5 100644 > --- a/IntelUndiPkg/XGigUndiDxe/Init.c > +++ b/IntelUndiPkg/XGigUndiDxe/Init.c > @@ -179,7 +179,7 @@ InitAppendMac2DevPath ( > Status = gBS->AllocatePool ( > EfiBootServicesData, // EfiRuntimeServicesData, > TotalPathLen, > - &DevicePtr > + (VOID **)&DevicePtr > ); > > if (Status != EFI_SUCCESS) {