From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B2374D801DE for ; Wed, 18 Oct 2023 11:16:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=reUvHPPqyzxUSx9T8U05/WqHbPc+ThaMylIvJljwHsk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697627785; v=1; b=UfoAW0Gji8CEM59mXPO3lTcM17PqcJDAMAyQDql1sOsdoN90k+xzQMuV+mGPNGBgOlhRN9Q4 ebLvZHbNLqVhiTEcsZWaH2AMtx3U1MbCKlnHkSmVRnAvjfaLZmYQfF41HPjx/DDVTCCRj6HPOa/ KwcgWx5KsX0cgu9cYWiyJE+g= X-Received: by 127.0.0.2 with SMTP id kjLRYY7687511x0i1Uzhh1c8; Wed, 18 Oct 2023 04:16:25 -0700 X-Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by mx.groups.io with SMTP id smtpd.web11.278683.1697627784104888437 for ; Wed, 18 Oct 2023 04:16:24 -0700 X-Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-53d8320f0easo11379254a12.3 for ; Wed, 18 Oct 2023 04:16:23 -0700 (PDT) X-Gm-Message-State: za30mACwzofqT03dwWpwgu2Hx7686176AA= X-Google-Smtp-Source: AGHT+IFQQ4vWTp1XaxSm9d0efRKGvIUTjovY9NTMNCC4VzFd93qXjrRVsn38mTrq2C0tT3+cb+hG1g== X-Received: by 2002:a50:9fad:0:b0:53f:25c4:357f with SMTP id c42-20020a509fad000000b0053f25c4357fmr2664476edf.34.1697627782428; Wed, 18 Oct 2023 04:16:22 -0700 (PDT) X-Received: from [192.168.200.206] (83.11.27.172.ipv4.supernova.orange.pl. [83.11.27.172]) by smtp.gmail.com with ESMTPSA id p33-20020a056402502100b0053498aa4f41sm2642363eda.48.2023.10.18.04.16.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Oct 2023 04:16:22 -0700 (PDT) Message-ID: <2d881cf4-d12b-4ddb-8a5c-deb5f070c1cc@linaro.org> Date: Wed, 18 Oct 2023 13:16:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present To: Nhi Pham , devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Jeremy Linton , Chuong Tran , Rebecca Cran References: <20231018-ehci-xhci-fix-v4-0-aa53138997a5@linaro.org> <20231018-ehci-xhci-fix-v4-4-aa53138997a5@linaro.org> <75b23ede-8f50-4d44-a786-fb04cd4abd00@os.amperecomputing.com> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: <75b23ede-8f50-4d44-a786-fb04cd4abd00@os.amperecomputing.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=UfoAW0Gj; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none) W dniu 18.10.2023 o 12:32, Nhi Pham pisze: > Acked-by: Nhi Pham > > Nit: I think you want to run uncrustify for Patch 3 as well :) Done, will check other changes too. I have a strong feeling that Qemu part of EDK2 needs a bit bigger patch when it comes to formatting: Platform/Qemu/QemuOpenBoardPkg/Include/Library/QemuOpenFwCfgLib.h | 7 +- Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c | 33 +- Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSecLib/Ia32/SecEntry.nasm | 99 ++- Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c | 108 +-- Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c | 30 +- Platform/Qemu/QemuOpenBoardPkg/README.md | 43 +- Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 78 +- Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc | 31 +- Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 808 +++++++++++--------- Silicon/Qemu/SbsaQemu/AcpiTables/Fadt.aslc | 14 +- Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc | 15 +- Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc | 37 +- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 48 +- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuSmbiosDxe/SbsaQemuSmbiosDxe.c | 112 ++- Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 86 +-- Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuPlatformVersion.h | 50 +- Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuSmc.h | 4 +- Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h | 2 +- Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c | 37 +- Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | 23 +- Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuMem.c | 57 +- Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib.c | 14 +- Silicon/Qemu/SbsaQemu/Library/SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c | 76 +- 23 files changed, 982 insertions(+), 830 deletions(-) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109728): https://edk2.groups.io/g/devel/message/109728 Mute This Topic: https://groups.io/mt/102035954/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-