From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A05F6AC1153 for ; Wed, 14 Aug 2024 13:53:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KDuW1xAu6uiPhxzS+mcpacwe9cc01YwKDWHwTztBLl4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1723643600; v=1; b=asWYsgsg+dNfPDqKqt151Z89T1UuRc58sj7KburFKRDQ6P6YUeNSmDVuvDee5Y7/A6ZlnpnK 6fomIlJxpN+YIK3R9nDEyzyAGZH3VPlTipqthcsJ8sYhiOYTZnSfAiHUO3yqyvdZvdm3ksxtoSS H93pNzXHpL3EZpeZhCbXLFY+E7FqCLqBXCmt6J5mHn87psfNA+MYaAp5XWY3z8D3dJGlmkUmeGM EoGzVegOxhP+6+jpIDKQpQRZ+ThcQtP14Ao5pninUI2qpSPENPoCz0ezcBt3f5hdeba/z/4irun hGg3piRLa1wD5WTjXeEotBoLxvvH6Pet4SQh4TPPh5jrA== X-Received: by 127.0.0.2 with SMTP id QpilYY7687511x61gbrWRFlo; Wed, 14 Aug 2024 06:53:19 -0700 X-Received: from CH1PR05CU001.outbound.protection.outlook.com (CH1PR05CU001.outbound.protection.outlook.com [52.101.193.82]) by mx.groups.io with SMTP id smtpd.web10.98448.1723643598186293014 for ; Wed, 14 Aug 2024 06:53:18 -0700 X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by PH0PR01MB6503.prod.exchangelabs.com (2603:10b6:510:12::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22; Wed, 14 Aug 2024 13:53:12 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::74dd:8ddd:b9c2:8d2d]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::74dd:8ddd:b9c2:8d2d%3]) with mapi id 15.20.7849.021; Wed, 14 Aug 2024 13:53:12 +0000 Message-ID: <2dbe2059-0b8d-4729-807a-0b1a141df618@os.amperecomputing.com> Date: Wed, 14 Aug 2024 07:53:08 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table To: devel@edk2.groups.io, nhi@os.amperecomputing.com Cc: quic_llindhol@quicinc.com, chuong@os.amperecomputing.com, rebecca@os.amperecomputing.com References: <20240814033333.2360719-1-nhi@os.amperecomputing.com> From: "Rebecca Cran via groups.io" In-Reply-To: <20240814033333.2360719-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SJ0PR03CA0369.namprd03.prod.outlook.com (2603:10b6:a03:3a1::14) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|PH0PR01MB6503:EE_ X-MS-Office365-Filtering-Correlation-Id: cb7ed6b7-a1bb-4e49-a248-08dcbc686fed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?QTN2czVtNW5USDUrc2ZwWGJvQURKUmZjQjdrZ2FaNkRQek1aVTd4a280dFpn?= =?utf-8?B?M09wZFJYbUxLNG1pL2NwQnlIMGRyTUk2cnlxYmsvZVNYMjFEZThVTlZGUWg4?= =?utf-8?B?dytJdzRITzdmaFJYZTcyd1JSMDBZV2p1cU4vdmVob2Iwb1ZWSGEvbHpCWnE1?= =?utf-8?B?bnA2ZGZ1dHpaVHRYT3Z1dGp1aWFEa1dqL2psOHlNYUhQN2xObUF1alM4YVl1?= =?utf-8?B?bUdzcG92VVFWb0d3aSs3a0h2TWFsZ1ViMzJOMEFDZzhiV0M4YVB1RmtoY3ZK?= =?utf-8?B?VGhzblNnSlppMW1OVVJNdkR3S1IzYmdzUS9VamlaQlhxd3pwQzRSa0dpOXd4?= =?utf-8?B?d3NyTUNSSTBsd3JVS0t0OGZXZ3l1emtPSDZnWUNFa0M4emlDekJmUER3ZlRW?= =?utf-8?B?NWlJNVg1VzYxTDhTK2dObTJGWEJlN0dPZko5dzhOV2lVQUxESnJoZWxvWkNr?= =?utf-8?B?dVBaYjFOcWR0YUVUbndSWlJVeWxrMWd3Z1pVekw4TStOL1VpZVUvUzB3YVhk?= =?utf-8?B?U3N5Tjg5aS9HZ3Vrd25HN0VlaVBKUGVtRFNwMktoNjh0dWpIcXNjT2s2WVpP?= =?utf-8?B?VjRMMmNoMEZ0MDNtYVdrbnFoM05YRE1ib0JOeWE1WjVuektyMElkVzBZQkRI?= =?utf-8?B?ZDk0T1J1S3NtT3pTUUZaTXdZQllpaW4wUldHOUFRSEJEWnBYdUxHcEwrb1V0?= =?utf-8?B?dWVKYnlxem02MU9QbFhiajE5NVJDckttNkhWVnZrQlN4K2ZmVzFHZ0NiQWpJ?= =?utf-8?B?Zlg4T1d5REJobGE2Q2RrZnBkWVhzRVorNXE3dEZwM251cUZDd0FuUXVNaitV?= =?utf-8?B?QnZadnJUN2tVejNzV2lTZzhKdVdsbHU4QnFpdEJhSXdhVnc4MDdlMDNlNzRU?= =?utf-8?B?WE03WndVdElURTloTmRmNHNUbHpITGlTaTJDckpqT0ROb3FKZ2tGbnZUd0Y1?= =?utf-8?B?Zk1ZSzhOdVY2ZGRaQ0VOS1pxOGdQOWErT0V1SVRFT0FJYkgrTUw3UWF5M0NW?= =?utf-8?B?aVl3a3Q0M2tsSFpRbmFJNXNiVFVieXF5R2dya3lIclpPWEVkM243VkVrOEM3?= =?utf-8?B?TXdxSCsvVkQ2UC94WTR0SHVlMWp3YWsxdVFsLzJpbHJGeHl3OFlDalFqMncx?= =?utf-8?B?L3BDRk1pVEZmMWdHSXg4QnVEb3RaOUFFOUE4WlZaWnNhWFN6ZXNWT1F2QTVy?= =?utf-8?B?S1YxWmdVVnQ3VVZPV2FjVmxEU3FNT2dUSmV4bzZoN0N3WkQ5Znc0Nm5YUkNo?= =?utf-8?B?NnBZTUttWThRclNJNmloWnJPd3c0K2UyelZZVDZhTFQ3b0lJRC9CMGZqOUVt?= =?utf-8?B?dTA3SlVZNHFvb3Z2N2xwQ1k3cmJTUUoxVTJieFpqZmo2QitYYkx0Y0tZRHB4?= =?utf-8?B?Tk41TmZSYXRiY3dVVFNVNkV5M2VrQ3N4Q21tY3EvUmthUzd4RVQyeit3WDdr?= =?utf-8?B?TVJvZEVnSjFrcDlxT3BFUnFseisvdzdkajQ1N1d4eEMwQ3lnSEdlcGVpc3Zt?= =?utf-8?B?YW0xRURtcmJGVHM3ZWplS0JFTWlLUU1raTFiZHMrSW00cFlWdEFoaitMRGFC?= =?utf-8?B?dzJZMUViQm1BbWhEM1pvb2FlbHJXbmRwMDEvOERLSmc1ekF4U2ltWkpOc3pL?= =?utf-8?B?a0VocDJmMG1yd0NoUVptUm0wVzJUSjNDcC91Slp6NXlzVE9oNnhjVDdkRXN4?= =?utf-8?B?NlZMNnJ5TWluVm9GQnF5eGxZUi9XbnQvbEc1RlVqYmZKMWV2c0xvS2w3Y1Js?= =?utf-8?B?UElzSjRzL21nYk9vNk41TUkzVnJRbGtNTEZ2RnpkNjZFejZRVGg2RUtDampN?= =?utf-8?B?SUhuUk1LRjhEZHVIM0c1UT09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHpPVkxqcWFWSDAvU2J6ME8rT0wrWDhkQ0J2MVJhRDF1bmRYcWUzbTQ3ZkJm?= =?utf-8?B?NnYzcStWRWJJYThEWFZaK2UrbWxsRldUYldEU24zWUxqeXJLRHJDdEFVNFFV?= =?utf-8?B?U0REWkMwR1Z5aFNDTUVRbGlQdzNxcTgveERXWVk2OTBJMTkvRXJuMHk5RnJ6?= =?utf-8?B?NlozTWplZi8vblZVMGl6YjlzRFhBdnJIeTBVVzE4TGExdVFtTStYNGE4K1dR?= =?utf-8?B?d2xGMTRFdGcyWDBTR2gxckgrc0dXNjgvVEw3N3VJb1VVRmRhQkdOUFUyRW1N?= =?utf-8?B?emJESDA1OHdJRzdsYkZMVDh3VlVMTVB1NDJVVmpZaUgzVkFDNUJVYzl6L0pa?= =?utf-8?B?R1hxcVpBdlZjbFlNTWJpdmNBTW01TFI2MmpZSVZJLy9zYVo5ajNjU2pzaENX?= =?utf-8?B?QU5rQkthWURpOGhrVWFQOGM3QXJlYm10YVNtY2VkUU5taVNaVkxWR0lzUXhI?= =?utf-8?B?bUh2dTV5emp4TkRobEZZbGYreE9MVkVkcXFMdjRDYXhMczB2WUphWGRkakp4?= =?utf-8?B?QmNMVGFDeGkwd0o3Y2ZiU1UzT0kzbXpqVTdTMzBDZmxiQmNiajdlZ0prbWRl?= =?utf-8?B?N3RteGZ4YkdLaTVxblNLcnFpM29WUFEyWG9DOGFhSkZCREh6bG1EcW4ra1Rv?= =?utf-8?B?TkdscU8xVmVSNEVCVDNVbUx0VExCWFZqZUdLaGVXTUxnQ2lnYWNtU3BjOUhO?= =?utf-8?B?VG42d0plME1keXhBOUU3eHI0dUVTMnpUT1BQTEtpMnFLK1YwTkkxNWRJUVd6?= =?utf-8?B?ak1NcUs5YkFDTU56SkZyQmNCMHQzelR3ckhUQ1dYakl3SkZib3llcmpZZThk?= =?utf-8?B?M1Q1ajl4RVRUSENWWlQ2QmpaYVUwOW1MRW9SNldHV2FQbnNLVVF0WE5Pa0dY?= =?utf-8?B?QWdCSkRiS1ZGYTJqU2RuNzZqL0JpNWM0WW5TT1VnSWdIblZpT1NtZGJCU21j?= =?utf-8?B?S0dUSFNMaFNkdzc2anM2UytESXpYWnVWTGt3dnJ2aWhob1ZhYTlZM001cW8y?= =?utf-8?B?eVczWmw5NlF5aThaMWZXWUNOZy9PZm5VaFIzcDg1am9lZDhmcWUrL255eHV3?= =?utf-8?B?MzN1dU4zK3JFS2Nudk9xNXN6STRpQ0pjWHdQQmlsYTRlZWJ3c0orS2xGSUN2?= =?utf-8?B?MHQxYVhFYzM1OCtkTGtZbjVZb28zSlczaFdXT2g3RmhNWXJQcU5CSk5aZjRi?= =?utf-8?B?RGl0VWhlckJsTlZjV3JFMEE1SlJCWXFzNElNaWJudkxHcWlyTmk3aXdsVnYw?= =?utf-8?B?QXJ3cW5kTHBpU1haWlVUQkhsR3ZHMENRRFUrc1V4MnUvRHJxRU5OcnJ4WitT?= =?utf-8?B?OEpuUVBPdmNGd3pjbkc5aEZrWlV1U2wwQTZRanZNRkd2NVR0QXJXdHVKUjJt?= =?utf-8?B?cm42VWltZ1NmcmJyblFrM25tbHZ4Z1g0OC9JTnNrWU9tYU5VOS9udjlPSlFI?= =?utf-8?B?WVlTMmZKd0M3bFhJMlo5L0tXamY5bEtWY1RWSy9kZlRjc0RxTytSTGpYZjVR?= =?utf-8?B?UisrcUt6cSt1dkN0dzJjdDBCWnVvdjdjWncvN2NhVzVHdHpBcFFhRDJYdU9l?= =?utf-8?B?NXBCKzhjblFFUG1xcmdtVisvczdMUnl3bjlOd2FzK0wyWXg1WDRNejlHb2wr?= =?utf-8?B?L1MrL211eThlVWFrV0c3SDRqT3hIb0lsdEJMUXFrRVpGalJ0NUgvVk1BWVFp?= =?utf-8?B?RzY2R1A1ZzdkRU4yRGoxZDcxNHV4MWIycVFFNnZldmZweS94d094WXJOZnhQ?= =?utf-8?B?UGJTQlJiQ09ybkxEQXUrQVJWMTBaTm4vTUx5QjJtczdRU0M2SmplT3JuU3Fk?= =?utf-8?B?M3EzaU80ZDVrSWswekpKNE02Z1lhUzUyNVQzWUhpcGcreHd3dEtKZjRjemc1?= =?utf-8?B?QWhPZm1aV0VMY3dGcFNOZjBNTDBNR3MxRmtiS2NoWVQvWE9NaEc3YlYyWmNI?= =?utf-8?B?R09EeTQyUGdxKzdBQ20zeWhCTDdpdzJzREF6S255UWtBMlNQbXZ1YWdyaDVJ?= =?utf-8?B?cmVKOUtsVFZidEFsb05uNWJIelhXNFdVZlNOSFhKcXNXRzhaTVF5OTdsa0hk?= =?utf-8?B?Z2ZOMWFjbEpoeFoxOWRKMi9qVCt2WmpCWnRxQ1ZETnNZYmdCUWVDdEVvWWpz?= =?utf-8?B?U1JRa0ZEODlwMFl6dFFsa2lFK1dOYWFaSzluZ0VZOW9VcEdpVGlYaHA4bkVa?= =?utf-8?Q?OI/Iw6VSNgSHy1xJMT4p2I4=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb7ed6b7-a1bb-4e49-a248-08dcbc686fed X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2024 13:53:12.2175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LC4iaHlHtIc/k8aIFv56pnXKzmB0TrSB2Bs+WrYZrlb5ig0uFf83pDWO/QFxq/PfQaKGOAw8uAwmeCpx5ob7DfNc+NTWKXnaws9arvs++bPH5M4WBVgFB/sLF26sU9J2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6503 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 14 Aug 2024 06:53:18 -0700 Resent-From: rebecca@os.amperecomputing.com Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4HR2qLsMjJlM64dpmu8VBJKix7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=asWYsgsg; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 8/13/2024 9:33 PM, Nhi Pham via groups.io wrote: This could be a static function. > +EFI_STATUS > +EFIAPI > +AcpiInstallSpmiTable ( > + VOID > + ); > + > #endif /* ACPI_PLATFORM_H_ */ > diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatform= Dxe.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c > index 28c422dff166..a82a93d23fa2 100644 > --- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c > +++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c I believe the project now prefers the use of the C keyword "static". > + // BCD Format > + SpmiTable->SpecificationRevision =3D DeviceId.SpecificationVersion = & 0xF0; > + SpmiTable->SpecificationRevision |=3D (DeviceId.SpecificationVersion= & 0x0F) << 8; It took a second to understand this. Maybe combine it into a single=20 line, or change the '0x0F' to just '0xF'? -- Rebecca -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120338): https://edk2.groups.io/g/devel/message/120338 Mute This Topic: https://groups.io/mt/107889268/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-