public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"newexplorerj@gmail.com" <newexplorerj@gmail.com>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Zhang, Shenglei" <shenglei.zhang@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2.
Date: Fri, 14 Feb 2020 01:17:54 +0000	[thread overview]
Message-ID: <2dc47a3964d340bf8d293678f73d125a@intel.com> (raw)
In-Reply-To: <8e8ee3c965fbc9ee79fc00244d1e81ff53c491ad.1581494371.git.newexplorerj@gmail.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of GuoMinJ
> Sent: Thursday, February 13, 2020 4:34 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>
> Subject: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2515
> 
> Change the MdeModulePkg to match the ECC check rule
> 
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 4 ++--
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c      | 2 +-
>  MdeModulePkg/MdeModulePkg.uni                         | 4 ++++
>  3 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> index f8020f4e72..6c68a97d4e 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> @@ -2071,7 +2071,7 @@ InitializeP2C (
>    PciIo->Pci.Write (PciIo, EfiPciIoWidthUint8, 0x3C, 1, &gAllZero);
>  }
> 
> -/*
> +/**
>    Authenticate the PCI device by using DeviceSecurityProtocol.
> 
>    @param PciIoDevice  PCI device.
> @@ -2079,7 +2079,7 @@ InitializeP2C (
>    @retval EFI_SUCCESS     The device passes the authentication.
>    @return not EFI_SUCCESS The device failes the authentication or
>                            unexpected error happen during authentication.
> -*/
> +**/
>  EFI_STATUS
>  AuthenticatePciDevice (
>    IN PCI_IO_DEVICE            *PciIoDevice
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> index b05c818462..da5559ae76 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> @@ -2200,7 +2200,7 @@ SdMmcSoftwareReset (
>    SD specification section 3.10.
> 
>    @param[in] Private    Pointer to driver private data.
> -  @param[in] Trb        Pointer to currently executing TRB.
> +  @param[in] Slot       Index of the slot for device.
>    @param[in] IntStatus  Normal interrupt status mask.
> 
>    @retval EFI_CRC_ERROR  CRC error happened during CMD execution.
> diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
> index cc18e53322..2c856ed073 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1314,3 +1314,7 @@
>                                                                                      "when the PCD is TRUE but CPU doesn't support 5-Level Paging."
>                                                                                      " TRUE  - 5-Level Paging will be enabled."
>                                                                                      " FALSE - 5-Level Paging will not be enabled."
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_PROMPT #language en-US "TCG Platform Firmware
> Profile revision"
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_HELP #language en-US "Indicates which TCG
> Platform Firmware Profile revision the EDKII firmware follows."
> --
> 2.17.1
> 
> 
> 


  reply	other threads:[~2020-02-14  1:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  8:33 [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2 newexplorerj
2020-02-13  8:33 ` [PATCH 2/3] MdeModulePkg: " GuoMinJ
2020-02-14  1:17   ` Liming Gao [this message]
2020-02-14  6:36   ` [edk2-devel] " Wu, Hao A
2020-02-13  8:33 ` [PATCH 3/3] SecurityPkg: " GuoMinJ
2020-02-13 10:23   ` [edk2-devel] " Yao, Jiewen
2020-02-13  9:18 ` [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: " Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dc47a3964d340bf8d293678f73d125a@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox