From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, maciej.rabeda@linux.intel.com
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
Seven.ding@lcfuturecenter.com
Subject: Re: [edk2-devel] [PATCH v1] NetworkPkg/UefiPxeBcDxe: Fix PXE_BOOT_SERVERS usage in boot info parse flow
Date: Wed, 19 Aug 2020 20:13:18 +0200 [thread overview]
Message-ID: <2dde2087-e291-0232-62e2-a30cdf4e09b2@redhat.com> (raw)
In-Reply-To: <20200819165338.681-1-maciej.rabeda@linux.intel.com>
On 08/19/20 18:53, Maciej Rabeda wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2876
>
> According to PXE 2.1 spec, DHCP option 43, tag 6 (PXE_DISCOVERY_CONTROL),
> bit 3 specifies whether PXE client should use/accept TFTP servers defined
> within PXE_BOOT_SERVERS list (tag 8). This bit was not being taken into
> account when choosing boot server IP in PxeBcDhcp4BootInfo().
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> ---
> NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c b/NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c
> index d062a526077b..ed9bca0f7de3 100644
> --- a/NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c
> +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c
> @@ -499,12 +499,16 @@ PxeBcDhcp4BootInfo (
>
> //
> // Parse the boot server address.
> - // If prompt/discover is disabled, get the first boot server from the boot servers list.
> - // Otherwise, parse the boot server Ipv4 address from next server address field in DHCP header.
> + // If prompt/discover is disabled, server list should be used and is present (DHCP option 43),
> + // get the first boot server from the boot servers list.
> + // Otherwise, parse the boot server IPv4 address from next server address field in DHCP header.
> // If all these fields are not available, use option 54 instead.
> //
> VendorOpt = &Cache4->VendorOpt;
> - if (IS_DISABLE_PROMPT_MENU (VendorOpt->DiscoverCtrl) && IS_VALID_BOOT_SERVERS (VendorOpt->BitMap)) {
> + if (IS_DISABLE_PROMPT_MENU (VendorOpt->DiscoverCtrl) &&
> + IS_VALID_BOOT_SERVERS (VendorOpt->BitMap) &&
> + IS_ENABLE_USE_SERVER_LIST (VendorOpt->DiscoverCtrl))
> + {
> Entry = VendorOpt->BootSvr;
> if (VendorOpt->BootSvrLen >= sizeof (PXEBC_BOOT_SVR_ENTRY) && Entry->IpCnt > 0) {
> CopyMem (
>
I'm still undecided whether option#43 / tag#6 / bit#3 being clear means
we should *ignore* PXE_BOOT_SERVERS (tag#8), but I'm willing to defer to
you on that. So, I can give a cautious
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
for this patch.
Regarding the feature freeze -- in theory, this is a bugfix. However,
before we merge it, it would be really nice to get feedback from the
original reporter (CC'd).
I also intend to regression-test this patch, I'll report back.
Thanks,
Laszlo
next prev parent reply other threads:[~2020-08-19 18:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 16:53 [PATCH v1] NetworkPkg/UefiPxeBcDxe: Fix PXE_BOOT_SERVERS usage in boot info parse flow Maciej Rabeda
2020-08-19 18:13 ` Laszlo Ersek [this message]
2020-08-19 18:46 ` [edk2-devel] " Michael Brown
2020-08-21 11:19 ` Laszlo Ersek
2020-08-23 16:24 ` Michael Brown
2020-08-19 19:20 ` Laszlo Ersek
2020-08-20 10:44 ` Maciej Rabeda
2020-08-20 13:41 ` Michael Brown
2020-08-21 9:11 ` Laszlo Ersek
2020-08-21 10:57 ` 回复: " Ding, Seven
2020-08-21 11:15 ` Maciej Rabeda
2020-08-20 3:35 ` Siyuan, Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dde2087-e291-0232-62e2-a30cdf4e09b2@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox