From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.12008.1598356560818262673 for ; Tue, 25 Aug 2020 04:56:00 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 192.55.52.115, mailfrom: maciej.rabeda@linux.intel.com) IronPort-SDR: U7NsJn3VwBMPR4e5S2znWtRpa1lZJl17CqB7nt8XeUNcYA4Lvw6VGBHeuHGOCPPFHvIhC/NhXU u1aerhTyPo2A== X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="155349580" X-IronPort-AV: E=Sophos;i="5.76,352,1592895600"; d="scan'208";a="155349580" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 04:55:59 -0700 IronPort-SDR: IyAmB4N5MD3k8jSYmbO6fao8uKtmM3Mxbb3kJoILpUPyPOv4xdlSsYO8wcjcvbT8dXOK8biOOu ZJVrs0kX36AQ== X-IronPort-AV: E=Sophos;i="5.76,352,1592895600"; d="scan'208";a="294974745" Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.213.7.240]) ([10.213.7.240]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 04:55:57 -0700 Subject: Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Vladimir Olovyannikov , Laszlo Ersek , devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , Zhichao Gao , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd References: <20200821160555.21436-1-vladimir.olovyannikov@broadcom.com> <20200821160555.21436-2-vladimir.olovyannikov@broadcom.com> <4c300ea0874f19d4138084a4c4bed9a2@mail.gmail.com> From: "Maciej Rabeda" Message-ID: <2de1f4e9-af3a-b788-9645-5c2970e4b92c@linux.intel.com> Date: Tue, 25 Aug 2020 13:55:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <4c300ea0874f19d4138084a4c4bed9a2@mail.gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: pl Hi Vladimir, Since you are already resending, could you address very minor coding standard items? HttpDynamicCommand.c Line 60: space after func name call Http.c Line 519: indent Line 586: ); alignment Line 879: space between SetTimer and ( Line 1579: ); to next line Upon removing openssl and addressing the items above, you can tie: Reviewed-by: Maciej Rabeda Thanks, Maciej On 25-Aug-20 06:16, Vladimir Olovyannikov wrote: > Hi Laszlo, > > Sorry, I should've checked. No, there was no intention at all to even touch > an OpenSSL lib. > I will re-send tomorrow morning. > > Thank you, > Vladimir > >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Monday, August 24, 2020 12:43 PM >> To: devel@edk2.groups.io; vladimir.olovyannikov@broadcom.com >> Cc: Samer El-Haj-Mahmoud ; Zhichao >> Gao ; Maciej Rabeda >> ; Jiaxin Wu ; Siyuan >> Fu ; Ray Ni ; Liming Gao >> ; Nd >> Subject: Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add >> HttpDynamicCommand >> >> Hi Vladimir, >> >> On 08/21/20 18:05, Vladimir Olovyannikov via groups.io wrote: >>> Introduce an http client utilizing EDK2 HTTP protocol, to allow fast >>> image downloading from http/https servers. >>> HTTP download speed is usually faster than tftp. >>> The client is based on the same approach as tftp dynamic command, and >>> uses the same UEFI Shell command line parameters. This makes it easy >>> integrating http into existing UEFI Shell scripts. >>> Note that to enable HTTP download, feature Pcd >>> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to >>> TRUE. >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 >>> >>> Signed-off-by: Vladimir Olovyannikov >>> >>> Cc: Samer El-Haj-Mahmoud >>> Cc: Laszlo Ersek >>> Cc: Zhichao Gao >>> Cc: Maciej Rabeda >>> Cc: Jiaxin Wu >>> Cc: Siyuan Fu >>> Cc: Ray Ni >>> Cc: Liming Gao >>> Cc: Nd >>> --- >>> ShellPkg/ShellPkg.dec | 1 + >>> ShellPkg/ShellPkg.dsc | 5 + >>> .../HttpDynamicCommand/HttpApp.inf | 58 + >>> .../HttpDynamicCommand/HttpDynamicCommand.inf | 63 + >>> .../DynamicCommand/HttpDynamicCommand/Http.h | 88 + >>> ShellPkg/Include/Guid/ShellLibHiiGuid.h | 5 + >>> .../DynamicCommand/HttpDynamicCommand/Http.c | 1693 >> +++++++++++++++++ >>> .../HttpDynamicCommand/HttpApp.c | 61 + >>> .../HttpDynamicCommand/HttpDynamicCommand.c | 137 ++ >>> CryptoPkg/Library/OpensslLib/openssl | 2 +- >>> .../HttpDynamicCommand/Http.uni | 116 ++ >>> 11 files changed, 2228 insertions(+), 1 deletion(-) create mode >>> 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.inf >>> create mode 100644 >>> >> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand >> .inf >>> create mode 100644 >> ShellPkg/DynamicCommand/HttpDynamicCommand/Http.h >>> create mode 100644 >> ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c >>> create mode 100644 >>> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.c >>> create mode 100644 >>> >> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand >> .c >>> create mode 100644 >>> ShellPkg/DynamicCommand/HttpDynamicCommand/Http.uni >> [...] >> >>> diff --git a/CryptoPkg/Library/OpensslLib/openssl >>> b/CryptoPkg/Library/OpensslLib/openssl >>> index e2e09d9fba11..c3656cc594da 160000 >>> --- a/CryptoPkg/Library/OpensslLib/openssl >>> +++ b/CryptoPkg/Library/OpensslLib/openssl >>> @@ -1 +1 @@ >>> -Subproject commit e2e09d9fba1187f8d6aafaa34d4172f56f1ffb72 >>> +Subproject commit c3656cc594daac8167721dde7220f0e59ae146fc >> your patch includes a hunk that moves our openssl submodule from 1.1.1g >> back to ~1.1.1d. >> >> I think that must be unintentional; can you please drop this hunk and post >> v7? >> >> Thanks >> Laszlo