From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 29754780091 for ; Thu, 29 Feb 2024 07:48:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1UeKO1QeaH+zYr8m1xGigtmCf+xyugg2vEF1TRfT6is=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709192899; v=1; b=OoeAkRix4ld9omKhbvr6Tjw0t1TlUAD0ssWABVvsPqM9/Zl/cGXajZTLDA/wFey+zxjpFrIe ev+/fdFnx0xET4mdvZ4zrbNQakoU+nCFGS1MAtgQhMoUPywlEVnHV9G6wKLg7rDW2C6eLrK1qpc BB1nUF0R0bh2oJpNCchhcUxs= X-Received: by 127.0.0.2 with SMTP id kB5zYY7687511x8DvtnAqqtw; Wed, 28 Feb 2024 23:48:19 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.19262.1709192899350862076 for ; Wed, 28 Feb 2024 23:48:19 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-Wuu3v9V4N76IY8fswR2PYw-1; Thu, 29 Feb 2024 02:48:16 -0500 X-MC-Unique: Wuu3v9V4N76IY8fswR2PYw-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6EA5185A599; Thu, 29 Feb 2024 07:48:16 +0000 (UTC) X-Received: from [10.39.192.138] (unknown [10.39.192.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0982A2166B33; Thu, 29 Feb 2024 07:48:15 +0000 (UTC) Message-ID: <2de71cc2-e14d-3277-88a8-44216f65e43b@redhat.com> Date: Thu, 29 Feb 2024 08:48:14 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE To: "Albecki, Mateusz" , devel@edk2.groups.io References: <03bbfff1-b6de-3468-9f66-f8d513a1c9e2@redhat.com> <23930.1709137632981481539@groups.io> From: "Laszlo Ersek" In-Reply-To: <23930.1709137632981481539@groups.io> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Hc8K4wNGiMPHnDdlZKwavZrex7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OoeAkRix; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/28/24 17:27, Albecki, Mateusz wrote: > Sorry, I didn't want to make an impression that I expected solution to > be delivered, I was merely trying to explain some of the complexity we > are trying to handle on our side and why we didn't went for SerialDxe > and instead opted to make PciSioSerialDxe work for our use case. Anyway > thanks for the ideas, we will definitely look into implementing step h > you mentioned in case other maintainers also disagree with this patch. ... BTW IIRC Mike recommended producing SerialIo protocol instances in your platform driver, rather than PciIo, for your debug ports. I feel a bit torn about that; on one hand, the uniformity of SerialIo protocols looks flexible, on the other hand, how would you distinguish the debug ports from the "normal" serial ports (mixing debug output with UEFI console IO is not great; speaking from experience). Then you'd need to get into DevicePath parsing (or call PciIo->GetLocation), and/or make sure your ConIn/ConOut/StdErr variables wouldn't include the debug ports... It's hard to form an opinion not knowing the platform and the goals specifically. But, anyway, I've kind of run out of steam on this. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116137): https://edk2.groups.io/g/devel/message/116137 Mute This Topic: https://groups.io/mt/104469297/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-