From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4676C740034 for ; Wed, 31 Jan 2024 18:30:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1abfamq63grhPqPR/kSxNxS/4NDSvY5YzuBTuoCg3FE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:Autocrypt:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706725842; v=1; b=sTUY2d02y6/AHm6v70aKdK4gAc9nrms2MwHrFL5qvf+Oo3pBVmG769dVMozfCuJfy7f1A81q VBHf9lLSI2G1VBQwWEvtAwbrF1R5be9RKikTcwBUorPqqa4DkW/j8aWy3JpJ/7TfFDqvoVA0TC9 J7+7s4vYXCcHOKcrHzTFirPk= X-Received: by 127.0.0.2 with SMTP id 4awQYY7687511xCAaR5MRcq7; Wed, 31 Jan 2024 10:30:42 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.48]) by mx.groups.io with SMTP id smtpd.web11.2765.1706725840981181163 for ; Wed, 31 Jan 2024 10:30:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZXJkmWDK9avZF9rm0lBI/nj2TY6ZKJH94ztKsMM2nS7gvwELrm9Kc6tzx2RO5b5D/PsU8V0hcCQfd8XxQEorOHl4U2zgUgplRhe/1nmL5EdcS20uOWF98sxR9stitBrtB+eyhCvyFFsbF7uJqExGm9nrfKFx9Cjz7bH5Z80mmVqwA6P0tJtReVmemykWObYf+/FP36rRKqFeuvFDwXc0tAi3yYg0pdvLfAfYrJ2MZpSw5g5X5a2PcZuDeFyFgnzraLnkyfHA4m7UDnlxq1kWXR1HMqB0K8d25JVxmHL7Bd7gfmn2wBsTtOvIzmqq/5uRFFQnYE8hvy/TqUi250xd3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+KltrbOCtBrO1gK8hd1bakyA41mdnbrx7bQBBEmdKzo=; b=eNL61vHFpXUdjnhV2I9g8UMERxkcakyWVnZs2kSjLuke6xF52LVYdLkcZKImAh4TWPahrn/5WoZbDdFV0pVlTcLLTj9kK3GCJHTxlrIDn8omnu1S++shDibV9rRA/fid8Bm1QrYbSbWVSH/n9pYrr/EzdXXIz5k6svIDK+P0rigHVW5Y8QFnw9AXLudCS0czySWhsp0ZkhKL1EUH/JJMU0ySa5+UTpHfXVthPbogXGkxXH36HBmXNOQmH3Xs73ol09xgazvTPUkOriwQkWi3pxUi+Ox4M10Cv/TrTSKgAvcKZ81NzhbFHRs8ED+XScSZLBRTZMqIztuvsZ8vgm4syQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) by CH2PR12MB4939.namprd12.prod.outlook.com (2603:10b6:610:61::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.34; Wed, 31 Jan 2024 18:30:38 +0000 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c]) by BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c%4]) with mapi id 15.20.7228.029; Wed, 31 Jan 2024 18:30:38 +0000 Message-ID: <2deccf7e-6ff9-4362-8bb8-5de2239cc653@amd.com> Date: Wed, 31 Jan 2024 12:30:35 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 03/16] MdePkg/BaseLib: Add a new VMGEXIT instruction invocation for SVSM To: Gerd Hoffmann Cc: devel@edk2.groups.io, Ard Biesheuvel , Erdem Aktas , Jiewen Yao , Laszlo Ersek , Liming Gao , Michael D Kinney , Min Xu , Zhiguang Liu , Rahul Kumar , Ray Ni , Michael Roth References: <38bd6d829d25b89d416fa0f40eb5cc4487a0290f.1706307195.git.thomas.lendacky@amd.com> <34a1d889-a5b3-4cb0-8e8f-cabed9d14f2f@amd.com> <6rdteovxthwvxqvr2aey2yqci7zzkle3qty423jm7ysejxvapf@2dk3dp4ftsmn> From: "Lendacky, Thomas via groups.io" Autocrypt: addr=thomas.lendacky@amd.com; keydata= xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmWDAegFCRKq1F8ACgkQ 3v+a5E8wTVOG3xAAlLuT7f6oj+Wud8dbYCeZhEX6OLfyXpZgvFoxDu62OLGxwVGX3j5SMk0w IXiJRjde3pW+Rf1QWi/rbHoaIjbjmSGXvwGw3Gikj/FWb02cqTIOxSdqf7fYJGVzl2dfsAuj aW1Aqt61VhuKEoHzIj8hAanlwg2PW+MpB2iQ9F8Z6UShjx1PZ1rVsDAZ6JdJiG1G/UBJGHmV kS1G70ZqrqhA/HZ+nHgDoUXNqtZEBc9cZA9OGNWGuP9ao9b+bkyBqnn5Nj+n4jizT0gNMwVQ h5ZYwW/T6MjA9cchOEWXxYlcsaBstW7H7RZCjz4vlH4HgGRRIpmgz29Ezg78ffBj2q+eBe01 7AuNwla7igb0mk2GdwbygunAH1lGA6CTPBlvt4JMBrtretK1a4guruUL9EiFV2xt6ls7/YXP 3/LJl9iPk8eP44RlNHudPS9sp7BiqdrzkrG1CCMBE67mf1QWaRFTUDPiIIhrazpmEtEjFLqP r0P7OC7mH/yWQHvBc1S8n+WoiPjM/HPKRQ4qGX1T2IKW6VJ/f+cccDTzjsrIXTUdW5OSKvCG 6p1EFFxSHqxTuk3CQ8TSzs0ShaSZnqO1LBU7bMMB1blHy9msrzx7QCLTw6zBfP+TpPANmfVJ mHJcT3FRPk+9MrnvCMYmlJ95/5EIuA1nlqezimrwCdc5Y5qGBbbOwU0EVo1liQEQAL7ybY01 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+ LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe /5rkTzBNUwUCZYMCBQUJEqrUfAAKCRDe/5rkTzBNU7pAD/9MUrEGaaiZkyPSs/5Ax6PNmolD h0+Q8Sl4Hwve42Kjky2GYXTjxW8vP9pxtk+OAN5wrbktZb3HE61TyyniPQ5V37jto8mgdslC zZsMMm2WIm9hvNEvTk/GW+hEvKmgUS5J6z+R5mXOeP/vX8IJNpiWsc7X1NlJghFq3A6Qas49 CT81ua7/EujW17odx5XPXyTfpPs+/dq/3eR3tJ06DNxnQfh7FdyveWWpxb/S2IhWRTI+eGVD ah54YVJcD6lUdyYB/D4Byu4HVrDtvVGUS1diRUOtDP2dBJybc7sZWaIXotfkUkZDzIM2m95K oczeBoBdOQtoHTJsFRqOfC9x4S+zd0hXklViBNQb97ZXoHtOyrGSiUCNXTHmG+4Rs7Oo0Dh1 UUlukWFxh5vFKSjr4uVuYk7mcx80rAheB9sz7zRWyBfTqCinTrgqG6HndNa0oTcqNI9mDjJr NdQdtvYxECabwtPaShqnRIE7HhQPu8Xr9adirnDw1Wruafmyxnn5W3rhJy06etmP0pzL6frN y46PmDPicLjX/srgemvLtHoeVRplL9ATAkmQ7yxXc6wBSwf1BYs9gAiwXbU1vMod0AXXRBym 0qhojoaSdRP5XTShfvOYdDozraaKx5Wx8X+oZvvjbbHhHGPL2seq97fp3nZ9h8TIQXRhO+aY vFkWitqCJg== In-Reply-To: <6rdteovxthwvxqvr2aey2yqci7zzkle3qty423jm7ysejxvapf@2dk3dp4ftsmn> X-ClientProxiedBy: DM6PR17CA0024.namprd17.prod.outlook.com (2603:10b6:5:1b3::37) To BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_|CH2PR12MB4939:EE_ X-MS-Office365-Filtering-Correlation-Id: 7271900b-bebc-4015-01a9-08dc228ab8dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: hGLYal7wtb2A/LeG0TYuRd8rJu7LLKGV0VGFcPGBWCGqckMVOIceVVA5XgeYWMIJexy+GlFI3GzvdlWVf8VkxpdDXSilm3g03luADE+l/+6OBU+Bc98frqfIqmqiWHlAs/eIYwVA+o0+GonmZk9NF9dDk6KQ+uDHmRVhyfGWZI/IuVAwapap4upY3gOyyTbLIgvIQJjn7iTn1CwbI7Fz+jkMCGT4wEvK1A1KbEYxAHv+KDcuhEqu6A6vNDcuuNuEQr+QKAuUC60hOIQCd245o1UBCmvjxfMcj+iMqbDrBfjExv6nKk3uyNA+bBk8v/IBoxg67tN5ArZazsyO+to7pRhPgtaMxlXaBp2ya3YA4iztB7G7FMcMajJQkrjpyn1B3Z6PJhMvIpbyTOQBBMB+QZH7hbq2+OJIgifszQpbBySrLwoFG5s2U6S7VF5RePW1bjnMdbQr3iMsbZov8IZViJpzHsprRz5LrbYQtF3gwuIgLKpRfWh9QiBC+wY6bpSFqiPew6cbatk8Z+eyW9JdCbSt/NDoMNTh5e/E3UyL4Ex+xQ2WBihCLkdCSZox+IO+HUekkeffYSL22AEdOkVQLkZPvOq7TTHisX7McaQskBXFrk34hyMiVLpfOEn7PHJXyQ1yUgUpmKAR9ycIb0L0CA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ellaajJvaEFIMi85aDFXZVlraUgreG4yUjBhclY1Ky9MU3dZR29WZmpBeG1G?= =?utf-8?B?RW5HY2huSWI2Ny9qWVFEaGhSdWIvZitrdStmSUtONnB4Zjl1ejZCQmJUTkhj?= =?utf-8?B?NzU5a2ZVTjhDVm9iYmg1cklBVmc5cElaa1RmbEZJUEpxdU9YK245c2lrSWRH?= =?utf-8?B?bCtZQUVTSlBLb241MmNoLzlTZnV1OVJjZVJyZUV4d0ZWQ1NuTWp4cWhOZFg0?= =?utf-8?B?a2MvaWp5QXFndldqUzBWUFhoSTBGL2Jac1lrN2drSHNLbTJOSmUrU2NEZWJk?= =?utf-8?B?QTZpNVFhRzlWN3lvM1lxZ3lHRVN6WUtaYktaeFpJc1ZkZVVjWjJZNVFJL2ZS?= =?utf-8?B?K1FVOFhOdlR6L2FvUml2d3dVUExvZlEwNFpMcGpZclhFdFd1eW1scGFxNUhx?= =?utf-8?B?UG5Xd1cvcEVZWjAraDB0ZkNIdzh0STV6TUpQTmsrbjRoRktLOHpPZ010Tzhi?= =?utf-8?B?SzhBdkhaMkN3cVpGR29VcmVHbmhIeXRRc0ZFY3plVnlQRkRPL1FIQmFwOGFz?= =?utf-8?B?Yk5wRHZTQjhXcGp6ZnF3TTl4dUtLOUNCdExLK240cmFEd3haSXZ5dGtlSCsv?= =?utf-8?B?ZEVpQzd6b25CR0MvY2tMazlSU3BlT0RYM00xT0FKUXJTTVBQOGhuQk1CZEdH?= =?utf-8?B?SC9HOENidXA0anVDWnE4dTVUSXFUV3pvQWFWOS8vWXhaK3U2RU8relE4L0wy?= =?utf-8?B?K01zdnlpdDhIU040d0t4NjhyNmVRbWkxcDN6aERsU2tOVDVDQ1Y3NzdDU3RY?= =?utf-8?B?WHhzeURFOHlacXdFQ0ZmYTJDWmI1UXF4MTR0WjVya3JrZ29ZYVFiRjM0WHJi?= =?utf-8?B?c0tyMzlPU1NObERWUExKTm5kSmtocFZCdGFCUjJPWVBnQkdkVlBxa3BJTjVK?= =?utf-8?B?Z0dUeGhoTnhNZHdKdzZuNUp4ZUx4OEd0Tlptd055cVVoeEVUbHdBK1M0M3Zy?= =?utf-8?B?bHlkZXh1cUF5UnBTTlUyMUxtVW1DdmtEMFVaUW9EeCtoYXNXc2tkczhtcFhT?= =?utf-8?B?SEgzSHJlZFdMYmU4cmxxMStJdWFPUmxkN3Y5OWNVL1AxM1BxdS8vOVduQks1?= =?utf-8?B?enc0ZmFQaDhHM1BDZzl5L3ExcDZ3YWxWV1dNaEx0bWdCaU4wdzE1emYrTTdo?= =?utf-8?B?cXpRL042ZDNJamNZM2lIWWhtaHovWkFwT2JPdGU4Mi9pYlUyWUsyejU2L2x2?= =?utf-8?B?RzV4d0JuYXBFYXppQ255MUJhTHk1aUtQbDZCVVhtQXJKQTBtWDlER3lEWjh1?= =?utf-8?B?TmpmSDkxRnlMUUU0eXVHWi9RWWxoSFBTU0xrTzMyMW9wdlNMNXZrYi9udUEx?= =?utf-8?B?SG84bSswNGtQd1QwWGNVVnAvYW1SUFo5T28wU29zU0E1OUJIb1hDcFdudHNN?= =?utf-8?B?MExlZFZLN1lSNFJVRmR0RmdXMXdvNDhUV0ZjZFFFbE1DNlFidHNZU0dWaWs1?= =?utf-8?B?TE9OaVRPS1pJRG5URHEvTkQ3WXBsb1VLeW1mYTR5NjV0U3UvcUZhUFV3QjB1?= =?utf-8?B?ZWhhQVJ2ZUI2bS9MNzBEZllDS0ZaRlRJZHU4OHZ4aUdwR2E3MlYrQTk5WEVs?= =?utf-8?B?RUREMmFPR3FaMlhxZzJXT3pFSkJRbGluSlArMnJFRkVSWjRpWXNqckJOVUox?= =?utf-8?B?WFh2eGtxRjB1VWd6SUYxWVRZclRmNzVEMjk5K2NrVklJYXUwUjk0cHlmUUE4?= =?utf-8?B?MTg0YnFFNWlzQ3VNRXZWNURNZU5kbll4ZXUvckpDcVd1M2ZEaURzS0FkZjRD?= =?utf-8?B?bEczNkFlUmpvWlNWSnc4Vi9DTUM5Umt4WHZDVEhtcy9qTGZnQzRQbDh4SVBo?= =?utf-8?B?QWZCUnlKdjlqTFhVYzRjNGV5TURKb3NSTEJBbStjSWtSSmdJRDcvdGdPaU9R?= =?utf-8?B?TWRkSnNidHY4ZG5vN3I4QWdnTjNpUVVORUlZa2NrNGJTQm9NKzI0dnBIeE5V?= =?utf-8?B?ZnBZV0MyZVl5RnIrcEJIMm1QZVFoZTFjT29uSmhrQ1pXUHZUNlBGSDNwSDUr?= =?utf-8?B?RmlySmdHMXZ3VVJjMnRKVEl6U2daWnJydGtsS0NRelN5ZitRMm5TVXVXNW5r?= =?utf-8?B?ekdPRDJlOWVEUURlM2pQRmZhWDZEVTFUTlhxQ0VJQTJBMWMvaFZISHRudDZK?= =?utf-8?Q?jxHWDiBplGi04KoaLYw98hiok?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7271900b-bebc-4015-01a9-08dc228ab8dd X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 18:30:38.3417 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WreTQrjcBLAo7NPE4Kl2jpvMcPfYUEEgBObkXGWcBHCxiHs9M3HrGyZer+A1yDeFMvM35oJ7Guii1zf8EgptbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4939 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Az85wnvIy9ZNsJsEAdBG4S4Bx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sTUY2d02; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") On 1/30/24 05:51, Gerd Hoffmann wrote: > On Mon, Jan 29, 2024 at 09:51:47AM -0600, Tom Lendacky wrote: >> On 1/29/24 07:22, Gerd Hoffmann wrote: >>>> +global ASM_PFX(AsmVmgExitSvsm) >>>> +ASM_PFX(AsmVmgExitSvsm): >>>> +; >>>> +; NASM doesn't support the vmmcall instruction in 32-bit mode and NAS= M versions >>>> +; before 2.12 cannot translate the 64-bit "rep vmmcall" instruction i= nto elf32 >>>> +; format. Given that VMGEXIT does not make sense on IA32, provide a s= tub >>>> +; implementation that is identical to CpuBreakpoint(). In practice, >>>> +; AsmVmgExitSvsm() should never be called on IA32. >>>> +; >>>> + int 3 >>>> + ret >>> >>> Why? I assume because the calling convention is only defined for X64? >>> >>> Why do we need this in the first place if this is never called on IA32? >>> >>> Wouldn't it be better to have an ASSERT(FALSE) for IA32 in the code >>> calling this? >> >> An ASSERT() only works for DEBUG code. >> >> I was following in the steps of AsmVmgExit, where we did this. I suppose= we >> could just not have it at all for IA32 and cause a build failure if some= one >> was to try and call this from 32-bit code. Thoughts? >=20 > See also patch #13 sub-thread. Maybe just move the 32-bit build to the > Null versions of the Libraries. >=20 > SEV-SNP + SVSM apparently is 64-bit only already (there is no 32-bit > calling convention). >=20 > Over the last year Intel landed full 64-bit PEI support in edk2, which > means the pure 64-bit build (OvmfPkgX64.dsc) has feature parity with > the 32-bit PEI / 64-bit DXE build (OvmfPkgIa32X64.dsc). >=20 > So maybe we can simply leave 32-bit support behind and remove SEV > support from OvmfPkgIa32X64.dsc and OvmfPkgIa32.dsc builds ... That would break anyone that is currently using OvmfPkgIa32X64.dsc for=20 base SEV (not ES or SNP), but I'm not sure if that is a real concern. For= =20 OvmfPkgIa32.dsc, no version of SEV will work, so that is doable. Can we look at doing that cleanup after this series? Thanks, Tom >=20 > take care, > Gerd >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114913): https://edk2.groups.io/g/devel/message/114913 Mute This Topic: https://groups.io/mt/103986440/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-