From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mx.groups.io with SMTP id smtpd.web10.68602.1680524823801252707 for ; Mon, 03 Apr 2023 05:27:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=dBN+afnu; spf=pass (domain: bsdio.com, ip: 64.147.123.21, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id ED346320099C; Mon, 3 Apr 2023 08:27:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 03 Apr 2023 08:27:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1680524821; x=1680611221; bh=Vcy9Ty9wgf2ODdd6JVZHUwO61k22dBEAKAn HHlu5Vmg=; b=dBN+afnupG351dFNm0i3CLLf0tS2OIKqbq3iC+WVvliDEP3ditY A2eRKzoXmQNgtaRek0UjFugp0DnOmb3W9aJc/Rrx57sfaPkVrWJHVdc1JxGaZweg JfB77cSgiLJsesp5Qh+AfKfoYkguFVX5PW+jr9P2yEVqpzOPGvCgNkq/EwBdIYF6 2xdG88A7iApl8Ej2OEtjxwmRNFI70gJ1TMueEUjWIRZeeTDs/Cq/yag4NzfvYYg+ supSpuiT4MX656OsRHQJXS5YqPpUlIGIEOihyjS2lQjdOMB5EKuhYL6mT2aXaM0a RE+vf8s5agK69XRMy2svBZtA18B3d3FiubQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680524821; x=1680611221; bh=Vcy9Ty9wgf2ODdd6JVZHUwO61k22dBEAKAn HHlu5Vmg=; b=gaU7larwKLBNgeh4/gOqZMaZE0FXo9GT/C5YSVtEYi9dtNjqNg+ +wLzTjyCWGgmAMc7Mts4mqlUtIg5KMak17XXZdUmU81K6zJEKyjD73p/VvM/BvUV 9Mg0F9ipX7yMU0yVAeEPRR3vaxg4jc2sVBuWhajCAGZPB5gx57LGYgVJQ+Ee5jhm wUV1Q0GiW/sGbNaIkgrhg3BoSa7ySc1m5pxwDgHjwl1q3N5uEJ5MT7DVhMl+7vU3 xCqTQvlZHSGDqi1rTKohH/UCqv0TX1FyH8ieeHR1gVAJdtRRtbj8n/LoUTi2yGZp n3udBkppqTDoAxO/NJG9m5d7wZv3/rKhTAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeijedgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeelfffffefgteelleelhfffueejledvjeevieeuieetvdehleevvdfgveel vdekhfenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtgho mh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 Apr 2023 08:26:59 -0400 (EDT) Message-ID: <2df50532-6cc1-43b5-a6e5-7642ace1ae03@bsdio.com> Date: Mon, 3 Apr 2023 06:26:58 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MiAwMC8xM10gQmFzZVRvb2xzLENyeXB0b1BrZyxNZGVQa2csT3ZtZlBrZzogRGVsZXRlIENMQU5HMzUsQ0xBTkczOCxHQ0M0OCxHQ0M0OSwgcmVuYW1lIEdDQzUgdG8gR0NDLCB1cGRhdGUgQ0xBTkdEV0FSRiwgZGVsZXRlIFZTIDIwMDgtMjAxMywgRUJD?= To: Leif Lindholm , Ard Biesheuvel Cc: Gerd Hoffmann , devel@edk2.groups.io, Pedro Falcato , gaoliming , Oliver Smith-Denny , Guomin Jiang , Xiaoyu Lu , Jian J Wang , Jiewen Yao , Ard Biesheuvel , Jordan Justen , Bob Feng , Andrew Fish , Michael D Kinney References: <20230328173111.759017-1-rebecca@bsdio.com> <02fb01d961dc$88d6acd0$9a840670$@byosoft.com.cn> <92a85636-3875-fd4d-06ff-dab9670370a5@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/3/23 6:15 AM, Leif Lindholm wrote: > On Mon, Apr 03, 2023 at 13:55:19 +0200, Ard Biesheuvel wrote: >> I agree that we should either support a toolchain (and have CI >> coverage for it) or not, in which case we should just remove it. >> >> However, the issues being reported are specific to SEV-SNP and TDX, >> which implies that they are specific to OVMF. And actually, the >> reported issue at >> >> OvmfPkg/Library/CcExitLib/CcExitVcHandler.c:1358:10: >> error: ‘XCr0’ may be used uninitialized [-Werror=maybe-uninitialized] >> >> seems to be a valid concern. >> >> So the point I am making is that OVMF gets a lot of attention in the >> open source project, but in the wider ecosystem, there are many >> platforms relying on this code base that don't incorporate the Coco >> components at all, so whether OVMF currently builds with GCC49 is not >> 100% relevant. >> >> So I am leaning towards retaining GCC49 as GCCNOLTO, and getting some >> coverage for it in CI, as we occasionally get useful diagnostics out >> of it. But I am not going to fight any battles over it - I rarely use >> it myself, and so I will not miss it when it's gone. > I agree with all aspects of this statement. I would *prefer* to keep > it as a canary - with CI. Given it's catching issues, I'd like to keep it too. In terms of CI coverage, I'd like to have both gcc 6 and gcc 12 running GCC and GCCNOLTO builds: we've already broken gcc 5 compatibility by introducing GoogleTest (which uses nullptr), so by doing builds with gcc 6 we'll be able to know when we break it and update tools_def.txt.template with a note that we'll subsequently require gcc 7. Similarly, we should also add CLANGPDB and CLANGDWARF builds. I suspect we'll rapidly run into scaling issues though, since GitHub Actions has a limit of 20 concurrent jobs on the free plan (https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration), and in order to keep CI times reasonable we'll probably want many more tasks to be running in parallel. There's a beta 'larger runners' feature (https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners), but I'm wondering if we might want to scale using something like Azure or EC2 (https://github.com/machulav/ec2-github-runner) instead, if the costs aren't going to be prohibitive? -- Rebecca Cran