From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.2030.1588144707167600316 for ; Wed, 29 Apr 2020 00:18:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GEdoS96q; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588144706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G4uBTWtR3/vwmJ3Qs+jAtdss/4/4akhga9c+RhfH6hk=; b=GEdoS96qp9sAK+3d7YtuS0a2VxaAC5cPAlToqNCqAgGBnLWrixyGiGJM7l4LsUoA7dhlkz cZnOn+O7zASvmSAi3YpFx6/WnwyHYC2l3oEz7pzNa8TUcjwmv4VmAL+XIDV2qOwKN8Jups OsYX6riJBsjyuq2ReqoF/ESjSiE/MkY= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-tpWV2g08NAG1ERq9lC60tw-1; Wed, 29 Apr 2020 03:18:23 -0400 X-MC-Unique: tpWV2g08NAG1ERq9lC60tw-1 Received: by mail-ej1-f71.google.com with SMTP id u19so557248eja.13 for ; Wed, 29 Apr 2020 00:18:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G4uBTWtR3/vwmJ3Qs+jAtdss/4/4akhga9c+RhfH6hk=; b=IdR9L/icfzMcFYCHm871BJ5GnNtYLpKY7xa3IrjRopTi5Gxoq92ghtepdcCRKaWd4r JZIp7HlHzfw8JDq9DOD8P21vrarjcAGAja4kAx8CVLqETeHeQqxkKeCz34N+jlY581fB fbAfK0nCvQSCFf4HH6nasbCEpTNOWPbk7n475wH/UKB3VrRMzBbfyVSMH5WDO8pf5iQ8 U4p9dWd9DHRuMGQhBDxigVZOV63Hz9KUg3Xp/m8L4zBzbCTofkbD10NjDmSYKsrOyryv nBzXo9S3M1hS3DyMXZUxVFCG6xdR4IiQpb4snSaG3djq7zs+u5FbYNy6Hc0c1iqx+XHr pXcw== X-Gm-Message-State: AGi0PuYwn42Qfo/EIhIC8Ze2F5jnmmzkt09QOh98D5r9M5MRHqR4go2g WRRC3PaZFcBfeZhvP+ktkzYBYd3Js4enrfjbb5BQ6rKu28XlkPszLQurpHHVEbTzbRiVyAkcKa+ PnJZVOmrZC5GOkA== X-Received: by 2002:a17:906:7c0c:: with SMTP id t12mr1390158ejo.2.1588144702420; Wed, 29 Apr 2020 00:18:22 -0700 (PDT) X-Google-Smtp-Source: APiQypIP9SEtkodG+9uVokixM4STLZv9HSWN6kc4MbMgGoMe19Rn5ecT+oRYqXGRVknTQ8rEZFzuow== X-Received: by 2002:a17:906:7c0c:: with SMTP id t12mr1390145ejo.2.1588144702086; Wed, 29 Apr 2020 00:18:22 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (137.red-88-21-205.staticip.rima-tde.net. [88.21.205.137]) by smtp.gmail.com with ESMTPSA id ks10sm703719ejb.89.2020.04.29.00.18.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2020 00:18:21 -0700 (PDT) Subject: Re: [PATCH v2 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones To: Rebecca Cran , devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel , Laszlo Ersek References: <20200429002049.570789-1-rebecca@bsdio.com> <20200429002049.570789-2-rebecca@bsdio.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <2e38afd5-d472-1b70-c132-5951379be0bf@redhat.com> Date: Wed, 29 Apr 2020 09:18:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200429002049.570789-2-rebecca@bsdio.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Hi Laszlo, On 4/29/20 2:20 AM, Rebecca Cran wrote: In case you don't mind modifying when applying, I think Rebecca missed here "Generated mechanically with find/sed." Personally I'd also add "$ sed -i -e s/EFI_D_INFO/DEBUG_INFO/ $(git grep -l EFI_D_INFO OvmfPkg/)". > Signed-off-by: Rebecca Cran > Reviewed-by: Philippe Mathieu-Daude > Acked-by: Laszlo Ersek > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > --- > OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 8 +- > OvmfPkg/AcpiPlatformDxe/PciDecoding.c | 10 +-- > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 32 ++++---- > OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 16 ++-- > OvmfPkg/Csm/CsmSupportLib/LegacyInterrupt.c | 2 +- > OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 2 +- > OvmfPkg/Csm/CsmSupportLib/LegacyRegion.c | 2 +- > OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 18 ++--- > OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 80 +++++++++---------- > OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 58 +++++++------- > OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c | 2 +- > OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 2 +- > .../LegacyBootMaintUiLib/LegacyBootMaintUi.c | 2 +- > OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 6 +- > OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 16 ++-- > .../IncompatiblePciDeviceSupport.c | 2 +- > .../Library/AcpiTimerLib/BaseAcpiTimerLib.c | 2 +- > .../AcpiTimerLib/BaseRomAcpiTimerLib.c | 4 +- > .../Library/AcpiTimerLib/DxeAcpiTimerLib.c | 2 +- > OvmfPkg/Library/LoadLinuxLib/Linux.c | 8 +- > OvmfPkg/Library/NvVarsFileLib/FsAccess.c | 16 ++-- > .../PciHostBridgeLib/PciHostBridgeLib.c | 18 ++--- > .../PlatformBootManagerLib/BdsPlatform.c | 30 +++---- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c | 6 +- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPei.c | 6 +- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSec.c | 8 +- > .../SerializeVariablesLib.c | 2 +- > .../SmbiosVersionLib/DetectSmbiosVersionLib.c | 4 +- > .../VirtioMmioDeviceLib/VirtioMmioDevice.c | 2 +- > .../Library/XenHypercallLib/XenHypercall.c | 2 +- > OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c | 4 +- > OvmfPkg/PlatformDxe/Platform.c | 6 +- > OvmfPkg/PlatformPei/FeatureControl.c | 4 +- > OvmfPkg/PlatformPei/Fv.c | 2 +- > OvmfPkg/PlatformPei/MemDetect.c | 10 +-- > OvmfPkg/PlatformPei/Platform.c | 22 ++--- > OvmfPkg/PlatformPei/Xen.c | 4 +- > .../FwBlockService.c | 10 +-- > .../FwBlockServiceDxe.c | 4 +- > .../FwBlockServiceSmm.c | 2 +- > .../QemuFlash.c | 14 ++-- > OvmfPkg/QemuVideoDxe/Driver.c | 10 +-- > OvmfPkg/QemuVideoDxe/Gop.c | 4 +- > OvmfPkg/QemuVideoDxe/Initialize.c | 8 +- > OvmfPkg/QemuVideoDxe/VbeShim.c | 4 +- > OvmfPkg/SataControllerDxe/SataController.c | 12 +-- > OvmfPkg/Sec/SecMain.c | 22 ++--- > OvmfPkg/SmmAccess/SmmAccessPei.c | 4 +- > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 16 ++-- > OvmfPkg/VirtioGpuDxe/Commands.c | 8 +- > OvmfPkg/VirtioGpuDxe/DriverBinding.c | 8 +- > OvmfPkg/VirtioGpuDxe/VirtioGpu.h | 2 +- > OvmfPkg/XenBusDxe/EventChannel.c | 2 +- > OvmfPkg/XenBusDxe/GrantTable.c | 8 +- > OvmfPkg/XenBusDxe/XenBus.c | 14 ++-- > OvmfPkg/XenBusDxe/XenBusDxe.c | 4 +- > OvmfPkg/XenBusDxe/XenStore.c | 28 +++---- > OvmfPkg/XenIoPciDxe/XenIoPciDxe.c | 2 +- > OvmfPkg/XenPvBlkDxe/BlockFront.c | 50 ++++++------ > OvmfPkg/XenPvBlkDxe/BlockIo.c | 6 +- > OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c | 2 +- > 62 files changed, 333 insertions(+), 333 deletions(-) [...]