From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com []) by mx.groups.io with SMTP id smtpd.web10.6482.1580735865167772091 for ; Mon, 03 Feb 2020 05:17:47 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 05:17:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,397,1574150400"; d="scan'208";a="219376556" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 03 Feb 2020 05:17:46 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 05:17:46 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 3 Feb 2020 21:17:44 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Mon, 3 Feb 2020 21:17:44 +0800 From: "Liming Gao" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Feng, Bob C" Subject: Re: [PATCH 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain Thread-Topic: [PATCH 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain Thread-Index: AQHV2mom3PCOGoBhNEG6Pgm+of7JsqgJc8tQ Date: Mon, 3 Feb 2020 13:17:44 +0000 Message-ID: <2e57f4c90f814de8a05eb5bd94c67972@intel.com> References: <20200203081511.371848-1-zhiguang.liu@intel.com> In-Reply-To: <20200203081511.371848-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Liu, Zhiguang > Sent: Monday, February 3, 2020 4:15 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLAN= GPDB tool chain >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2415 >=20 > For CLANGPDB tool chain and X64, use MS ABI version of GCC built-in macro= s for > variable argument lists to be align with CLANG38 tool chain. >=20 > Cc: Bob Feng > Cc: Liming Gao >=20 > Signed-off-by: Zhiguang Liu > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def= .template > index feee2bbf16..b29a823cfd 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -2759,7 +2759,7 @@ DEFINE CLANGPDB_IA32_TARGET =3D -target i6= 86-unknown-windows > DEFINE CLANGPDB_X64_TARGET =3D -target x86_64-unknown-windows >=20 > DEFINE CLANGPDB_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wno-= tautological-compare -Wno-tautological-constant- > out-of-range-compare -Wno-empty-body -Wno-unused-const-variable -Wno-vara= rgs -Wno-unknown-warning-option -Wno- > microsoft-enum-forward-reference > -DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLA= NGPDB_WARNING_OVERRIDES) -fno-stack-protector - > mms-bitfields -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas= -Wno-incompatible-library-redeclaration -fno- > asynchronous-unwind-tables -mno-implicit-float -ftrap-function=3Dundefin= ed_behavior_has_been_optimized_away_by_clang - > funsigned-char -fno-ms-extensions -Wno-null-dereference -fms-compatibilit= y -mno-stack-arg-probe > +DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLA= NGPDB_WARNING_OVERRIDES) - > DNO_MSABI_VA_FUNCS -fno-stack-protector -mms-bitfields -Wno-address -Wno-= shift-negative-value -Wno-unknown-pragmas -Wno- > incompatible-library-redeclaration -fno-asynchronous-unwind-tables -mno-i= mplicit-float -ftrap- > function=3Dundefined_behavior_has_been_optimized_away_by_clang -funsigned= -char -fno-ms-extensions -Wno-null-dereference -fms- > compatibility -mno-stack-arg-probe >=20 > ########################### > # CLANGPDB IA32 definitions > -- > 2.16.2.windows.1