From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.135997.1669680281319051896 for ; Mon, 28 Nov 2022 16:04:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cWxOvsiy; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ASMtq4C007169; Tue, 29 Nov 2022 00:04:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=8YIC+3zAsZAFncezogp1OeaA5qm2RgCvNbTPubXpPPM=; b=cWxOvsiy8FgCoY/zFLl/d6VWa00RjZmL/nd5Tc3Qc8x0kXc/Vqxn1Vnga5WCI7IOqnsf j/qwf7R4eo+aFZMCiiM08XyE+kr/0Mz64RZ+C4ywb+OvQeVVi/G1PTa0Cv6EUTLWMlQV gk83Xm3bsxshvhqUuf6NhEhPdpxdGnBkpiNxiUHEJGnmYC/Uj6zx7738B6/n8R94HKBS 4jnPzUU1jjwOHNydaC9J2qPF4CQIKdeWPp2AR+wCU4CzUXr00lcqGA+4RMUQ64sA9pI/ dzigarjIPrbvdkAdpQaLi/hn0ipjdGwfFv7yZguCRGuPGF7aOXVeSrctKY9557y6vfA+ qQ== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m513sgrpk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 00:04:29 +0000 Received: from nasanex01b.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2AT04SUa029841 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 00:04:28 GMT Received: from [10.110.4.140] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 28 Nov 2022 16:04:27 -0800 Message-ID: <2e583842-93f5-c6c9-985b-de700e868391@quicinc.com> Date: Mon, 28 Nov 2022 17:04:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [edk2-devel] [PATCH 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls To: Kun Qin , , , Leif Lindholm , "Ard Biesheuvel" , Sami Mujawar , Jian J Wang , Liming Gao References: <20220829155955.3767-1-rebecca@quicinc.com> <20220829155955.3767-2-rebecca@quicinc.com> <25c22db8-2974-44c3-9482-3972af6cd08c@gmail.com> From: "Rebecca Cran" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: UYWewHVZ_5i_4ZKDj9Re69UKUZvVB8UD X-Proofpoint-ORIG-GUID: UYWewHVZ_5i_4ZKDj9Re69UKUZvVB8UD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-28_17,2022-11-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 priorityscore=1501 mlxscore=0 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211280173 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 11/28/22 15:59, Kun Qin wrote: > Hi Rebecca/Ard, > > I was trying to reach out regarding the original patches earlier (see > below) but it might fell off your stacks > due to high traffic on the mailing list. Could you please kindly review > the questions when you have a chance? > > In addition, I found another edge case of the MP service: when the AP > routine hits a timeout, the metadata > will be left in the unfinished states. If the AP routine eventually > completes and return, this AP will stay in "finished" > but never become "ready" during this boot. I tried to add below change, > which seems to work. But please let me > know if you have other concerns: > https://github.com/kuqin12/mu_silicon_arm_tiano/commit/c76072b37018276f2fec2582d0c540be5b40d0f2 Thanks, I'll take a look and integrate the fix into the next revision of the patch series. > > Lastly, do you plan to merge these patches in the near future? This will > be a great add-on for ARM platforms. The issue that's currently preventing them from being merged is a failure I noticed on the Neoverse N2 FVP: for some reason despite enabling the MMU and caches, manual cache flushes are still required for the data to be seen between CPUs. I don't know if that's a bug in the code or in the FVP model. -- Rebecca Cran