public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: Pedro Falcato <pedro.falcato@gmail.com>, devel@edk2.groups.io
Cc: afish@apple.com, ehaouas@noos.fr, "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [PATCH] Use C99 flexible arrays
Date: Thu, 24 Aug 2023 15:03:17 -0600	[thread overview]
Message-ID: <2e8359ef-075a-dfe9-4264-7f03e19c4bf9@bsdio.com> (raw)
In-Reply-To: <CAKbZUD10pjTP7LC2gk_n=iMshqA1dnkOL8X8d+A+4fcRE4CDfg@mail.gmail.com>

I don't think I got around to explicitly requiring C11 with -std=c11, 
but since we use _Static_assert on compilers that don't have MSC 
Extensions or are C++ compilers we implicitly require it. It's possible 
it's implemented via an extension though.


-- 

Rebecca Cran


On 8/23/23 18:36, Pedro Falcato wrote:
> On Wed, Aug 23, 2023 at 10:41 PM Rebecca Cran <rebecca@bsdio.com> wrote:
>> With Visual Studio 2019 adding C11 and C17 support as first-class
>> features, I think we should be safe nowadays to rely on them. But we
>> should check if older versions that we still support (VS 2015 etc.)
>> support them too.
>>
>> https://devblogs.microsoft.com/cppblog/c11-and-c17-standard-support-arriving-in-msvc/
> Don't we explicitly rely on C11 now? Due to your __function__ changes?
>
> Anyway, I would recommend Elyes to break this change up into a patch
> set with per-package patches. This way maintainers could easily review
> and test the changes. The way it is right now isn't very reviewable
> nor testable.
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108023): https://edk2.groups.io/g/devel/message/108023
Mute This Topic: https://groups.io/mt/100861513/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-08-24 21:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21 16:56 [edk2-devel] [PATCH] Use C99 flexible arrays ehaouas
2023-08-22 15:28 ` Andrew Fish via groups.io
2023-08-23 21:41   ` Rebecca Cran
2023-08-24  0:36     ` Pedro Falcato
2023-08-24 21:03       ` Rebecca Cran [this message]
2023-08-24 15:19     ` Oliver Smith-Denny
2023-08-24 21:01       ` Rebecca Cran
  -- strict thread matches above, loose matches on Subject: below --
2023-08-20 11:07 Elyes Haouas
2023-08-21 14:32 ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e8359ef-075a-dfe9-4264-7f03e19c4bf9@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox