From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B7DDB740039 for ; Thu, 24 Aug 2023 21:03:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ixuAVZ74efniyn5AePedcb7pEPb+7fP/7ZkQY5mqLtc=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692911008; v=1; b=no5DN8qShZu0mRMBVRGGkWdCLvdwra7CS2ynVjAw3BxUxPQ7sciKfe146f5X2FZtebOrcpe2 2Xm05VQYUqnvO2oTInmoOUgxpqg7hZZ/o4Jq4dtcN6gK9n9lhkO6QTh03Ix1h9iuQrBRyOueguu mjktYbeKdsgoV9PIgo/B95EI= X-Received: by 127.0.0.2 with SMTP id l8nZYY7687511xVN1X2U3IKI; Thu, 24 Aug 2023 14:03:28 -0700 X-Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mx.groups.io with SMTP id smtpd.web10.2825.1692911007919140819 for ; Thu, 24 Aug 2023 14:03:27 -0700 X-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D252D3200657; Thu, 24 Aug 2023 17:03:26 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 24 Aug 2023 17:03:27 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddviedgudehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnhepffegudduieehjeegvdejtedtgfeijeekveejffegueejtdevfefhueej teffudeunecuffhomhgrihhnpehmihgtrhhoshhofhhtrdgtohhmnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughi ohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Aug 2023 17:03:25 -0400 (EDT) Message-ID: <2e8359ef-075a-dfe9-4264-7f03e19c4bf9@bsdio.com> Date: Thu, 24 Aug 2023 15:03:17 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [edk2-devel] [PATCH] Use C99 flexible arrays To: Pedro Falcato , devel@edk2.groups.io Cc: afish@apple.com, ehaouas@noos.fr, "Yao, Jiewen" References: <2096203168.82564.1692636984521@wsfrf1447.priv.atos.fr> <7F57F8F5-9C13-4DD1-96CE-C3F7A33A1AFF@apple.com> From: "Rebecca Cran" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YaHU6S3siyYLQIDc2BOmyFqOx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=no5DN8qS; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I don't think I got around to explicitly requiring C11 with -std=c11, but since we use _Static_assert on compilers that don't have MSC Extensions or are C++ compilers we implicitly require it. It's possible it's implemented via an extension though. -- Rebecca Cran On 8/23/23 18:36, Pedro Falcato wrote: > On Wed, Aug 23, 2023 at 10:41 PM Rebecca Cran wrote: >> With Visual Studio 2019 adding C11 and C17 support as first-class >> features, I think we should be safe nowadays to rely on them. But we >> should check if older versions that we still support (VS 2015 etc.) >> support them too. >> >> https://devblogs.microsoft.com/cppblog/c11-and-c17-standard-support-arriving-in-msvc/ > Don't we explicitly rely on C11 now? Due to your __function__ changes? > > Anyway, I would recommend Elyes to break this change up into a patch > set with per-package patches. This way maintainers could easily review > and test the changes. The way it is right now isn't very reviewable > nor testable. > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108023): https://edk2.groups.io/g/devel/message/108023 Mute This Topic: https://groups.io/mt/100861513/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-