From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 436AA940ED4 for ; Tue, 15 Aug 2023 01:22:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZOCr3fEPb4NM9byeWhmlnsBpB20GO7SeUfLzEGdEFvw=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692062559; v=1; b=SWt3QRQLIbTyVO0sGMEzdXwIfaFGYWbEuB76CBDMvvMQSglqozSlFPy384EJw91XziwfRECe m7Y1CgsrW8DwrHE80+uFG0AKlRoeqfBRkILskD+BF6xT/A/EG75HwpeVZgcRtGe0QD8lHhQrVzV TcgsMdRKT7S1l/JqC6TdaHdk= X-Received: by 127.0.0.2 with SMTP id oZQUYY7687511xav9XJ4IcaX; Mon, 14 Aug 2023 18:22:39 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.124519.1692062559360533215 for ; Mon, 14 Aug 2023 18:22:39 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id 9B9542109443; Mon, 14 Aug 2023 18:22:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9B9542109443 Message-ID: <2e851410-4eb3-074a-8ae2-159c8b45ee3c@linux.microsoft.com> Date: Mon, 14 Aug 2023 21:22:38 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 2/7] .pytool: Add cpp support to uncrustify plugin To: devel@edk2.groups.io, vnowkakeane@linux.microsoft.com References: <20230809213226.1387-1-vnowkakeane@linux.microsoft.com> <20230809213226.1387-3-vnowkakeane@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: <20230809213226.1387-3-vnowkakeane@linux.microsoft.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: A6CAOA2gFbzFSrhIo2xoQO6xx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SWt3QRQL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael Kubacki On 8/9/2023 5:32 PM, VivianNK wrote: > Modified the uncrustify config to apply cpp specific formatting rules. > Modified uncrustify check to include *.cpp files. >=20 > CC: Sean Brogan > CC: Michael Kubacki > CC: Michael D Kinney > CC: Liming Gao > Signed-off-by: Vivian Nowka-Keane > --- > .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +- > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/= Plugin/UncrustifyCheck/UncrustifyCheck.py > index 8978ffc443bf..17f77b48d954 100644 > --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > @@ -110,7 +110,7 @@ class UncrustifyCheck(ICiBuildPlugin): > # A package can add any additional paths with "AdditionalIncludePat= hs" >=20 > # A package can remove any of these paths with "IgnoreStandardPaths= " >=20 > # >=20 > - STANDARD_PLUGIN_DEFINED_PATHS =3D ("*.c", "*.h") >=20 > + STANDARD_PLUGIN_DEFINED_PATHS =3D ("*.c", "*.h", "*.cpp") >=20 > =20 >=20 > # >=20 > # The Uncrustify application path should set in this environment va= riable >=20 > diff --git a/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg b/.pytool/Plug= in/UncrustifyCheck/uncrustify.cfg > index 8506c3333715..d7e86a6e57e6 100644 > --- a/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg > +++ b/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg > @@ -215,7 +215,7 @@ indent_braces =3D false > indent_braces_no_class =3D false >=20 > indent_braces_no_func =3D true >=20 > indent_braces_no_struct =3D false >=20 > -indent_class =3D false >=20 > +indent_class =3D true >=20 > indent_class_colon =3D false >=20 > indent_cmt_with_tabs =3D false # Whether to indent c= omments that are not at a brace level with tabs on >=20 > # a tabstop. Requires i= ndent_with_tabs=3D2. If false, will use spaces. >=20 > @@ -223,7 +223,7 @@ indent_col1_comment =3D true > indent_col1_multi_string_literal=3D true >=20 > indent_comma_paren =3D true >=20 > indent_else_if =3D true >=20 > -indent_extern =3D false >=20 > +indent_extern =3D true >=20 > indent_first_bool_expr =3D true >=20 > =20 >=20 > indent_func_def_param_paren_pos_threshold =3D 0 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107754): https://edk2.groups.io/g/devel/message/107754 Mute This Topic: https://groups.io/mt/100655289/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-