public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>, Oliver Steffen <osteffen@redhat.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Michael Brown <mcb30@ipxe.org>, Min Xu <min.m.xu@intel.com>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression
Date: Fri, 20 Jan 2023 10:19:31 +0100	[thread overview]
Message-ID: <2e982eb5-2795-ce91-da10-6be7e4b62732@redhat.com> (raw)
In-Reply-To: <8dd96cf7-6dfb-665b-81fe-2cf4f283be7e@redhat.com>

On 1/20/23 10:17, Laszlo Ersek wrote:
> On 1/20/23 09:50, Laszlo Ersek wrote:
> 
>> Oliver:
>>
>> (1) can you please post a patch for the Windows CI so that the
>> following option be passed to QEMU:
>>
>>   -fw_cfg name=opt/org.tianocore/X-Cpuhp-Bugcheck-Override,string=yes
>>
>> (This option is harmless when the firmware does not determine the QEMU
>> bug, so it can be passed in advance; it will have no consequence at
>> all.)
>>
>> In the patch, please reference
>>
>>   https://bugzilla.tianocore.org/show_bug.cgi?id=4250
> 
> I *think* the call chain is something like
> 
> Platform_CI              [edk2/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml]
>   FlashRomImage          [edk2-pytool-extensions/edk2toolext/environment/uefi_build.py]
>     FlashRomImage        [edk2/OvmfPkg/PlatformCI/PlatformBuildLib.py]
>       qemu-system-x86_64 [edk2/OvmfPkg/PlatformCI/PlatformBuildLib.py]
> 
> So I believe a new variable, similar to QEMU_HEADLESS, should be
> introduced, in "OvmfPkg/PlatformCI/PlatformBuildLib.py" and
> "OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml", for controlling
> the above command line switch. Maybe it should be documented even, in
> "OvmfPkg/PlatformCI/ReadMe.md".
> 
> Call the new variable QEMU_X_CPUHP_BUGCHECK_OVERRIDE?

Haha, I'm sooo late; Ard has already posted such patches ;)

Laszlo


  reply	other threads:[~2023-01-20  9:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 11:01 [PATCH v3 0/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression Laszlo Ersek
2023-01-19 11:01 ` [PATCH v3 1/2] OvmfPkg/PlatformInitLib: factor out PlatformCpuCountBugCheck() Laszlo Ersek
2023-01-19 11:01 ` [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression Laszlo Ersek
2023-01-19 11:27   ` Ard Biesheuvel
2023-01-20  8:50     ` Laszlo Ersek
2023-01-20  9:10       ` Ard Biesheuvel
2023-01-20 12:55         ` Laszlo Ersek
2023-01-20  9:17       ` Laszlo Ersek
2023-01-20  9:19         ` Laszlo Ersek [this message]
2023-01-19 11:25 ` [edk2-devel] [PATCH v3 0/2] " Michael Brown
2023-01-19 12:05 ` Gerd Hoffmann
2023-01-20 13:48 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e982eb5-2795-ce91-da10-6be7e4b62732@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox