From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.70332.1674206380358561501 for ; Fri, 20 Jan 2023 01:19:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=L6J/EpPN; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674206379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HHas+Xme+np6M+LA2D6FiYKh6+w3Nq9qUUCVpf3iNFw=; b=L6J/EpPNWzwiFTgvKVhjOvG96/AFqkYrO8VXOxfhVKfZp412InmOdJqzmC1a5OBUz3zMsA /X/0NsTkiJ8U38usxFy64qAB4p8C/JmciAg5sQIn09xNbPI1sy1U9xhdZ1j2jEMokhj5s5 VExdsap7BBN6JbjoRZQl9PMb8iS/BAU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-137-MO6eTytTNKmgF-ubyRs19A-1; Fri, 20 Jan 2023 04:19:36 -0500 X-MC-Unique: MO6eTytTNKmgF-ubyRs19A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7D9CA185A794; Fri, 20 Jan 2023 09:19:35 +0000 (UTC) Received: from [10.39.192.173] (unknown [10.39.192.173]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 25C7940C6EC4; Fri, 20 Jan 2023 09:19:33 +0000 (UTC) Message-ID: <2e982eb5-2795-ce91-da10-6be7e4b62732@redhat.com> Date: Fri, 20 Jan 2023 10:19:31 +0100 MIME-Version: 1.0 Subject: Re: [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression From: "Laszlo Ersek" To: Ard Biesheuvel , Oliver Steffen Cc: devel@edk2.groups.io, Ard Biesheuvel , Brijesh Singh , Erdem Aktas , Gerd Hoffmann , James Bottomley , Jiewen Yao , Jordan Justen , Michael Brown , Min Xu , Sebastien Boeuf , Tom Lendacky References: <20230119110131.91923-1-lersek@redhat.com> <20230119110131.91923-3-lersek@redhat.com> <8dd96cf7-6dfb-665b-81fe-2cf4f283be7e@redhat.com> In-Reply-To: <8dd96cf7-6dfb-665b-81fe-2cf4f283be7e@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/20/23 10:17, Laszlo Ersek wrote: > On 1/20/23 09:50, Laszlo Ersek wrote: > >> Oliver: >> >> (1) can you please post a patch for the Windows CI so that the >> following option be passed to QEMU: >> >> -fw_cfg name=opt/org.tianocore/X-Cpuhp-Bugcheck-Override,string=yes >> >> (This option is harmless when the firmware does not determine the QEMU >> bug, so it can be passed in advance; it will have no consequence at >> all.) >> >> In the patch, please reference >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=4250 > > I *think* the call chain is something like > > Platform_CI [edk2/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml] > FlashRomImage [edk2-pytool-extensions/edk2toolext/environment/uefi_build.py] > FlashRomImage [edk2/OvmfPkg/PlatformCI/PlatformBuildLib.py] > qemu-system-x86_64 [edk2/OvmfPkg/PlatformCI/PlatformBuildLib.py] > > So I believe a new variable, similar to QEMU_HEADLESS, should be > introduced, in "OvmfPkg/PlatformCI/PlatformBuildLib.py" and > "OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml", for controlling > the above command line switch. Maybe it should be documented even, in > "OvmfPkg/PlatformCI/ReadMe.md". > > Call the new variable QEMU_X_CPUHP_BUGCHECK_OVERRIDE? Haha, I'm sooo late; Ard has already posted such patches ;) Laszlo