From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.4207.1622103948455811063 for ; Thu, 27 May 2021 01:25:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jRYx/xfb; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622103947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HfO2cvNMJk4Qqdow/tnKiOvnHNwPZpVOBWu+pEpwo2M=; b=jRYx/xfbn/mreRW+YZLfcXBqg85Uu9+Tv2WSM5zYLk41AGiVz9z3aKjGn8uMZfvehDX40P y+Zh4dn4wstZkwE4WVIAiHwQf5N16458qgRmv2ePKt687EsaIg8yy++PkXrVEeEmZdf141 3C579pLMXjHEdaPydwVSDT3DoTOCU58= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-334-x1AicEa9MTCNyVH8v9ahvA-1; Thu, 27 May 2021 04:25:45 -0400 X-MC-Unique: x1AicEa9MTCNyVH8v9ahvA-1 Received: by mail-wr1-f70.google.com with SMTP id a9-20020adfc4490000b0290112095ca785so1445396wrg.14 for ; Thu, 27 May 2021 01:25:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HfO2cvNMJk4Qqdow/tnKiOvnHNwPZpVOBWu+pEpwo2M=; b=YGSUUGfkb5BztPpZB4SHy/jlceC4v+ZSviT0KPhNEy39HyY3qknNg9ERkuBh8ogeUt RKVEuGsOtbgFeOMW2EZOIbZduJ27wt85Vfil7f3V1wAhfNvp01LHmDWVAd7Q7FWD3o3N cpDt2U6lC1VT9ZToXNT/EWEfWFbwsQUHH3Un/R5nLBmN6mgjmieVYLTksyE21Ct8LoYH kan2RG0zn87lJaJEluzR3WLDNRQs9l7lIsyx/3tVtz97iQEJU1JZuTP2NxAJo5T9LN1v r5eA3l4jDRLcaNEO9d7IokymIAinElwypK1UYBVzWoWunR/cgxM9mFdRLgxzfbP+qb8U fJ6w== X-Gm-Message-State: AOAM530H4U3ctWJ1BUqWTL44TZ/1Qh6p8Iz9ZhbgkIm3BpDNmlCOUhj5 SeL7E+59gVuoGtfLeLFvV4DzvlGZbSj2CMQVTWHZ9hTfjq9HHmkx3FSE47nSjgaK9ymEXE4Pkz+ 8irxxs55f9sZXWw== X-Received: by 2002:a05:600c:4ecb:: with SMTP id g11mr7284868wmq.46.1622103944829; Thu, 27 May 2021 01:25:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwK3cWZ479RKuo4OO6joJTvIqqX0FoaRDotlsnERIVo8ayU4c8mRmuNJIswZ0r3rLFdq5iXKw== X-Received: by 2002:a05:600c:4ecb:: with SMTP id g11mr7284859wmq.46.1622103944646; Thu, 27 May 2021 01:25:44 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id f16sm1994562wrm.47.2021.05.27.01.25.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:25:44 -0700 (PDT) Subject: Re: [PATCH 07/43] OvmfPkg/AcpiPlatformDxe: sort #includes and [LibraryClasses] To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-8-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <2e9997d6-9c0e-d336-44f7-19cdc635c448@redhat.com> Date: Thu, 27 May 2021 10:25:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-8-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > Place all public #includes first, all module-private #includes second. > Separate them with a single empty line. Keep each section sorted in > itself. > > Sort all sections in both INF files. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 18 +++++++++--------- > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf | 2 +- > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 15 ++++++--------- > OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 1 + > OvmfPkg/AcpiPlatformDxe/Qemu.c | 11 ++++++----- > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 12 ++++++------ > OvmfPkg/AcpiPlatformDxe/Xen.c | 3 ++- > 7 files changed, 31 insertions(+), 31 deletions(-) Reviewed-by: Philippe Mathieu-Daude