public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>,
	edk2-devel-01 <edk2-devel@ml01.01.org>,
	ruiyu.ni@intel.com
Subject: Re: af468025 breaks my linux build
Date: Tue, 4 Oct 2016 23:22:18 +0200	[thread overview]
Message-ID: <2ead6db9-9a19-534a-2214-f0ee7de00659@redhat.com> (raw)
In-Reply-To: <20161004200603.GF552@HEDWIG.INI.CMU.EDU>

On 10/04/16 22:06, Gabriel L. Somlo wrote:
> Hi,
> 
> I'm building with
> 
> 	build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc
> 
> on a F24 box, and right now things are breaking with this error
> message:
> 
> 
> lo/KVM-OSX/SCRATCH/edk2/MdeModulePkg
> -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Include
> -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg
> -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include
> -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/X64
> /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiSpec.h:2192:0,
>                  from
> /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/PiDxe.h:20,
>                  from
> /home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/DEBUG/AutoGen.h:17,
>                  from <command-line>:0:
> /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c:34:18:
> error: ‘IMG_LOGO’ undeclared here (not in a function)
>      IMAGE_TOKEN (IMG_LOGO),
> GNUmakefile:420: recipe for target
> '/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj'
> failed
>                   ^
> /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h:2133:24:
> note: in definition of macro ‘IMAGE_TOKEN’
>  #define IMAGE_TOKEN(t) t
>                         ^
> make: ***
> [/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj]
> Error 1
> 
> 
> The place it's complaining about comes from commit af468025
> (MdeModulePkg/Logo: Add LogoDxe module).
> 
> 
> Thanks (and sorry if this is an already-known issue).

Please clean out your Build/ directory, also your Conf/ directory
(except for ReadMe.txt and .gitignore that belong there), and re-run

  source edksetup.sh

from a pristine-env shell.

The problem (on your side) is that you don't have the new build rules
for *.idf files under Conf/ (from commit 333ba578fef4d, "BaseTools:
support generating image package from BMP/JPEG/PNG files"), thus
IMG_LOGO, from "MdeModulePkg/Logo/Logo.idf", is not visible to the compiler.

Thanks
Laszlo


  reply	other threads:[~2016-10-04 21:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-04 20:06 af468025 breaks my linux build Gabriel L. Somlo
2016-10-04 21:22 ` Laszlo Ersek [this message]
2016-10-05  0:41   ` Gabriel L. Somlo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ead6db9-9a19-534a-2214-f0ee7de00659@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox