From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F30651A1E43 for ; Tue, 4 Oct 2016 14:22:20 -0700 (PDT) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3742D445CE; Tue, 4 Oct 2016 21:22:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-70.phx2.redhat.com [10.3.116.70]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u94LMIBP016183; Tue, 4 Oct 2016 17:22:19 -0400 To: "Gabriel L. Somlo" , edk2-devel-01 , ruiyu.ni@intel.com References: <20161004200603.GF552@HEDWIG.INI.CMU.EDU> From: Laszlo Ersek Message-ID: <2ead6db9-9a19-534a-2214-f0ee7de00659@redhat.com> Date: Tue, 4 Oct 2016 23:22:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161004200603.GF552@HEDWIG.INI.CMU.EDU> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 04 Oct 2016 21:22:20 +0000 (UTC) Subject: Re: af468025 breaks my linux build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2016 21:22:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 10/04/16 22:06, Gabriel L. Somlo wrote: > Hi, > > I'm building with > > build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc > > on a F24 box, and right now things are breaking with this error > message: > > > lo/KVM-OSX/SCRATCH/edk2/MdeModulePkg > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Include > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/X64 > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c > In file included from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiSpec.h:2192:0, > from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/PiDxe.h:20, > from > /home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/DEBUG/AutoGen.h:17, > from :0: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c:34:18: > error: ‘IMG_LOGO’ undeclared here (not in a function) > IMAGE_TOKEN (IMG_LOGO), > GNUmakefile:420: recipe for target > '/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj' > failed > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h:2133:24: > note: in definition of macro ‘IMAGE_TOKEN’ > #define IMAGE_TOKEN(t) t > ^ > make: *** > [/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj] > Error 1 > > > The place it's complaining about comes from commit af468025 > (MdeModulePkg/Logo: Add LogoDxe module). > > > Thanks (and sorry if this is an already-known issue). Please clean out your Build/ directory, also your Conf/ directory (except for ReadMe.txt and .gitignore that belong there), and re-run source edksetup.sh from a pristine-env shell. The problem (on your side) is that you don't have the new build rules for *.idf files under Conf/ (from commit 333ba578fef4d, "BaseTools: support generating image package from BMP/JPEG/PNG files"), thus IMG_LOGO, from "MdeModulePkg/Logo/Logo.idf", is not visible to the compiler. Thanks Laszlo