Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

["Nhi Pham via groups.io" <nhi=os.amperecomputing.com@groups.io>]

Hi Liming,

Could you please help review and get this patch merged within the next
edk2-stable tag?

Thanks,
Nhi

On 10/23/2023 11:27 AM, Nhi Pham via groups.io wrote:
> This looks good to me. I also build-tested this patch.
> 
> Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
> Tested-by: Nhi Pham <nhi@os.amperecomputing.com>
> 
> On 10/3/2023 10:04 PM, Jake Garver via groups.io wrote:
>> Ignore old style declaration warnings in oniguruma/src/st.c.  This was
>> already ignored for MSFT, but newer versions of clang complain as well.
>>
>> Signed-off-by: Jake Garver <jake@nvidia.com>
>> ---
>>   .../Universal/RegularExpressionDxe/RegularExpressionDxe.inf      | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git
>> a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
>> b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
>> index 84489c2942..0092531a67 100644
>> ---
>> a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
>> +++
>> b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
>> @@ -102,6 +102,7 @@
>>       # Oniguruma: old style declaration in st.c
>>     MSFT:*_*_*_CC_FLAGS = /wd4131
>> +  GCC:*_*_*_CC_FLAGS = -Wno-deprecated-non-prototype
>>       # Oniguruma: 'type cast' : truncation from 'OnigUChar *' to
>> 'unsigned int'
>>     MSFT:*_*_*_CC_FLAGS = /wd4305 /wd4306
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110677): https://edk2.groups.io/g/devel/message/110677
Mute This Topic: https://groups.io/mt/101735690/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-