From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 71140941246 for ; Sun, 5 Nov 2023 07:09:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=i355+4qAKS7lpGSSGNRVQ8TG2apYzaRSD+v+s+i8p4M=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:CC:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699168159; v=1; b=JKc8bzgXpAdJg7reP7ETuoVi6mI5QZjDrnTfZSB+PJPo63rJ9YrJfHGhZsYm2ONqeBjfgVui J2b7ho/KVdBI94DjGmhmu6+iDaEFiy95qxvJMcdxuTb483V9hu4He4UvhAqk2/4ZmAxrjCs3F22 dHuYx/DfbHJinvnSRrK0zt0I= X-Received: by 127.0.0.2 with SMTP id oUe0YY7687511xyjLDid4Dfc; Sun, 05 Nov 2023 00:09:19 -0700 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.116]) by mx.groups.io with SMTP id smtpd.web11.25966.1699168158498540124 for ; Sun, 05 Nov 2023 00:09:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eXr3jCV/cex1hrfD0uvvcmzOCxZa8rNyu1J4WsbQcqplsmsVZnmE1wxViJ1kiSsHyoggzBTQ0l0Kw+1b+MzTyWBcYoNqNJvZYZUDjCdpsfOFKBFj1Uk1jYl2GiNuoBDWTk7COOM0Gk+QhghIqwBIM2rhX2KLgBC6kId4el4ZClpaAnJmfIf1s+GBvkEFQlrpOGid14JgnDkGoqhB3+SQQulNnLBayWFzug/9Tc3XQnJhw1dvSML5jkj9zyk127FxWzAZgnI/8L4UsweAQr5srrCmg2WXpo1IIuul7wxTlW94W7jZU2R9kGjlCRrMvCr97z4LUH/KOdBunae7/vJGBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EluAO4J/AGBoGPPdZUyUgmq9wdAtSE46o2bci8ak9T0=; b=TO2d99lPraovZau6iTlRE6X/BJkb18Vt5hWKlZFqD9M0ubDtNKgCB30I4b8OLYFcHhBrhijUCpA56xq6tTwyOaRwY+sEcs214F9qdqVQ/klx5DpTpx/oGa47JLHbIDqRvCBT9fSfPUnELfgUDABNqUfpFLEjX+4tLRZMPdlO0272gz3RPGoAuY86WaBd5QxpGJQ9VQx7Y8bY5+ofBnizSoAiAVaYqewAJ7eq1LSQdePe0NKk2XzjlZPWBBcQXa5nffRkoMzKyNhXyFKBBqZUNfhUp9CUhxjy36Req9MBBzCLwVjLy+fSs6x1VTwdnbXSP4SaigeJeV/uln95OpP1gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by MW4PR01MB6129.prod.exchangelabs.com (2603:10b6:303:77::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.27; Sun, 5 Nov 2023 07:09:13 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::b6b8:a922:8486:666a]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::b6b8:a922:8486:666a%7]) with mapi id 15.20.6954.025; Sun, 5 Nov 2023 07:09:13 +0000 Message-ID: <2ec7ff5b-11ab-499d-8b51-92795de878ca@os.amperecomputing.com> Date: Sun, 5 Nov 2023 14:09:06 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error To: devel@edk2.groups.io, jake@nvidia.com CC: jian.j.wang@intel.com, gaoliming@byosoft.com.cn References: <1790A21286FB1538.11247@groups.io> From: "Nhi Pham via groups.io" In-Reply-To: <1790A21286FB1538.11247@groups.io> X-ClientProxiedBy: CH0PR03CA0321.namprd03.prod.outlook.com (2603:10b6:610:118::17) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|MW4PR01MB6129:EE_ X-MS-Office365-Filtering-Correlation-Id: 53b92dff-990d-4fff-b4bc-08dbddce1d38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: UoRDxSgDvzpvMwJgXsQIh+7o/UfXY8VHxyjpB+VvZ6BUWBmXDaPy8ea5nlAJGVjcFFkwRX4Jd6B/60qAkzsUNxbq32k+aQ6TN3E74JpiXi7kzhipq+Z9qAeYspk2S08Lwz7oCJk854yfqhpOfuH5wVxmEZfsCGeLSkb/uaTPg569Zi7FlSHE0u6qL+CYt5I8S6nJDwlrouFyyXan0XB0PqVvC3QVLunklxLNOO5LkRcU/nJ9OBr3QGwLeBiCAZIlRfWIaVPZaJ62oQKj/4ZZjXe98gfIu1l07uI2pF/+Nd46A8DjEQHtz+7lXgilFA46LdTP5ikr7Eecj5SnS/wOhPOI/RO+WIGZZ7n8ugJCvfX/5PQMhLWXCC1ErhtRNwvOtBv5gjt317LrC/ZlMZJ7BO1I5YuFOIqsLtfvFddRAt/NKOWznwRoHDpEdWHJENZdV3IH6L4rysscOE6UmI5WhnmT6FMcymCBZpDn6q1Qe1JO3ZCPeEVOmMWVA7yj1E27YDLCPgSP1AHZSkX2ypCw7Myy5JdD+kIYwIB69DA5XTcYjFWeN56k4g+As/mOPo4g0FtGIpTH8DOvvoFTD/Rw59KWg2ZhfT2dIF1Fw6aOVImm4Js3N97WwvOB1y0IM+m1JaRq8ynzFT4CiSRHFPSEPg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nsA971D4rNwLYpQSvyETHA0fOsmu0+OGXALOcCXSCqWEjovimdZCUf/A89du?= =?us-ascii?Q?juAjFkNBKGPwEElqfuOq9ygJgye/3hxku+xJ5ammIT/PSbIgHil8iXsD8zcn?= =?us-ascii?Q?GStjGrU5FnoP/MKKynUYsRMaltHjgZit3M6AQ6g6OyphaaszXlU/sJFqAVBg?= =?us-ascii?Q?1TpT3HwzXEiDhy1so/W9kLNHaJggJQe+PJ3dEtQzH5/5l8s8QTKE1NC84Do8?= =?us-ascii?Q?wNDu3KWhfy5wMu8WDPOm/79hLE0cc5CJOEkD2c4LNGyKA/3dvgAyU4r6OMVt?= =?us-ascii?Q?zuOm80xd0chAZhY6GtMrRoDchL/dGvWlPsExDizZ1Gcoe8oWqBdZAziYV6Rn?= =?us-ascii?Q?uT62MaLFcjaVWY4YOcSIYlaJcnozs7ku694S8oyLYAp2p+2/2+9F+uR5hS9U?= =?us-ascii?Q?HVZI9NR2OfRpkJCMw1vd7iGqcfIMstj2Amxk1t6+XnsduuupdQfNGuJw5oFJ?= =?us-ascii?Q?c2YpeRA7MBW+XbR0ScSUPrl8EmTq/F7kO3Pc+ML328WSlms/iLfyC55/lHn1?= =?us-ascii?Q?c4gNE5TPWMM+6r7bgbsx5htnKN3s0V88LEc+07TNo03tTLmYmaXQPti77h05?= =?us-ascii?Q?40/BWbzS7ZSppnLkaGFsq0HLmX+BO3fyWmjPRdDzqLfP0vcwyAV5mK8lds+Q?= =?us-ascii?Q?LnqRN5jLw3isBH8oRMHgzJJT4z7+U2KXSXhfw9fqRGOhjS+G0s+6JPfLQGTr?= =?us-ascii?Q?NXkDHNMXDN9bsdsUgvS1ccnES69lL/RCppnD0D+qHRHKlyWva6FdLPY2PADr?= =?us-ascii?Q?LT9rdwU8Wi7ITJ23a52l7yoRnZ7x3/h3AwvIa++OaKZVROSPlFpzE5vo3G0j?= =?us-ascii?Q?GN1dIeWuXPS9XZ9AKa0o96T47IBS8CCmd53UbT9fmSkUdEAVDz+pHrbQ6IL/?= =?us-ascii?Q?IwGM1TUGZSAgTkCvNBAfAkS9Xe+N3VOzsPOIpONWV9Gw047hgrEuqVP+ftsY?= =?us-ascii?Q?0ah3Vpq8oX8FWLcaRfseHie3rftRkBa7+UZqaCYPKypQTsA2yvkFO0AlNPlv?= =?us-ascii?Q?IysDl62Sm+gFNlqqOnLdVvBpLACNDv8ciFDOl2qnlyRniZ1EG+SnTODS8fyf?= =?us-ascii?Q?Fm0mjREdXQ7JmuzX1g7eXILbLtntehtt/0uUPiHalwh1WT9zQRLCU2Fts6we?= =?us-ascii?Q?6W4ccEBgXtAkRvJMAXWL490Yft/I7K0o8sX/eT9D5wcIMuItn0fbOlnnagM1?= =?us-ascii?Q?lbOR6f5w9xMWw90IkYMCZF8wz0GYT+lOPzg0rJ6CigYIFFeIvbJVwQirxzZZ?= =?us-ascii?Q?EQEc3PO4gqe1PCZOfAQF7k2aylqie+Nb2aqCON+7Sf/mPjThtXxBse55wNDg?= =?us-ascii?Q?yfCEtck4y6aMP7qJl+YYmEmMoyGgYcCRkBMpUWUGgtKXyrgYmS7wS9QjHA0Z?= =?us-ascii?Q?lpSSrBHVM67SzZrkrQ3Whv8JcJfFZ0QfK9p0yc1iKLhjOS9pXZAm08wRUhpR?= =?us-ascii?Q?yhr78t9kjNhQ75c9svYbfKq/iZDuRtBnQWa8UgrmZq6NwDKnP56mKeEWMtCV?= =?us-ascii?Q?pvFvC32BfREjNuvElRJ8PJOmT6BOxdV4RPmF/+9FOJgj43rebkNolg9glo6a?= =?us-ascii?Q?P6se2uF7+qz9T0z92ubTQ1X09/68TC6oDf5uAcyDfd33V8hvqsN31q5LiCgb?= =?us-ascii?Q?Mg=3D=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53b92dff-990d-4fff-b4bc-08dbddce1d38 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2023 07:09:12.8154 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yYzaXfGTSa9u9oWUOS345adk0MEd36FWwfj+bV5x9ct5wMF2HXz6Zy9GUc6ByMMhdMJQiA1I4cNkrAqqUzfgRa+EJg6gqARlGzu6996Bomk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR01MB6129 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8ceYb9NHipxcqYTuAcTiRaSsx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JKc8bzgX; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Liming, Could you please help review and get this patch merged within the next edk2-stable tag? Thanks, Nhi On 10/23/2023 11:27 AM, Nhi Pham via groups.io wrote: > This looks good to me. I also build-tested this patch. >=20 > Reviewed-by: Nhi Pham > Tested-by: Nhi Pham >=20 > On 10/3/2023 10:04 PM, Jake Garver via groups.io wrote: >> Ignore old style declaration warnings in oniguruma/src/st.c.=C2=A0 This = was >> already ignored for MSFT, but newer versions of clang complain as well. >> >> Signed-off-by: Jake Garver >> --- >> =C2=A0 .../Universal/RegularExpressionDxe/RegularExpressionDxe.inf=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 1 + >> =C2=A0 1 file changed, 1 insertion(+) >> >> diff --git >> a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf >> b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf >> index 84489c2942..0092531a67 100644 >> --- >> a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf >> +++ >> b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf >> @@ -102,6 +102,7 @@ >> =C2=A0 =C2=A0=C2=A0=C2=A0 # Oniguruma: old style declaration in st.c >> =C2=A0=C2=A0=C2=A0 MSFT:*_*_*_CC_FLAGS =3D /wd4131 >> +=C2=A0 GCC:*_*_*_CC_FLAGS =3D -Wno-deprecated-non-prototype >> =C2=A0 =C2=A0=C2=A0=C2=A0 # Oniguruma: 'type cast' : truncation from 'On= igUChar *' to >> 'unsigned int' >> =C2=A0=C2=A0=C2=A0 MSFT:*_*_*_CC_FLAGS =3D /wd4305 /wd4306 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110677): https://edk2.groups.io/g/devel/message/110677 Mute This Topic: https://groups.io/mt/101735690/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-