From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.70908.1584373593102720306 for ; Mon, 16 Mar 2020 08:46:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) IronPort-SDR: jstRPDtU1WgpNNpp60gq20vPMlWHxLseTjBeMZkXWRvzkfgqZdiK9NMqYGhoow+19Uk2b+sVi0 /i3IGl7aStKQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 08:46:32 -0700 IronPort-SDR: YgwCCGh9alS0YeNvA28CR8U2z7xY/uESg/96mQwRtHEgs9YBcHxFSIEUH8tPbs02QyO1QZVIip ZBk9pyCzm8fQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,560,1574150400"; d="scan'208";a="290733936" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 16 Mar 2020 08:46:32 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 08:46:31 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 16 Mar 2020 23:46:29 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Mon, 16 Mar 2020 23:46:29 +0800 From: "Liming Gao" To: Laszlo Ersek , "devel@edk2.groups.io" CC: Ard Biesheuvel , "michael.kubacki@microsoft.com" Subject: Re: [patch v2] OvmfPkg: Fix build failure with VS2015 tool chain Thread-Topic: [patch v2] OvmfPkg: Fix build failure with VS2015 tool chain Thread-Index: AQHV+EJmkI/EXrrhTE6J7PvQ8Hd1EqhLY13w Date: Mon, 16 Mar 2020 15:46:29 +0000 Message-ID: <2f10c3961ba248ae80a2904dd160ed18@intel.com> References: <20200312043008.1389-1-liming.gao@intel.com> <8b8b829c-f3b2-2a36-77b7-abc8d567337e@redhat.com> In-Reply-To: <8b8b829c-f3b2-2a36-77b7-abc8d567337e@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I take BZ 2582. I will update the commit message and merge this change.=20 Thanks Liming > -----Original Message----- > From: Laszlo Ersek > Sent: Thursday, March 12, 2020 3:47 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; michael.kubacki@microsoft= .com > Subject: Re: [patch v2] OvmfPkg: Fix build failure with VS2015 tool chain >=20 > Hello Liming, >=20 > (adding Michael) >=20 > On 03/12/20 05:30, Liming Gao wrote: > > warning C4244: '=3D': conversion from 'UINTN' to 'UINT32', possible los= s of data > > With this fix, OvmfIa32, OvmfX64 and OvmfIa32X64 can pass build. > > > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Signed-off-by: Liming Gao > > --- > > OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > > index 1868c9fcaf..1f02da2503 100644 > > --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > > +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > > @@ -384,7 +384,7 @@ QemuLoadKernelImage ( > > // > > // Drop the terminating NUL, convert to UTF-16. > > // > > - KernelLoadedImage->LoadOptionsSize =3D (CommandLineSize - 1) * 2; > > + KernelLoadedImage->LoadOptionsSize =3D (UINT32) ((CommandLineSize = - 1) * 2); > > } > > > > QemuFwCfgSelectItem (QemuFwCfgItemInitrdSize); > > >=20 > This patch seems to be fixing the pre-existent TianoCore ticket >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2582 >=20 > Can you please coordinate with Michael? >=20 > BTW, I prefer this patch to the one that Michael attached to the ticket > in . >=20 > So my suggestion is for Liming to reassign the BZ to himself please, > reference the BZ in the commit message, and then merge this patch. >=20 > Reviewed-by: Laszlo Ersek >=20 > Thanks, > Laszlo