From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.1053.1580932886033115856 for ; Wed, 05 Feb 2020 12:01:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ceV2BVBc; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580932885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qXbqRmSclt+Z3r5vvBYMKqCpaJwAXESRAAZvXxj8ey8=; b=ceV2BVBcp9CLMfy0b6ULjnshrSCwcg0rsEhMzUOCCnyF3XsPixWMurGda7j5ctr+gwRuJ4 3wOAzQSE4yZuCDr2gcuiV49ZJ8DIT9W0SKIGftapcBtlnXVvBJZDs3zK5q2kaKd0YU88BB R4+8HWug12oABhRQdHD1bAfSmnI5zP0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-tRCGCJsXPGi7bi8XOjKhGw-1; Wed, 05 Feb 2020 15:01:07 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8CC66800D5C; Wed, 5 Feb 2020 20:01:06 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-248.ams2.redhat.com [10.36.116.248]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5026E60C18; Wed, 5 Feb 2020 20:01:05 +0000 (UTC) Subject: Re: setting the push label at once, when opening a PR [was: SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy] To: "Kinney, Michael D" , "devel@edk2.groups.io" Cc: "Zhang, Chao B" , "Wang, Jian J" , "Yao, Jiewen" References: <20200116190705.18816-1-lersek@redhat.com> <45017d12-10e1-8a9b-2997-c8fa42fc1049@redhat.com> <245e69b7-be55-4d38-9a75-dbc3fd227e77@redhat.com> From: "Laszlo Ersek" Message-ID: <2f1bb61e-29ac-7ad6-0a47-f06e7ef778d2@redhat.com> Date: Wed, 5 Feb 2020 21:01:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: tRCGCJsXPGi7bi8XOjKhGw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/05/20 17:16, Kinney, Michael D wrote: > Hi Laszlo, > > If I follow this link, I see the expected screen with the ability to set a label: > > https://github.com/lersek/edk2/pull/new/smram_at_default_smbase_bz_1512_wave_1_v2_pull > > If I type in the following URL from your screen shot, I also get the same screen with the ability to set a label: > > https://github.com/tianocore/edk2/compare/master...lersek:smram_at_default_smbase_bz_1512_wave_1_v2_pull?expand=1 > > It also looks like you are logged into GitHub, so that does not appear to be the issue. > > I also verified you are a member of EDK II Maintainers, so that does not appear to be the issue. > > Can you try both of the links above again? I've just done that, I even disabled uBlock Origin temporarily. No change -- I still don't get the labels selection, under either link. And I'm still logged in. Perhaps the problem is that I don't have write access to the repo. https://help.github.com/en/github/managing-your-work-on-github/labeling-issues-and-pull-requests https://help.github.com/en/github/managing-your-work-on-github/applying-labels-to-issues-and-pull-requests "In repositories where you have write access, you can assign labels to issues and pull requests to help organize your projects." (But then I don't understand why I'm permitted to set the "push" label on an existent PR...) Thanks Laszlo