public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v1 1/1] ArmPkg/ArmMmuLibb: Fix implicit cast
@ 2020-06-25  7:59 PierreGondois
  2020-06-25 10:10 ` [edk2-devel] " Laszlo Ersek
  0 siblings, 1 reply; 2+ messages in thread
From: PierreGondois @ 2020-06-25  7:59 UTC (permalink / raw)
  To: devel; +Cc: Pierre Gondois, leif, ard.biesheuvel, nd

From: Pierre Gondois <pierre.gondois@arm.com>

While building with the following command line:
build -b DEBUG -a AARCH64 -t VS2017 -p
edk2\MdeModulePkg\MdeModulePkg.dsc

A missing cast triggers the following warning,
then triggering an error:
edk2/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c(652):
warning C4152: nonstandard extension, function/data pointer
conversion in expression

This patch adds a cast, removing the warning.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---

The changes can be seen at: https://github.com/PierreARM/edk2/commits/831_Fix_implicit_cast_v1

Notes:
    v1:
     - Add (void*) cast. [Pierre]

 ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
index 222ff817956feb738325fc78fbaf064de98802a9..7df7c75d4a571403209e4fee0f0a06ed6e3513fa 100644
--- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
+++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
@@ -649,7 +649,7 @@ ArmMmuBaseLibConstructor (
   // The ArmReplaceLiveTranslationEntry () helper function may be invoked
   // with the MMU off so we have to ensure that it gets cleaned to the PoC
   //
-  WriteBackDataCacheRange (ArmReplaceLiveTranslationEntry,
+  WriteBackDataCacheRange ((VOID*)ArmReplaceLiveTranslationEntry,
     ArmReplaceLiveTranslationEntrySize);
 
   return RETURN_SUCCESS;
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-25 10:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-25  7:59 [PATCH v1 1/1] ArmPkg/ArmMmuLibb: Fix implicit cast PierreGondois
2020-06-25 10:10 ` [edk2-devel] " Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox