public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ge Song <songgebird@gmail.com>, edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v1 1/1] OvmfPkg/SecMain: Fix stack switching to permanent memory fail
Date: Tue, 5 Sep 2017 00:26:02 +0200	[thread overview]
Message-ID: <2f4ecb4a-ea33-a1c5-b52c-786483659be4@redhat.com> (raw)
In-Reply-To: <8cf35d7b-9c1c-e1a8-5896-ca709e57fef6@redhat.com>

On 09/03/17 22:49, Laszlo Ersek wrote:

> I'll do some testing in the next few days.

Attempted to do it now, but the patch doesn't apply. I tried both

  git am --keep-cr ...

and

  git am --no-keep-cr ...

However, I managed to fetch the patch from the branch noted in the blurb.

I tested the patch with normal boot and S3 resume:
- IA32 build, Q35, SMM
- IA32X64 build, Q35, SMM
- X64 build, i440fx, no SMM

Experienced no regressions. Please add the following to your v2:

Tested-by: Laszlo Ersek <lersek@redhat.com>

Also, contingent upon the requested updates to the commit message:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Jordan, could you please push Ge Song's upcoming v2, if you are
satisfied with it?

Thanks,
Laszlo


  parent reply	other threads:[~2017-09-04 22:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-03  2:12 [PATCH v1 0/1] Fix stack switching to permanent memory fail Ge Song
2017-09-03  2:12 ` [PATCH v1 1/1] OvmfPkg/SecMain: " Ge Song
2017-09-03  4:37   ` Jordan Justen
2017-09-03 20:50     ` Laszlo Ersek
2017-09-03 20:49   ` Laszlo Ersek
2017-09-04  8:54     ` Ge Song
2017-09-04 22:26     ` Laszlo Ersek [this message]
2017-09-03 20:52   ` Laszlo Ersek
2017-09-03 20:55   ` Laszlo Ersek
2017-09-04 13:34     ` Jordan Justen
2017-09-04 15:11       ` Ge Song
2017-09-04 21:25         ` Laszlo Ersek
2017-09-05 17:45           ` Jordan Justen
2017-09-05 18:03             ` Leif Lindholm
2017-09-07  1:42               ` Songge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f4ecb4a-ea33-a1c5-b52c-786483659be4@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox