From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web12.3110.1654545320514990643
 for <devel@edk2.groups.io>;
 Mon, 06 Jun 2022 12:55:20 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=Wo1JTLrI;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.195.228.134])
	by linux.microsoft.com (Postfix) with ESMTPSA id 5D0B020BE61B;
	Mon,  6 Jun 2022 12:55:19 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5D0B020BE61B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1654545319;
	bh=KF1fQhWn3t9H1QmKrfeNkLbVKtcmAWPB5KHxAnQhvYo=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=Wo1JTLrIctcKgKUV59pPigVuCNrUimny4CM6FdTGVP4DFhQE+8UnQ74hf7wi+8hMz
	 UzrUNEdIJR7y6i6Chhs2rYG7GBcEgi8QVW+PdpIQ/KrpTuVO8aOxLfAlm98SWOq1vW
	 AjcJflDttKaRDUZhEC7L9oI5KQpp0WExhbfFo2aA=
Message-ID: <2f53b54d-4bac-1348-ab80-6e3b79891bd2@linux.microsoft.com>
Date: Mon, 6 Jun 2022 15:55:18 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH V1 1/1] .pytool: UncrustifyCheck: Set IgnoreFiles path relative to package path
To: Kun Qin <kuqin12@gmail.com>, devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
 Bret Barkelew <Bret.Barkelew@microsoft.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <gaoliming@byosoft.com.cn>
References: <20220606195254.348-1-kuqin12@gmail.com>
 <20220606195254.348-2-kuqin12@gmail.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20220606195254.348-2-kuqin12@gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 6/6/2022 3:52 PM, Kun Qin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3942
> 
> `IgnoreFiles` tag is specified in the CI YAML files in each individual
> packages. The current logic for UncrustifyCheck script bases specified
> file paths from workspace, which requires the package name to be included
> in each entry.
> 
> This change updates the ignore checking logic to be based on current
> package path in order to reduce redundancy. It also keeps the consistency
> of `IgnoreFiles` field other pytools such as SpellCheck and EccCheck.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> index 00d78864656f..8dc9ffe6945a 100644
> --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> @@ -290,7 +290,7 @@ class UncrustifyCheck(ICiBuildPlugin):
>           # This information is only used for reporting (not used here) and
>           # the ignore lines are being passed directly as they are given to
>           # this plugin.
> -        return parse_gitignore_lines(ignored_files, "Package configuration file", self._abs_workspace_path)
> +        return parse_gitignore_lines(ignored_files, "Package configuration file", self._abs_package_path)
>   
>       def _get_git_ignored_paths(self) -> List[str]:
>           """"