From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.6600.1606310829087479345 for ; Wed, 25 Nov 2020 05:27:09 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B0C9531B; Wed, 25 Nov 2020 05:27:08 -0800 (PST) Received: from [192.168.1.81] (unknown [10.37.8.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 301A73F70D; Wed, 25 Nov 2020 05:27:08 -0800 (PST) Subject: Re: [PATCH edk2-platforms 14/15] Platform/SocioNext: add VariablePolicy resolutions To: Leif Lindholm Cc: devel@edk2.groups.io References: <20201125125559.11631-1-leif@nuviainc.com> <20201125125559.11631-15-leif@nuviainc.com> <5b19eff6-6408-fb5a-7017-e94db9cfeb4a@arm.com> <20201125131645.GR1664@vanye> From: "Ard Biesheuvel" Message-ID: <2f6a4a2b-ddd3-c9b4-afa6-45d7527cb351@arm.com> Date: Wed, 25 Nov 2020 14:27:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201125131645.GR1664@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/25/20 2:16 PM, Leif Lindholm wrote: > On Wed, Nov 25, 2020 at 14:11:00 +0100, Ard Biesheuvel wrote: >> On 11/25/20 1:55 PM, Leif Lindholm wrote: >>> Add resolutions for >>> - VariablePolicyLib >>> - VariablePolicyHelperLib >>> - VariablePolicyLib (DXE_RUNTIME_DRIVER) >>> to DeveloperBox platform. >>> >>> Cc: Ard Biesheuvel >>> Signed-off-by: Leif Lindholm >> >> Does this unbreak the build of DeveloperBoxMm.dsc as well? > > No. I was unsure of that being pretty much our reference for secure > variable handling, just cargo culting a fix in place was the correct > course of action. > >> If not, we should >> probably drop some of these into the .dsc.in file instead. > > Unless the above is an issue, sure. > I double checked, and Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc is indeed broken as well, and it needs resolutions of both VariablePolicyLib and VariablePolicyHelperLib. So adding those to [LibraryClasses] in Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc instead of elsewhere is probably the best approach here. With that, Acked-by: Ard Biesheuvel