public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, vnowkakeane@linux.microsoft.com
Subject: Re: [edk2-devel] [PATCH v1 1/7] .pytool: Set uncrustify check to audit only
Date: Mon, 14 Aug 2023 21:06:02 -0400	[thread overview]
Message-ID: <2f7eda78-60ef-7e1e-bb71-84923a506626@linux.microsoft.com> (raw)
In-Reply-To: <20230809213226.1387-2-vnowkakeane@linux.microsoft.com>

Was this meant to be included in the series? We wouldn't want audit only 
mode always enabled.

On 8/9/2023 5:32 PM, VivianNK wrote:
> Temporarily set uncrustify to audit only to prevent build failures.
> 
> CC: Sean Brogan <sean.brogan@microsoft.com>
> CC: Michael Kubacki <mikuback@linux.microsoft.com>
> CC: Michael D Kinney <michael.d.kinney@intel.com>
> CC: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
> ---
>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> index 8dc9ffe6945a..8978ffc443bf 100644
> --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> @@ -530,7 +530,7 @@ class UncrustifyCheck(ICiBuildPlugin):
>           """
> 
>           Initializes options that influence test case output.
> 
>           """
> 
> -        self._audit_only_mode = False
> 
> +        self._audit_only_mode = True
> 
>           self._output_file_diffs = True
> 
>   
> 
>           if "AuditOnly" in self._package_config and self._package_config["AuditOnly"]:
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107751): https://edk2.groups.io/g/devel/message/107751
Mute This Topic: https://groups.io/mt/100655290/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-08-15  1:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 21:32 [edk2-devel] [PATCH v1 0/7] Uncrustify GoogleTest update VivianNK
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 1/7] .pytool: Set uncrustify check to audit only VivianNK
2023-08-15  1:06   ` Michael Kubacki [this message]
     [not found]   ` <177B69072E52D32F.12117@groups.io>
2023-08-15  1:22     ` Michael Kubacki
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 2/7] .pytool: Add cpp support to uncrustify plugin VivianNK
2023-08-15  1:22   ` Michael Kubacki
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 3/7] MdeModulePkg: Applyy uncrustify formatting to relevant files VivianNK
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 4/7] MdePkg: Apply " VivianNK
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 5/7] SecurityPkg: " VivianNK
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 6/7] UnitTestFrameworkPkg: " VivianNK
2023-08-10 19:25   ` Michael D Kinney
2023-08-15  1:22   ` Michael Kubacki
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 7/7] .pytool: Undo uncrustify check change VivianNK
2023-08-15  1:28   ` Michael Kubacki
2023-08-15  1:32 ` [edk2-devel] [PATCH v1 0/7] Uncrustify GoogleTest update Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f7eda78-60ef-7e1e-bb71-84923a506626@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox