From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5F0EB940A10 for ; Tue, 15 Aug 2023 01:06:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0eGJBoXaBC1FaHOVGVhbP5vTTRGuCvbKtR1eOr7uRG8=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692061565; v=1; b=mlA+MNRbF+JScbCOFYz1n/S3RTIkoXR5iJbp5HqYvH+fR/C8vrkMZewFcQvg+SYC3RCY4jgk CJXUurBhIpbM0bklzkxGbj/OtKUkbnDVHGI8DHm11t0u2ulK9PRRn25AEweu+pwmc3A6i+PWJMM ApAu8hyvpsGR/7Pn+gF26WJw= X-Received: by 127.0.0.2 with SMTP id RadOYY7687511xI7cALWx6MB; Mon, 14 Aug 2023 18:06:05 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.124217.1692061564396836900 for ; Mon, 14 Aug 2023 18:06:04 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id A11142109449; Mon, 14 Aug 2023 18:06:03 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A11142109449 Message-ID: <2f7eda78-60ef-7e1e-bb71-84923a506626@linux.microsoft.com> Date: Mon, 14 Aug 2023 21:06:02 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/7] .pytool: Set uncrustify check to audit only To: devel@edk2.groups.io, vnowkakeane@linux.microsoft.com References: <20230809213226.1387-1-vnowkakeane@linux.microsoft.com> <20230809213226.1387-2-vnowkakeane@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: <20230809213226.1387-2-vnowkakeane@linux.microsoft.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Orzjcmod8yuYlmLO1eqr89h5x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mlA+MNRb; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Was this meant to be included in the series? We wouldn't want audit only=20 mode always enabled. On 8/9/2023 5:32 PM, VivianNK wrote: > Temporarily set uncrustify to audit only to prevent build failures. >=20 > CC: Sean Brogan > CC: Michael Kubacki > CC: Michael D Kinney > CC: Liming Gao > Signed-off-by: Vivian Nowka-Keane > --- > .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/= Plugin/UncrustifyCheck/UncrustifyCheck.py > index 8dc9ffe6945a..8978ffc443bf 100644 > --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > @@ -530,7 +530,7 @@ class UncrustifyCheck(ICiBuildPlugin): > """ >=20 > Initializes options that influence test case output. >=20 > """ >=20 > - self._audit_only_mode =3D False >=20 > + self._audit_only_mode =3D True >=20 > self._output_file_diffs =3D True >=20 > =20 >=20 > if "AuditOnly" in self._package_config and self._package_config= ["AuditOnly"]: >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107751): https://edk2.groups.io/g/devel/message/107751 Mute This Topic: https://groups.io/mt/100655290/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-