Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary

["Boeuf, Sebastien" <sebastien.boeuf@intel.com>]

On Fri, 2022-02-25 at 10:29 +0100, kraxel@redhat.com wrote:
>   Hi,
> 
> > > Hmm, VarStore.fdf.inc reduces duplication, and now you revert
> > > this.
> > > Maybe add this to VarStore.fdf.inc instead, and add a
> > > PVH_HEADER_ENABLE
> > > option to turn it on and off?
> > 
> > It's quite hard to use VarStore.fdf.inc since I would need to
> > replace
> > only the first DATA section. And I can't include something specific
> > like OvmfPkg/CloudHv/CloudHvElfHeader.fdf.inc inside
> > VarStore.fdf.inc.
> > Should I create something like
> > OvmfPkg/CloudHv/CloudHvVarStore.fdf.inc
> > so that it makes sense to include
> > OvmfPkg/CloudHv/CloudHvElfHeader.fdf.inc based on a
> > PVH_HEADER_ENABLE
> > variable?
> 
> Yes, that was the idea, only include the file in case
> PVH_HEADER_ENABLE=TRUE.  Maybe name it "PVH_HEADER_CLOUDHW" so the
> xen
> guys can add PVH_HEADER_XEN variable for the simliar but not
> identical
> xen case.

I took care of it on the 4th patch through the v4 I've just sent. Let
me know if that's what you were expecting.

Thanks,
Seb

> 
> take care,
>   Gerd
> 

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.