From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (NAM04-SN1-obe.outbound.protection.outlook.com [40.107.70.80]) by mx.groups.io with SMTP id smtpd.web11.58159.1595863856067914276 for ; Mon, 27 Jul 2020 08:30:56 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=HvuRnu2y; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.70.80, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UV2hvQW52yKgYkOm2uNIt5JEuEi/N751DEARfyBi9z0bLLqQO6i6xN9Jo/TXFTFncbjuxdZHtF28WMycUOKMGfwIPkpilynfJxTjP77HecbIcMXYmFF8U3e1Zym0Nf9ZvAmGskL51gR3MFx9MWln0w5c7ROR+B1d3IEI3dH8RwXjeKb/3M2ESk8xGqdD0l2PRfayuC6iymFQzX0kbg4GDkn5uxca05WEJPqQ57f8nGHAlF4nvRctoAIDPGa3816MlTRCqm89wf2SuEI8khUQ2PFqBE7ohDsJWv/WBcfQwkZAQeS/rX082lfslGoQNnzDS3hEOlj6yjtd5fEidCSNWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKE7+qHjsZIcvRUcMZufAvxligKtvF8CIKEGq/A8VMQ=; b=MQK6LEXiki6BpyNU0n8vUQtuVGEbJGtQOdnKC0QcW4h4gcrub9DeA78ahyhSZQVG0C+UtvHQxhD1Y63ADycd8n0b5Sx7RSi8nGTFuOMtrWbpOb+gweUn8vkHnmmWWGldlBfCWOlDy7u+u+R897VW9tqkbdtmqdr937y7w22d3gp8I9Uk37kRRB0RAqiQVqQ7UvRn455v5qOTg6kVkiMQEGDxz6sAj3smnYY3UxoLX4kMTCIKnAv8BSpA/u95vH+G0379ZaoCD8YsOkW066GlNcQgggkVEmwaD0LK0KurLDdLDLb6Ungesfsn1ZAmMDdoXyYVaXk8+A5eni8x/JFGgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKE7+qHjsZIcvRUcMZufAvxligKtvF8CIKEGq/A8VMQ=; b=HvuRnu2yVgItnPASvciQxu5OHxS6wl1mq3s7kf7hup4ygYP943xgmy9dlfSS4AwyIEuPmxdKxVFwiY+y5Zkh0be8lUUjCMPEuVbNq2poWUs/pJrXCNYuvCaUJQ1VTcK9bPcK58Ewj4cQx/CSj2RbmJ1xUDMiMtObrTeS1dImff4= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR12MB1163.namprd12.prod.outlook.com (2603:10b6:3:7a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.25; Mon, 27 Jul 2020 15:30:54 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0%8]) with mapi id 15.20.3216.031; Mon, 27 Jul 2020 15:30:54 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io CC: Brijesh Singh , Ard Biesheuvel , Eric Dong , Jordan Justen , Laszlo Ersek , Liming Gao , Michael D Kinney , Ray Ni Subject: [PATCH v12 32/46] OvmfPkg/PlatformPei: Move early GDT into ram when SEV-ES is enabled Date: Mon, 27 Jul 2020 10:26:13 -0500 Message-ID: <2fa7386ea5277a5c0a833d5af240ac1b889f3884.1595863587.git.thomas.lendacky@amd.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: X-ClientProxiedBy: SN4PR0501CA0039.namprd05.prod.outlook.com (2603:10b6:803:41::16) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tlendack-t1.amd.com (165.204.77.1) by SN4PR0501CA0039.namprd05.prod.outlook.com (2603:10b6:803:41::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.9 via Frontend Transport; Mon, 27 Jul 2020 15:30:53 +0000 X-Mailer: git-send-email 2.27.0 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5beea4f8-e9a5-430d-01b3-08d832420d50 X-MS-TrafficTypeDiagnostic: DM5PR12MB1163: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fIQxhrc8hMtdWeHu6DucogxregEiZhaEMJw3+v65wDjRAxQl4R5yTtFCmsAufo0tXQfFtKsQX7jW3YSyigVfqy9aAdGULzLzKg6kvFWSvPe9Z9IMXAgSZooyhgyUk0HBW/jwjfZAHDwFJItlkErM4xgdFaFsaf0xKZw5Nulk6bCZwNleHFD0bkh+F2zzLfiPta10xOoEXQNDUf8sb8i2AUuczwbJFtgbu8aPnNUA8o7GNsu7RX2kJsrbLdmCP4usbnyVOt/g8hEZWVXXN6VEEEZVfR+xb3/PwgYKrIZbz2dQDZHB6JXje92J/hX6zDw4zdUJqTRc21yhYOnayNSs1hP1cHjgs7MzP1G+kjrd5CwpD08T+nomSe+CMZdw41tDbswAAo+6iJkfRogUMzMPB5etnMe0xF9GsgA3SoPdp3I/GVUEu50TQhfIhL8t2HsWgVa7HuyBp2UVfe2XgrBSwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(26005)(7696005)(16526019)(52116002)(186003)(66946007)(2616005)(66556008)(316002)(36756003)(956004)(966005)(5660300002)(66476007)(54906003)(6666004)(478600001)(2906002)(4326008)(6486002)(8676002)(8936002)(6916009)(83380400001)(86362001)(136400200001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: N3iuoC0c3buBF0H/uU2SNM005In4MpBUU1LExAjCfOlce0DUAg271Y5e0rssMG/dSYRUAjisoNgJaa7NA0Rd7/lHwEw1E3ANZtDl+rIJZ3XlTkPRsxGPugBxQTfKazQoLM1jAttg7eZjrx1Yri2Ow979Qk4FAJ8u4VthuQr4aAQPr5wPYDkunXKps4mqhUIJCxK15bgZ5yIuTHURAhOVpqiGL5BLBDMOYKBVNd5xiLqjeivjYX3QA9smsIhgd633ZSvLEhEmYubt4kcHaBgG1Ttns9PZlVI3De7F/LEl3AfznWU5grgH9WgKNuPvF8Thk1kfUdjhLoxVYsNyYjz1ce6q6KoK37m+U0gMAayaMbY0MbV7i9YYsnlC1ADw31BUt9mTd2g//On+/gK9KrJ+DslQW+AeV+20QLn1j4hDUzRth73MWdlGpP07X2UYQfLLfDO/cE6QLwNkUqole7QvMMHNDgPKztb1FsBWgRlnRes= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5beea4f8-e9a5-430d-01b3-08d832420d50 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2020 15:30:54.7051 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vuExVB6TUNrmDSt/ayoLElFIHbK19+of+e68p7J0LO6tOWfAYbrQesq5xSU5tB5ZLFPnvOkVVyq1v4YmwsVPXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1163 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 The SEV support will clear the C-bit from non-RAM areas. The early GDT lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT will be read as un-encrypted even though it is encrypted. This will result in a failure to be able to handle the exception. Move the GDT into RAM so it can be accessed without error when running as an SEV-ES guest. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/PlatformPei/AmdSev.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c index 4fd4534cabea..a2b38c591236 100644 --- a/OvmfPkg/PlatformPei/AmdSev.c +++ b/OvmfPkg/PlatformPei/AmdSev.c @@ -39,6 +39,8 @@ AmdSevEsInitialize ( PHYSICAL_ADDRESS GhcbBasePa; UINTN GhcbPageCount, PageCount; RETURN_STATUS PcdStatus, DecryptStatus; + IA32_DESCRIPTOR Gdtr; + VOID *Gdt; =20 if (!MemEncryptSevEsIsEnabled ()) { return; @@ -83,6 +85,22 @@ AmdSevEsInitialize ( (UINT64)GhcbPageCount, GhcbBase)); =20 AsmWriteMsr64 (MSR_SEV_ES_GHCB, GhcbBasePa); + + // + // The SEV support will clear the C-bit from non-RAM areas. The early G= DT + // lives in a non-RAM area, so when an exception occurs (like a #VC) the= GDT + // will be read as un-encrypted even though it was created before the C-= bit + // was cleared (encrypted). This will result in a failure to be able to + // handle the exception. + // + AsmReadGdtr (&Gdtr); + + Gdt =3D AllocatePages (EFI_SIZE_TO_PAGES ((UINTN) Gdtr.Limit + 1)); + ASSERT (Gdt !=3D NULL); + + CopyMem (Gdt, (VOID *) Gdtr.Base, Gdtr.Limit + 1); + Gdtr.Base =3D (UINTN) Gdt; + AsmWriteGdtr (&Gdtr); } =20 /** --=20 2.27.0