From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mx.groups.io with SMTP id smtpd.web09.17808.1605151272572487737 for ; Wed, 11 Nov 2020 19:21:13 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.32, mailfrom: cenjiahui@huawei.com) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CWn1P49rYzhjDH; Thu, 12 Nov 2020 11:20:57 +0800 (CST) Received: from [10.174.184.155] (10.174.184.155) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Thu, 12 Nov 2020 11:20:56 +0800 Subject: Re: [edk2-devel] [PATCH v2 0/4] Add extra pci roots support for Arm To: , CC: , , , , References: <20201109130511.5946-1-cenjiahui@huawei.com> From: "Jiahui Cen" Message-ID: <2fc09c79-f430-c5a4-5aa4-0db5a7a27b42@huawei.com> Date: Thu, 12 Nov 2020 11:20:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.184.155] X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Laszlo, On 2020/11/11 22:33, Laszlo Ersek wrote: > On 11/09/20 14:05, Jiahui Cen wrote: >> Changes with v1 >> v1->v2: >> Separated into four patches. >> Factor the same logic parts into a new library. >> >> v1: https://edk2.groups.io/g/devel/topic/72723351#56901 >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > (1) Each commit message in the series should reference this bugzilla. > > But, in itself, that's no reason for a repost; such an update can be > made by maintainers when they merge the series. Will add it. > > (2) This is a feature addition, so it's merge material for the next > development cycle > . > (Also it depends on the QEMU work being merged first.) I'm going to > proceed with the review now. Thanks for the material. I'll keep on developing it and the QEMU work. Jiahui > > Thanks, > Laszlo > >> QEMU: https://lore.kernel.org/qemu-devel/20201103120157.2286-1-cenjiahui@huawei.com/ >> >> This patch series adds support for extra pci roots for ARM. >> >> In order to avoid duplicated codes, we introduce a new library >> PciHostBridgeUtilityLib which extracts common interfaces from >> OvmfPkg/PciHostBridgeLib. It provides conflicts informing and extra pci >> roots scanning. Using the utility lib, the uefi could scan for extra >> root buses and recognize multiple roots for ARM. >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Leif Lindholm >> Signed-off-by: Yubo Miao >> Signed-off-by: Jiahui Cen >> >> Yubo Miao (4): >> OvmfPkg: Extract functions form PciHostBridgeLib >> ArmVirtPkg: Use extracted PciHostBridgeUtilityLib >> OvmfPkg: Extract functions of extra pci roots >> ArmVirtPkg: Support extra pci roots >> >> ArmVirtPkg/ArmVirt.dsc.inc | 1 + >> OvmfPkg/OvmfPkgIa32.dsc | 1 + >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + >> OvmfPkg/OvmfPkgX64.dsc | 1 + >> OvmfPkg/OvmfXen.dsc | 1 + >> ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf | 5 + >> OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + >> OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf | 51 ++++ >> OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h | 98 +++++++ >> ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 221 ++++++++------- >> OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 234 +--------------- >> OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c | 283 ++++++++++++++++++++ >> 12 files changed, 563 insertions(+), 335 deletions(-) >> create mode 100644 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf >> create mode 100644 OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h >> create mode 100644 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c >> > > > > > > > . >