From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 72198AC12D7 for ; Mon, 25 Dec 2023 15:28:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JGxkZ3n1KDXFhT8ivoACGK9a93OmJ+dKIYiXabG/Mbo=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1703518094; v=1; b=XKKThiLiyR+ymNmdLAL87lgpx8aI/tgFj1cvM722OGAZ6dq2BlM9B7ic+beLCkjW3sh+nsMp OCMrAOvvxOocRznUWl4BRSVrQjnV0/QqUh2QNYG2WwaqybQYveFQVX/NK2l3ChrIXYgn7aDfxcW /ekhEyDpiwEte2Th9z+Z5mnY= X-Received: by 127.0.0.2 with SMTP id T5ZuYY7687511xqRPZ3Xdhso; Mon, 25 Dec 2023 07:28:14 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web10.61327.1703518093960816663 for ; Mon, 25 Dec 2023 07:28:14 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="9819480" X-IronPort-AV: E=Sophos;i="6.04,303,1695711600"; d="scan'208";a="9819480" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2023 07:28:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="753958276" X-IronPort-AV: E=Sophos;i="6.04,303,1695711600"; d="scan'208";a="753958276" X-Received: from ashrafal-mobl4.gar.corp.intel.com ([10.213.112.137]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2023 07:28:09 -0800 From: "Ashraf Ali S" To: devel@edk2.groups.io Cc: Ashraf Ali S , Yuwei Chen , Rebecca Cran , Liming Gao , Bob Feng , Amy Chan , Sai Chaganty Subject: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Date: Mon, 25 Dec 2023 20:57:52 +0530 Message-Id: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: cDy64Cgm2YLNeP3FKuBgxqn2x7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XKKThiLi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Currently when the platform has many SKUs then allskuset will be having so many duplicate. and while parsing the allskuset will take longer time while assing Pcd.SkuInfoList. This patch is to eliminate those duplicate entires to reduce the build time Cc: Yuwei Chen Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Amy Chan Cc: Sai Chaganty Signed-off-by: Ashraf Ali S --- BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py index 592d4824a4..dac81454a9 100644 --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): self._DynamicPcdList.extend(list(OtherPcdArray)) self._DynamicPcdList.sort() allskuset = [(SkuName, Sku.SkuId) for pcd in self._DynamicPcdList for (SkuName, Sku) in pcd.SkuInfoList.items()] + # Remove duplicate sets in the list + allskuset = list(set(allskuset)) for pcd in self._DynamicPcdList: if len(pcd.SkuInfoList) == 1: for (SkuName, SkuId) in allskuset: -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112884): https://edk2.groups.io/g/devel/message/112884 Mute This Topic: https://groups.io/mt/103360241/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-