* [edk2-platform][PATCH v1 0/2] Platforms/RaspberryPi: Fix RngLib build error
@ 2020-09-26 14:52 Samer El-Haj-Mahmoud
2020-09-26 14:52 ` [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 " Samer El-Haj-Mahmoud
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-09-26 14:52 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Pete Batard, Andrei Warkentin
Commit b5701a4c7a0fb185e0c5b9db9525939c78664bfd introduced RngLib
dependency for OpensslLib, and caused the RPi build to break for lack
of an RngLib instance.
This series adds RngLib to both RPi3 and RPi4 using the DxeRngLib flavor,
which is a wrapper around the the EFI_RNG_PROTOCOL that the platform
already produces.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Samer El-Haj-Mahmoud (2):
Platforms/RaspberryPi: Fix RPi4 RngLib build error
Platforms/RaspberryPi: Fix RPi3 RngLib build error
Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
2 files changed, 2 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 RngLib build error
2020-09-26 14:52 [edk2-platform][PATCH v1 0/2] Platforms/RaspberryPi: Fix RngLib build error Samer El-Haj-Mahmoud
@ 2020-09-26 14:52 ` Samer El-Haj-Mahmoud
2020-09-27 3:58 ` Andrei Warkentin
2020-09-26 14:52 ` [edk2-platform][PATCH v1 2/2] Platforms/RaspberryPi: Fix RPi3 " Samer El-Haj-Mahmoud
2020-09-27 9:57 ` [edk2-platform][PATCH v1 0/2] Platforms/RaspberryPi: Fix " Ard Biesheuvel
2 siblings, 1 reply; 6+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-09-26 14:52 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Pete Batard, Andrei Warkentin
Commit b5701a4c7a0fb185e0c5b9db9525939c78664bfd introduced RngLib
dependency for OpensslLib, and caused the RPi build to break for lack
of an RngLib instance.
This patch adds RngLib using the DxeRngLib flavor, which is a wrapper
around the the EFI_RNG_PROTOCOL that the platform already produces.
Tested booting OSes and running the SCT test for EFI_RNG_PROTOCOL.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index 823c9fc007d4..c994f56d658d 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -130,6 +130,7 @@ [LibraryClasses.common]
SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DebugDualSerialPortLib.inf
# Cryptographic libraries
+ RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [edk2-platform][PATCH v1 2/2] Platforms/RaspberryPi: Fix RPi3 RngLib build error
2020-09-26 14:52 [edk2-platform][PATCH v1 0/2] Platforms/RaspberryPi: Fix RngLib build error Samer El-Haj-Mahmoud
2020-09-26 14:52 ` [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 " Samer El-Haj-Mahmoud
@ 2020-09-26 14:52 ` Samer El-Haj-Mahmoud
2020-09-27 3:58 ` Andrei Warkentin
2020-09-27 9:57 ` [edk2-platform][PATCH v1 0/2] Platforms/RaspberryPi: Fix " Ard Biesheuvel
2 siblings, 1 reply; 6+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-09-26 14:52 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Pete Batard, Andrei Warkentin
Commit b5701a4c7a0fb185e0c5b9db9525939c78664bfd introduced RngLib
dependency for OpensslLib, and caused the RPi build to break for lack
of an RngLib instance.
This patch adds RngLib using the DxeRngLib flavor, which is a wrapper
around the the EFI_RNG_PROTOCOL that the platform already produces.
Build tested only.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 484a46ffba87..325d7bdb7269 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -130,6 +130,7 @@ [LibraryClasses.common]
SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DebugDualSerialPortLib.inf
# Cryptographic libraries
+ RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 RngLib build error
2020-09-26 14:52 ` [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 " Samer El-Haj-Mahmoud
@ 2020-09-27 3:58 ` Andrei Warkentin
0 siblings, 0 replies; 6+ messages in thread
From: Andrei Warkentin @ 2020-09-27 3:58 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud, devel@edk2.groups.io
Cc: Leif Lindholm, Ard Biesheuvel, Pete Batard
[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
________________________________
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sent: Saturday, September 26, 2020 9:52 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Pete Batard <pete@akeo.ie>; Andrei Warkentin <awarkentin@vmware.com>
Subject: [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 RngLib build error
Commit b5701a4c7a0fb185e0c5b9db9525939c78664bfd introduced RngLib
dependency for OpensslLib, and caused the RPi build to break for lack
of an RngLib instance.
This patch adds RngLib using the DxeRngLib flavor, which is a wrapper
around the the EFI_RNG_PROTOCOL that the platform already produces.
Tested booting OSes and running the SCT test for EFI_RNG_PROTOCOL.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index 823c9fc007d4..c994f56d658d 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -130,6 +130,7 @@ [LibraryClasses.common]
SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DebugDualSerialPortLib.inf
# Cryptographic libraries
+ RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 2778 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-platform][PATCH v1 2/2] Platforms/RaspberryPi: Fix RPi3 RngLib build error
2020-09-26 14:52 ` [edk2-platform][PATCH v1 2/2] Platforms/RaspberryPi: Fix RPi3 " Samer El-Haj-Mahmoud
@ 2020-09-27 3:58 ` Andrei Warkentin
0 siblings, 0 replies; 6+ messages in thread
From: Andrei Warkentin @ 2020-09-27 3:58 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud, devel@edk2.groups.io
Cc: Leif Lindholm, Ard Biesheuvel, Pete Batard
[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
________________________________
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sent: Saturday, September 26, 2020 9:52 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Pete Batard <pete@akeo.ie>; Andrei Warkentin <awarkentin@vmware.com>
Subject: [edk2-platform][PATCH v1 2/2] Platforms/RaspberryPi: Fix RPi3 RngLib build error
Commit b5701a4c7a0fb185e0c5b9db9525939c78664bfd introduced RngLib
dependency for OpensslLib, and caused the RPi build to break for lack
of an RngLib instance.
This patch adds RngLib using the DxeRngLib flavor, which is a wrapper
around the the EFI_RNG_PROTOCOL that the platform already produces.
Build tested only.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 484a46ffba87..325d7bdb7269 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -130,6 +130,7 @@ [LibraryClasses.common]
SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DebugDualSerialPortLib.inf
# Cryptographic libraries
+ RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 2778 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-platform][PATCH v1 0/2] Platforms/RaspberryPi: Fix RngLib build error
2020-09-26 14:52 [edk2-platform][PATCH v1 0/2] Platforms/RaspberryPi: Fix RngLib build error Samer El-Haj-Mahmoud
2020-09-26 14:52 ` [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 " Samer El-Haj-Mahmoud
2020-09-26 14:52 ` [edk2-platform][PATCH v1 2/2] Platforms/RaspberryPi: Fix RPi3 " Samer El-Haj-Mahmoud
@ 2020-09-27 9:57 ` Ard Biesheuvel
2 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2020-09-27 9:57 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud, devel; +Cc: Leif Lindholm, Pete Batard, Andrei Warkentin
On 9/26/20 4:52 PM, Samer El-Haj-Mahmoud wrote:
> Commit b5701a4c7a0fb185e0c5b9db9525939c78664bfd introduced RngLib
> dependency for OpensslLib, and caused the RPi build to break for lack
> of an RngLib instance.
>
> This series adds RngLib to both RPi3 and RPi4 using the DxeRngLib flavor,
> which is a wrapper around the the EFI_RNG_PROTOCOL that the platform
> already produces.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
>
> Samer El-Haj-Mahmoud (2):
> Platforms/RaspberryPi: Fix RPi4 RngLib build error
> Platforms/RaspberryPi: Fix RPi3 RngLib build error
>
Pushed as 4efd9ab2cfab..1e09147a01ae
Thanks all,
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-27 9:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-26 14:52 [edk2-platform][PATCH v1 0/2] Platforms/RaspberryPi: Fix RngLib build error Samer El-Haj-Mahmoud
2020-09-26 14:52 ` [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 " Samer El-Haj-Mahmoud
2020-09-27 3:58 ` Andrei Warkentin
2020-09-26 14:52 ` [edk2-platform][PATCH v1 2/2] Platforms/RaspberryPi: Fix RPi3 " Samer El-Haj-Mahmoud
2020-09-27 3:58 ` Andrei Warkentin
2020-09-27 9:57 ` [edk2-platform][PATCH v1 0/2] Platforms/RaspberryPi: Fix " Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox