public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: xueshengfeng <xueshengfeng@byosoft.com.cn>
To: devel@edk2.groups.io, ray.ni@intel.com, zhichao.gao@intel.com
Cc: gaoliming@byosoft.com.cn, Shengfengx Xue <shengfengx.xue@intel.com>
Subject: [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17.
Date: Sat,  6 Aug 2022 10:02:13 +0800	[thread overview]
Message-ID: <2fcf297e06328cd25e92756b7fd13ed39cb9231b.1659749541.git.shengfengx.xue@intel.com> (raw)

From: Shengfengx Xue <shengfengx.xue@intel.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4014

if Configured Memory Speed is 65,535 MT/s or greater,
and the actual speed is stored in the Extended Configured Memory Speed
field. but current Smbiosview have no this logic.

Signed-off-by: Shengfengx Xue <shengfengx.xue@intel.com>
---
 .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c        | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index a0ee286c9a..0ab9f5063a 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -878,6 +878,11 @@ SmbiosPrintStructure (
         }
       }
 
+      if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)) {
+        PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed);
+        PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedConfiguredMemorySpeed);
+      }
+
       break;
 
     //
-- 
2.26.2.windows.1



             reply	other threads:[~2022-08-06  2:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-06  2:02 xueshengfeng [this message]
2022-08-09  9:57 ` [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17 Gao, Zhichao
     [not found] ` <1709A4B7A944DF88.7247@groups.io>
2022-08-15  1:46   ` [edk2-devel] " Gao, Zhichao
2022-08-15  1:53     ` Xue, ShengfengX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fcf297e06328cd25e92756b7fd13ed39cb9231b.1659749541.git.shengfengx.xue@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox