From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC1C8211C3F61 for ; Thu, 7 Feb 2019 11:45:31 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0FAA888E5A; Thu, 7 Feb 2019 19:45:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-246.rdu2.redhat.com [10.10.121.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07F7CAF565; Thu, 7 Feb 2019 19:45:27 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Ryszard Knop , edk2-devel@lists.01.org References: <280bb5d0-e01c-022e-6a02-6b744f61f28d@redhat.com> <2bf54b577aeef2a5529b3880d4d74e361f8a2089.camel@linux.intel.com> <385afbeb-98a5-a15d-62ac-d720b4c72b51@redhat.com> From: Laszlo Ersek Message-ID: <2fcfd7d2-cd57-71f4-f0ec-4ee1a197e3c3@redhat.com> Date: Thu, 7 Feb 2019 20:45:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <385afbeb-98a5-a15d-62ac-d720b4c72b51@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 07 Feb 2019 19:45:31 +0000 (UTC) Subject: Re: [PATCH] CryptoPkg: Fix various typos X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 19:45:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02/07/19 15:59, Philippe Mathieu-Daudé wrote: > On 2/7/19 2:04 PM, Ryszard Knop wrote: >> Hi Philippe, Antoine, >> >> On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote: >>> Hi Antoine, >>> >>> On 2/6/19 6:24 PM, Antoine Coeur wrote: >>>> Fix various typos in CryptoPkg. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Coeur >>>> --- >>>> CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- >>>> CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++-- >>>> 2 files changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>>> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>>> index d63c23df09..540c5715cb 100644 >>>> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>>> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>>> @@ -142,7 +142,7 @@ IMPLEMENT_ASN1_FUNCTIONS (TS_TST_INFO) >>>> @param[in] Asn1Time Pointer to the ASN.1 >>>> GeneralizedTime to be converted. >>>> @param[out] SigningTime Return the corresponding EFI Time. >>>> >>>> - @retval TRUE The time convertion succeeds. >>>> + @retval TRUE The time conversion succeeds. >>> >>> The typos are indeed fixed, so: >>> Reviewed-by: Philippe Mathieu-Daude >>> >>> However reading this description makes me suspicious, I'd have >>> written >>> "The time convertion succeeded.", but I'm not native English speaker >>> so >>> I'll let someone with more insurance opinate. >> >> I'm not a native speaker either, but I'd write "conversion" as well. >> (Like revert -> reversion, subvert -> subversion, avert -> aversion, >> and so on.) > > Oops, I copy/pasted the wrong line :S > Indeed the correct word is "conversion", thanks for correcting me. > > My wonder is about what is the correct use between succeeds/succeeded, > I'd expect the following diff: > > - @retval TRUE The time convertion succeeds. > + @retval TRUE The time conversion succeeded. Personally I'm fine either way, succeeds/succeeded. ... While the latter does look a bit improved, this patch is about typo fixes, not grammar fixes, so I guess we should stick with just conver[ts]ion for now. Just my 2 cents. Thanks Laszlo