Re: [edk2-devel] Fixing edk2-basetools CI

["Rebecca Cran" <rebecca@bsdio.com>]

No, setup.py or some other build backend configuration (e.g. Hatchling, 
Flit or PDM) is still needed to build the distribution package.

I don't know if it could be simplified though: I'll look into that later.


Yes, I suspect we could use the CLI commands feature and remove the 
wrappers. I'll work on that later, probably after I've gone through the PRs.


-- 

Rebecca Cran


On 2/11/24 23:03, Kinney, Michael D wrote:
> Hi Rebecca,
>
> Thank you for working on this.
>
> If pyproject.toml is added, then can setup.py be removed completely?
>
> Also, the CLI commands for pyproject.toml are listed as edk2_build and
> edk2_ecc.  Can't we use this feature of pyproject.toml to add build
> and ecc to the command set and remove the need for the command
> wrappers? Perhaps an additional change after we have CI working?
>
> Thanks,
>
> Mike
>
>> -----Original Message-----
>> From: Rebecca Cran <rebecca@bsdio.com>
>> Sent: Sunday, February 11, 2024 8:15 PM
>> To: Sean <spbrogan@outlook.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>; Michael Kubacki
>> <mikuback@linux.microsoft.com>; Joey Vagedes
>> <joeyvagedes@microsoft.com>
>> Cc: devel@edk2.groups.io
>> Subject: Fixing edk2-basetools CI
>>
>> Hi everyone,
>>
>>
>> I've created a couple of PRs in the edk2-basetools project which I'm
>> hoping will go towards fixing the CI and allowing releases to be
>> published again.
>>
>> I'd appreciate any reviews.
>>
>>
>> Disable flake8: https://github.com/tianocore/edk2-basetools/pull/115
>>
>> Add pyproject.toml and update setup.py:
>> https://github.com/tianocore/edk2-basetools/pull/116
>>
>>
>> Once CI is working again, I'll start working through the backlog of
>> open
>> PRs.
>>
>>
>> --
>> Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115349): https://edk2.groups.io/g/devel/message/115349
Mute This Topic: https://groups.io/mt/104306226/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-