From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2DD749415EB for ; Mon, 12 Feb 2024 11:26:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pf/Ux0gmPVJk6cNwWQ7vw1F5Tsb6qWWSjUnyp3v40Xg=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707737210; v=1; b=EKZaEO/cmbpZj3oKRn+XVk3A5WEq0FcVVgY8MbSlW0Z7TKMFZE91MwMN44jOudtOQSraMoUm E6JWZZAEG8LQabqqYznAGozZ6FwGU523tB7hUK+hivgaYDFibhQnjQP8lU/iYL42P8w+iiXDbca NLZNhRId/5YFGK0TUt14Nvjc= X-Received: by 127.0.0.2 with SMTP id JCjZYY7687511xZlSBR45mKu; Mon, 12 Feb 2024 03:26:50 -0800 X-Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mx.groups.io with SMTP id smtpd.web11.4505.1707737209903964789 for ; Mon, 12 Feb 2024 03:26:50 -0800 X-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id E35F55C0058; Mon, 12 Feb 2024 06:26:48 -0500 (EST) X-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 12 Feb 2024 06:26:48 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnheptdegudfhleelheekvdehfeehleekheelfeduleegvdduheevtedtveegleeu vdelnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 12 Feb 2024 06:26:48 -0500 (EST) Message-ID: <2fe83108-e19b-4c95-8c45-08f43594e8cd@bsdio.com> Date: Mon, 12 Feb 2024 04:26:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Fixing edk2-basetools CI To: "Kinney, Michael D" , Sean , Michael Kubacki , Joey Vagedes Cc: "devel@edk2.groups.io" References: From: "Rebecca Cran" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9wdfx1UKba5N997IKwawJulIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="EKZaEO/c"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io No, setup.py or some other build backend configuration (e.g. Hatchling,=20 Flit or PDM) is still needed to build the distribution package. I don't know if it could be simplified though: I'll look into that later. Yes, I suspect we could use the CLI commands feature and remove the=20 wrappers. I'll work on that later, probably after I've gone through the PRs= . --=20 Rebecca Cran On 2/11/24 23:03, Kinney, Michael D wrote: > Hi Rebecca, > > Thank you for working on this. > > If pyproject.toml is added, then can setup.py be removed completely? > > Also, the CLI commands for pyproject.toml are listed as edk2_build and > edk2_ecc. Can't we use this feature of pyproject.toml to add build > and ecc to the command set and remove the need for the command > wrappers? Perhaps an additional change after we have CI working? > > Thanks, > > Mike > >> -----Original Message----- >> From: Rebecca Cran >> Sent: Sunday, February 11, 2024 8:15 PM >> To: Sean ; Kinney, Michael D >> ; Michael Kubacki >> ; Joey Vagedes >> >> Cc: devel@edk2.groups.io >> Subject: Fixing edk2-basetools CI >> >> Hi everyone, >> >> >> I've created a couple of PRs in the edk2-basetools project which I'm >> hoping will go towards fixing the CI and allowing releases to be >> published again. >> >> I'd appreciate any reviews. >> >> >> Disable flake8: https://github.com/tianocore/edk2-basetools/pull/115 >> >> Add pyproject.toml and update setup.py: >> https://github.com/tianocore/edk2-basetools/pull/116 >> >> >> Once CI is working again, I'll start working through the backlog of >> open >> PRs. >> >> >> -- >> Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115349): https://edk2.groups.io/g/devel/message/115349 Mute This Topic: https://groups.io/mt/104306226/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-