Re: [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?

["Rebecca Cran" <rebecca@bsdio.com>]

I'm ok keeping the current behavior as long as the DEBUG_ERROR message 
is removed or downgraded to DEBUG_INFO. As it is, it makes it look as 
though the driver has failed when error messages are highlighted during 
the boot.

-- 
Rebecca Cran

On 7/8/24 21:53, Nickle Wang wrote:
>> Should the following change be made to make sure RegularExpressionDxe is
>> loaded before RedfishPlatformConfigDxe?
> 
> It is ok that RegularExpressionDxe is loaded after RedfishPlatformConfigDxe because EfiCreateProtocolNotifyEvent() is used to get Regular expression protocol. And I don't have objection to add the dependency as you suggested to eliminate the false alarm.
> 
> Regards,
> Nickle
> 
>> -----Original Message-----
>> From: Rebecca Cran <rebecca@bsdio.com>
>> Sent: Tuesday, July 9, 2024 4:25 AM
>> To: Abner Chang <abner.chang@amd.com>; Nickle Wang <nicklew@nvidia.com>;
>> Igor Kulchytskyy <igork@ami.com>
>> Cc: devel@edk2.groups.io
>> Subject: RedfishPlatformConfigDxe needs Depex on
>> gEfiRegularExpressionProtocolGuid?
>>
>> External email: Use caution opening links or attachments
>>
>>
>> I noticed that RedfishPlatformConfigDxe prints an error message that it can't find
>> EFI_REGULAR_EXPRESSION_PROTOCOL.
>>
>> Should the following change be made to make sure RegularExpressionDxe is
>> loaded before RedfishPlatformConfigDxe?
>>
>> diff --git
>> a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf
>> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf
>> index 2db47c2cf..7490d89be 100644
>> --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf
>> +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf
>> @@ -60,4 +60,4 @@
>>     gEfiRedfishPkgTokenSpaceGuid.PcdRedfishPlatformConfigDebugProperty
>>
>>    [Depex]
>> -  TRUE
>> +  gEfiRegularExpressionProtocolGuid^M
>>
>> --
>> Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119854): https://edk2.groups.io/g/devel/message/119854
Mute This Topic: https://groups.io/mt/107110826/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-