From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 26768AC1A01 for ; Tue, 9 Jul 2024 18:48:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JUvftjwOS4HlXF+WPHmAMls4rLiSnJXQnPFBzRrBtc8=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1720550885; v=1; b=b+bLIaRB0NoAer6oRaNqeNvq7FDUo+bfjS7sVLc2ZXWWYWjls95C38e6lu1gvmQbZgF8p1nW 7p4tfKpS1WCjj9/So2l6rrkSzY4ZJQpDc6B3wIQV2EvNXCPXi7K1IprqHX7Q3eNCbWtlJrXja// cR5wlfyxQGqbRDCVUlcfIhtYJ7fy/27S295+kfIcUSQ2k7ujeqStJ5u7WVjyHCPtdIXAnlIei5C wMP+tjYFakAOA1ym2PR9+MkV4EPFhQ6v3CyirA6RfCZHMB/KzJItqOz1Z8qQquq6timeXJuRGek 9syxZL6OhyLQiHkBEzJxfcpvPo9v1bH/eQq8CpsuE3wRQ== X-Received: by 127.0.0.2 with SMTP id WZORYY7687511xEB2L2SICYK; Tue, 09 Jul 2024 11:48:04 -0700 X-Received: from fhigh8-smtp.messagingengine.com (fhigh8-smtp.messagingengine.com [103.168.172.159]) by mx.groups.io with SMTP id smtpd.web11.3593.1720550883523432357 for ; Tue, 09 Jul 2024 11:48:03 -0700 X-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.nyi.internal (Postfix) with ESMTP id C9E9F11401D1; Tue, 9 Jul 2024 14:48:02 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 09 Jul 2024 14:48:02 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdelgddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpefhkedvkedvhfdtvdetheeuueelteejhfeiheejuefhtddutddvgedutdek veelhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 Jul 2024 14:48:00 -0400 (EDT) Message-ID: <2ff03f01-0ddd-477d-9df7-ae01473f1f93@bsdio.com> Date: Tue, 9 Jul 2024 12:48:00 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid? To: Nickle Wang , Abner Chang , Igor Kulchytskyy Cc: "devel@edk2.groups.io" References: From: "Rebecca Cran" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 09 Jul 2024 11:48:03 -0700 Resent-From: rebecca@bsdio.com Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kkwMoPMXkJBcTDBIHAL7uTmAx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=b+bLIaRB; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io I'm ok keeping the current behavior as long as the DEBUG_ERROR message=20 is removed or downgraded to DEBUG_INFO. As it is, it makes it look as=20 though the driver has failed when error messages are highlighted during=20 the boot. --=20 Rebecca Cran On 7/8/24 21:53, Nickle Wang wrote: >> Should the following change be made to make sure RegularExpressionDxe is >> loaded before RedfishPlatformConfigDxe? >=20 > It is ok that RegularExpressionDxe is loaded after RedfishPlatformConfigD= xe because EfiCreateProtocolNotifyEvent() is used to get Regular expression= protocol. And I don't have objection to add the dependency as you suggeste= d to eliminate the false alarm. >=20 > Regards, > Nickle >=20 >> -----Original Message----- >> From: Rebecca Cran >> Sent: Tuesday, July 9, 2024 4:25 AM >> To: Abner Chang ; Nickle Wang ; >> Igor Kulchytskyy >> Cc: devel@edk2.groups.io >> Subject: RedfishPlatformConfigDxe needs Depex on >> gEfiRegularExpressionProtocolGuid? >> >> External email: Use caution opening links or attachments >> >> >> I noticed that RedfishPlatformConfigDxe prints an error message that it = can't find >> EFI_REGULAR_EXPRESSION_PROTOCOL. >> >> Should the following change be made to make sure RegularExpressionDxe is >> loaded before RedfishPlatformConfigDxe? >> >> diff --git >> a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf >> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf >> index 2db47c2cf..7490d89be 100644 >> --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf >> +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf >> @@ -60,4 +60,4 @@ >> gEfiRedfishPkgTokenSpaceGuid.PcdRedfishPlatformConfigDebugProperty >> >> [Depex] >> - TRUE >> + gEfiRegularExpressionProtocolGuid^M >> >> -- >> Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119854): https://edk2.groups.io/g/devel/message/119854 Mute This Topic: https://groups.io/mt/107110826/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-