From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 326E4D811BB for ; Mon, 29 Jan 2024 15:22:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=f0A/Wmts6JXmpHvhps8po9cW4Krx6yw0e6AsclwcfnU=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706541756; v=1; b=CxFT+vOkQAgdhgasZgGb+I+3iSeVd7R8kFr1UOYjqEx0t6QrZcANsyTURuH86X3mANr5DrOd USss5xUuEeu3jmA+iiQz0lgFYDLTKEwQgSmOuzwZm6VMcSVOhqFtPNC+HtDKKu6F0xIS6dUBMyw 2exAe9iEoA8myU8jCMSfvxuc= X-Received: by 127.0.0.2 with SMTP id OZKVYY7687511xFbOR2rXIfE; Mon, 29 Jan 2024 07:22:36 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.17726.1706541756003202291 for ; Mon, 29 Jan 2024 07:22:36 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-3PdLxGnGPX-v7_TZFLwj-Q-1; Mon, 29 Jan 2024 10:21:42 -0500 X-MC-Unique: 3PdLxGnGPX-v7_TZFLwj-Q-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B39831C04188; Mon, 29 Jan 2024 15:21:41 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 159D9C1ED63; Mon, 29 Jan 2024 15:21:40 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DBB5C180038B; Mon, 29 Jan 2024 16:21:38 +0100 (CET) Date: Mon, 29 Jan 2024 16:21:38 +0100 From: "Gerd Hoffmann" To: Tom Lendacky Cc: devel@edk2.groups.io, Ard Biesheuvel , Erdem Aktas , Jiewen Yao , Laszlo Ersek , Liming Gao , Michael D Kinney , Min Xu , Zhiguang Liu , Rahul Kumar , Ray Ni , Michael Roth Subject: Re: [edk2-devel] [PATCH 13/16] UefiCpuPkg/MpInitLib: Always use AP Create if PcdSevSnpApicIds is set Message-ID: <2vfnxjr3lriticpun3svyeq5bwzkrvfmtwolavn4gxc6ir5bt7@hw6uun2ez7ey> References: <1948e02ed8167f9b9f8a71dd2d3216896720aa30.1706307195.git.thomas.lendacky@amd.com> MIME-Version: 1.0 In-Reply-To: <1948e02ed8167f9b9f8a71dd2d3216896720aa30.1706307195.git.thomas.lendacky@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mwv3RnULKfxi43UXUePRR3flx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CxFT+vOk; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Fri, Jan 26, 2024 at 04:13:12PM -0600, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 > > Currently, the first time an AP is started for an SEV-SNP guest, it relies > on the VMSA as set by the hypervisor. If the list of APIC IDs has been > retrieved, this is not necessary. Instead, use the SEV-SNP AP Create > protocol to start the AP for the first time and thereafter using the VMPL > at which the BSP is running. > > Signed-off-by: Tom Lendacky > +BOOLEAN > +SevSnpUseCreateAP ( > + IN CPU_MP_DATA *CpuMpData > + ) > +{ > + // > + // SEV-SNP is not supported on 32-bit build. > + // > + return FALSE; > +} Hmm. Should the 32-bit build just use the NULL versions of the Libraries? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114713): https://edk2.groups.io/g/devel/message/114713 Mute This Topic: https://groups.io/mt/103986469/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-