From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.3170.1573732979939094530 for ; Thu, 14 Nov 2019 04:03:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=V7DXJD75; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573732979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GYVvpQ5TV9lnTJcbfQyuhKvemXSCwFbRUfl/nDaL+2A=; b=V7DXJD75GpByEGPQijWXltPvxCyxHUa6YbTwrWh/6d7/EhL0K58lpMFLKkloHwKTo8LPHK 8Xv2sLdF4XN/iz5xlZq/J4Od1plhPGfVgvKXQqOy2EgmhqatSPdT2AG1RPBdbanpOlnX0m xZrcSLPB06r21/2nwQzvm7vDlOOXzbI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-72-kDRbsoLqNgWk1b15DzHRTQ-1; Thu, 14 Nov 2019 07:02:57 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17CD61A3E78; Thu, 14 Nov 2019 12:02:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-80.ams2.redhat.com [10.36.117.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF3D36B8EE; Thu, 14 Nov 2019 12:02:53 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/3] Add missing strings for uni files To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: Jian J Wang , Hao A Wu , Jiaxin Wu , Siyuan Fu , Maciej Rabeda , Eric Dong , Ray Ni References: <20191114114644.5504-1-shenglei.zhang@intel.com> From: "Laszlo Ersek" Message-ID: <30299526-f1a2-5930-aa9b-7b8ee32451d2@redhat.com> Date: Thu, 14 Nov 2019 13:02:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191114114644.5504-1-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: kDRbsoLqNgWk1b15DzHRTQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/14/19 12:46, Zhang, Shenglei wrote: > From: Shenglei Zhang >=20 > There are missing strings in MdeModulePkg.uni, NetworkPkg.uni > and UefiCpuPkg.uni. So add them into uni files. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Maciej Rabeda > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Shenglei Zhang (3): > MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD > NetworkPkg/NetworkPkg.uni: Add missing strings for PCD > UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for PCD >=20 > MdeModulePkg/MdeModulePkg.uni | 12 ++++++++++++ > NetworkPkg/NetworkPkg.uni | 7 +++++++ > UefiCpuPkg/UefiCpuPkg.uni | 16 ++++++++++++++++ > 3 files changed, 35 insertions(+) >=20 This blurb announces three patches in the series. However, in response to t= he blurb, five patches in total seem to have been posted (and, based on the= message-id fields in those patch emails, everything was sent out in a sing= le git invocation): [edk2-devel] [PATCH 1/3] MdeModulePkg/MdeModulePkg.uni: Add missing strings= for PCD [edk2-devel] [PATCH] MdePkg: Update the comments of IsLanguageSupported [edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles [edk2-devel] [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for= PCD [edk2-devel] [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for= PCD This makes no sense to me. Please either repost the full (5-part) series wi= th correct numbering on each patch (including the blurb), or else, please s= plit out the un-numbered patches to standalone postings. The decision betwe= en both options should be based on whether it is logical to collect all fiv= e patches into a single series, or if it's more logical to post 3 + 1 + 1 p= atches. (Note: despite appearances, this problem is *not* inherent to mailing lists= -- if you submit a github pull request with 5 patches, and it turns out th= at 2 out of 5 are (each) unrelated to anything else, then any reviewer wort= h their salt will request separate PRs for each of those stand-alone patche= s.) Thanks Laszlo